Skip to content

Library: Port 'Toasts' to Python - #732

Draft
UrtsiSantsi wants to merge 2 commits into
mainfrom
python_toasts
Draft

Library: Port 'Toasts' to Python#732
UrtsiSantsi wants to merge 2 commits into
mainfrom
python_toasts

Conversation

@UrtsiSantsi

Copy link
Copy Markdown
Contributor

No description provided.



action_console.connect("activate", on_activate)
workbench.window.add_action(action_console)

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this error here:

image

Is this because of #110?
The rest of the demo seems to work.

Comment threadsrc/Library/demos/Toasts/main.py Outdated

@theCapyparatheCapypara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you! The demo unfortunately does not launch for me:

Traceback (mostrecentcalllast):
File"/app/share/re.sonny.Workbench.Devel/gdbus_ext.py", line319, inon_method_callresult=method_func(obj, *args)
^^^^^^^^^^^^^^^^^^^^^^^File"/app/share/re.sonny.Workbench.Devel/python-previewer.py", line135, inrunspec.loader.exec_module(module)
File"<frozen importlib._bootstrap_external>", line940, inexec_moduleFile"<frozen importlib._bootstrap>", line241, in_call_with_frames_removedFile"/home/marco/.var/app/re.sonny.Workbench.Devel/data/re.sonny.Workbench.Devel/sessions/2023-11-11 17-13-05/main.py", line52, in<module>workbench.window.add_action(action_console)
^^^^^^^^^^^^^^^^^^^^^^^^^^^AttributeError: 'Window'objecthasnoattribute'add_action'

That part is probably not supportable yet in Python either, see also the Vala code and the issue it's refering: #110

@UrtsiSantsi

Copy link
Copy Markdown
ContributorAuthor

That's exactly what I said above 😄.
So what do we do:

  1. Since the demo is still useful without this action comment out the line and mention Allow using actions in the external preview #110
  2. Turn this into draft until Allow using actions in the external preview #110 is resolved

@sonnyp
sonnyp marked this pull request as draft November 12, 2023 10:58
@sonnyp

Copy link
Copy Markdown
Contributor

I have converted to draft.

@theCapypara

Copy link
Copy Markdown
Contributor

Oh, hm! Sorry about that, I think GitHub didn't show me your comments yesterday 🧐

@sonnyp

Copy link
Copy Markdown
Contributor

@UrtsiSantsi could you reopen this against https://github.com/workbenchdev/demos ?

I think we should move forward and just disable the action button for now. Like Vala

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UrtsiSantsi@sonnyp@theCapypara