Uh oh!
There was an error while loading. Please reload this page.
Clarify command overrides empty values - #17
Open
johnpfeiffer wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies the
commandOverridescontract for interview findings: empty or whitespace-only override values normalize to “no command” and remove the detected command.This matches the existing synthesizer behavior and the interviewer help guidance for removing placeholder commands.
Also updates the README setup flow to cover steps that tripped me up as a first-time contributor: bun generate:assets before typecheck, ca --version as a smoke test before bun link.
Changes
synthesizeProjectEntrytests to expect empty and whitespace-only command overrides to remove the detected command.bun generate:assetsandca --versionVerification
bun test src/__tests__/interview.spec.tsbun run typecheck