Skip to content

Clarify command overrides empty values - #17

Open
johnpfeiffer wants to merge 2 commits into
workos:mainfrom
johnpfeiffer:clarify-command-overrides-empty-values
Open

Clarify command overrides empty values#17
johnpfeiffer wants to merge 2 commits into
workos:mainfrom
johnpfeiffer:clarify-command-overrides-empty-values

Conversation

@johnpfeiffer

Copy link
Copy Markdown

Summary

Clarifies the commandOverrides contract for interview findings: empty or whitespace-only override values normalize to “no command” and remove the detected command.
This matches the existing synthesizer behavior and the interviewer help guidance for removing placeholder commands.

Also updates the README setup flow to cover steps that tripped me up as a first-time contributor: bun generate:assets before typecheck, ca --version as a smoke test before bun link.

Changes

  • Update synthesizeProjectEntry tests to expect empty and whitespace-only command overrides to remove the detected command.
  • Add explicit test case for exact empty string ('') alongside existing whitespace-only (' ') case
  • Update README setup and verification commands with bun generate:assets and ca --version

Verification

  • bun test src/__tests__/interview.spec.ts
  • bun run typecheck

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@johnpfeiffer