Uh oh!
There was an error while loading. Please reload this page.
fix: improve installer error handling, env var uploads, and port detection - #96
Draft
nicknisi wants to merge 2 commits into
Draft
fix: improve installer error handling, env var uploads, and port detection#96nicknisi wants to merge 2 commits into
nicknisi wants to merge 2 commits into
Conversation
3 tasks
- Fix silent commit failure: track postInstallError in state machine context so emitComplete emits success: false when commit/push/PR fails - Capture pre-commit hook output: stageAndCommit now pipes stderr/stdout and includes hook output in error messages - Include WORKOS_COOKIE_PASSWORD and redirect URI in Vercel env uploads by reading .env.local after generation - Improve port detection: detect PORT=NNNN in dev scripts and .env files - Add existing env var conflict detection before Vercel upload prompt - Enhance agent spinner with file operation names and elapsed time - Add tests for post-install, port detection, and env var upload
nicknisiforce-pushed
the
nicknisi/greg-friction-log
branch
from
March 20, 2026 16:35
179fa40 to
dae0748Comparenicknisi
marked this pull request as draft
April 3, 2026 15:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several bugs and UX gaps in
workos installdiscovered during internal testing on a real-world Next.js + Vercel project.emitCompletenow emitssuccess: falsewhen commit/push/PR fails, instead of always reporting success. Pre-commit hook stderr/stdout is captured and surfaced.WORKOS_COOKIE_PASSWORDandNEXT_PUBLIC_WORKOS_REDIRECT_URIare now included when uploading env vars to Vercel.PORT=NNNNinline env vars in dev scripts and reads.env/.env.localfiles as fallback before defaulting to 3000.Companion PR for the skills repo: workos/skills#10
Test plan
pnpm typecheckpassespnpm testpasses (81 files, 1165 tests — 16 new)pnpm buildpassesworkos installon a Next.js + Vercel project with pre-commit hooks