refactor(stellar): migrate wraith-names to persistent() storage - #92
Merged
truthixify merged 2 commits intoJun 26, 2026
Merged
truthixify merged 2 commits into
truthixify merged 2 commits into
Conversation
- Audit: removed all instance() storage calls, confirmed zero remaining - Migrated replay protection keys (DataKey::Replay) to persistent() for durability - Refactored extend_ttls() to only extend persistent entries - Fixed code duplication in register_internal() and update_internal() - Fixed malformed function signatures and import statements Storage decisions: - Per-name data (Name, Reverse): persistent (scales with registry size) - Replay protection: persistent (security-critical, must survive contract) - Instance storage: removed (doesn't scale, not needed) Breaking change: existing deployments require fresh contract ID. Keeper service (wraith-protocol#50) TTL maintenance now only extends persistent keys. Fixes wraith-protocol#68
|
@debbieAmoni Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Clean merge. MIGRATION_VERIFICATION.md + STORAGE.md + 23 lines of helper additions to wraith-names on top of the migration from #83. Thanks @debbieAmoni. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
instance()storage callsextend_ttls()to only manage persistent entriesStorage Decisions
Notes
wraith-names#50) TTL maintenance now handles persistent keys onlyFixes #68