Uh oh!
There was an error while loading. Please reload this page.
Prune redundant posts/render.go - #10
Conversation
2aaf86d to
59a0bc3Compareeddsalkield
commented
Sep 24, 2020
I initially introduced more commits than I intended in this PR. I've cleaned it up with a force push, and merged the branches to remove conflicts. |
thebaer
commented
Sep 27, 2020
Thanks for submitting this! While WF doesn't need these funcs, we do have some small proprietary web apps that rely on it right now. That might change in the future, but for now, we'll need to keep them in the library. Since this is a breaking change, we'll slate this for |
eddsalkield
commented
Sep 27, 2020
That's great, thanks. There might yet be more changes I'd like to make for code cleanup/packaging reasons, but once they're done can we consider cutting a 2.0.0 release for versioning reasons? |
thebaer
commented
Oct 3, 2020
Yep, that'll work great -- and then we'll just want to update WriteFreely to use v2.0. |
None of the functions in
posts/render.goare ever used anywhere. By pruning this dead code, we lose the dependencies ongithub.com/microcosm-cc/bluemondayandgithub.com/writeas/saturday, aiding the packaging process.Fixes issue #9.