Skip to content

Fix #479: Superfluous optional - #480

Merged
banterCZ merged 1 commit into
developfrom
issues/479-remove-optional
Aug 7, 2026
Merged

Fix #479: Superfluous optional#480
banterCZ merged 1 commit into
developfrom
issues/479-remove-optional

Conversation

@banterCZ

@banterCZbanterCZ commented Aug 7, 2026

Copy link
Copy Markdown
Member

No description provided.

@banterCZ
banterCZ requested review from michal-rozehnal-w and romanstrobl and a lite review from CopilotAugust 7, 2026 04:39
CopilotAI reviewed Aug 7, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies DefaultRestClient’s WebClient Jackson codec setup by removing a superfluous Optional wrapper around the internally-created JsonMapper.

Changes:

  • Replace Optional<JsonMapper> with a direct JsonMapper return value from createObjectMapper(...).
  • Always configure JacksonJsonEncoder/JacksonJsonDecoder using the created mapper instead of guarding with ifPresent(...).

Comment threadrest-client-base/src/main/java/com/wultra/core/rest/client/base/DefaultRestClient.java
romanstrobl
romanstrobl approved these changes Aug 7, 2026
View reviewed changes

@romanstroblromanstrobl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@banterCZ
banterCZ merged commit 733819f into developAug 7, 2026
3 checks passed
@banterCZ
banterCZ deleted the issues/479-remove-optional branch August 7, 2026 07:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@romanstroblromanstroblromanstrobl approved these changes
@michal-rozehnal-wmichal-rozehnal-wAwaiting requested review from michal-rozehnal-w

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@banterCZ@romanstrobl