Uh oh!
There was an error while loading. Please reload this page.
Conversation
Lando is being phased out in favor of DDEV. Adds .ddev/config.yaml (PHP 8.4, nginx-fpm) and documents the workflow in the README; xdebug is off by default and toggled on demand with `ddev xdebug on` for step-debugging or coverage runs. Also bumps the README's stated PHP prerequisite to match.
Bumps mglaman/phpstan-drupal to ^2.1 and phpstan/phpstan-deprecation-rules to ^2.0. tomasvotruba/cognitive-complexity also has to move to ^1.2: the previous ^0.1.1 version's nette/utils dependency requires PHP <8.4, which broke composer install outright once phpstan-drupal 2.x (and its transitive phpstan/phpstan: ^2.1) pulled in newer dependencies. cognitive-complexity 1.2.0 requires php: ^8.3 and phpstan/phpstan: ^2.0, so the minimum PHP version moves to 8.4 to match the DDEV/CI environment. phpunit/phpunit is bumped from ^8.3 to ^10 in require-dev: PHPUnit 8's mock/reflection internals (ReflectionUnionType::getName(), MockBuilder::setMethodsExcept()) are incompatible with PHP 8.3+. Migrates phpunit.xml to the PHPUnit 10 schema and replaces setMethodsExcept() with explicit onlyMethods() lists across the test suite, since PHPUnit 10 has no direct 'mock everything except X' equivalent. Also routes the pre-commit hook through DDEV (EXEC_GRUMPHP_COMMAND: ddev php in grumphp.yml) so it validates against the same PHP 8.4 environment instead of whatever PHP happens to be on the host, and ignores PHPUnit 10's new .phpunit.cache/ directory.
…oaderTest The annotation referenced a nonexistent import() method (with trailing parens, which is itself invalid @Covers syntax). The class only defines imports() (plural) - the intended target all along. PHPUnit 10's stricter annotation validation started flagging this as a test warning; PHPUnit 8 silently ignored it.
Runs `ddev exec vendor/bin/grumphp run` in CI, reusing the exact same DDEV environment as local development instead of maintaining a separate CI-specific PHP image and dependency set. Drops the SonarQube analysis step that ran after CircleCI's build - its coverage.xml input required a coverage driver (xdebug/pcov) that isn't installed in this environment, and nothing else consumes that report. The <coverage> block is removed from phpunit.xml accordingly; it can be reintroduced if a coverage consumer is set up again.
tormi added a commit
to wunderio/drupal-project
that referenced
this pull request
Jul 16, 2026
Requires wunderio/code-quality:dev-GH-126 (wunderio/code-quality#127), which bumps mglaman/phpstan-drupal and phpstan/phpstan-deprecation-rules to their PHPStan-2-compatible releases. This resolves a false positive where PHPStan 1.12 rejected repeated #[Group(...)] attributes on a class even though PHPUnit\Framework\Attributes\Group is declared Attribute::IS_REPEATABLE. phpstan/phpstan and phpstan/phpstan-phpunit don't need to be pinned directly here; they resolve to their 2.x releases already via mglaman/phpstan-drupal's and drupal/core-dev's own constraints. Temporary until wunderio/code-quality cuts a tagged release including this upgrade (tracked in wunderio/code-quality#126), at which point this should switch back to a version constraint.
This was referenced Jul 16, 2026
Open
nette/finder is abandoned. The suggestion in #118 to swap it for nette/utils doesn't work: Nette\Utils\Finder is shipped by nette/finder itself, not nette/utils - the two packages aren't interchangeable for this. mglaman/phpstan-drupal already depends on symfony/finder (actively maintained) and upstream's own DrupalAutoloader.php (which this file is based on) already made the same switch, so Finder::findFiles('*.inc')->in() becomes Finder::create()->files()->name('*.inc')->in(). symfony/finder isn't added to composer.json's require directly since these files already hard-depend on mglaman/phpstan-drupal for Extension/ExtensionDiscovery, which guarantees symfony/finder is present transitively. Also tightens several other composer.json version constraints to match their currently-resolved versions.
The SonarQube coverage step this instruction referred to was removed in the CircleCI-to-GitHub-Actions migration; the grumphp run command doesn't need XDEBUG_MODE=coverage for anything anymore.
There was a problem hiding this comment.
Pull request overview
This PR modernizes the repository’s tooling baseline by upgrading the PHP/static-analysis/testing stack (PHP 8.4, PHPStan 2.x, PHPUnit 10) and switching local/CI workflows from Lando/CircleCI to DDEV/GitHub Actions, including replacing nette/finder usage.
Changes:
- Upgrade Composer requirements for PHP 8.4, PHPStan-2-compatible extensions, and PHPUnit 10; update PHPUnit configuration accordingly.
- Migrate local development workflow to DDEV and CI to GitHub Actions (running the GrumPHP suite).
- Update tests for PHPUnit 10 mock-builder API changes, and replace
Nette\Utils\Finderusage with Symfony Finder in Drupal autoloader code.
Reviewed changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/YamlLint/YamlLintTaskTest.php | Update PHPUnit mocking API usage for PHPUnit 10. |
tests/PhpStan/PhpStanTaskTest.php | Update PHPUnit mocking API usage for PHPUnit 10. |
tests/Phpcs/PhpcsTaskTest.php | Update PHPUnit mocking API usage for PHPUnit 10. |
tests/PhpCompatibility/PhpCompatibilityTaskTest.php | Update PHPUnit mocking API usage for PHPUnit 10. |
tests/PhpCheckSyntax/PhpCheckSyntaxTaskTest.php | Update PHPUnit mocking API usage for PHPUnit 10. |
tests/JsonLint/JsonLintTaskTest.php | Update PHPUnit mocking API usage for PHPUnit 10. |
tests/Ecs/EcsTaskTest.php | Update PHPUnit mocking API usage for PHPUnit 10. |
tests/ContextRunTraitTest.php | Update PHPUnit mocking API usage for PHPUnit 10 (trait mock builder). |
tests/ConfigurableTaskTraitTest.php | Update PHPUnit mocking API usage for PHPUnit 10 (trait mock builder). |
tests/CheckFilePermissions/CheckFilePermissionsTaskTest.php | Update PHPUnit mocking API usage for PHPUnit 10. |
tests/AbstractSinglePathProcessingTaskTest.php | Update PHPUnit mocking API usage for PHPUnit 10 (abstract-class mocks). |
tests/AbstractProcessingTaskTest.php | Update PHPUnit mocking API usage for PHPUnit 10 (abstract-class mocks). |
tests/AbstractMultiPathProcessingTaskTest.php | Update PHPUnit mocking API usage for PHPUnit 10 (abstract-class mocks). |
tests/AbstractLintTaskTest.php | Update PHPUnit mocking API usage for PHPUnit 10 (abstract-class mocks). |
tests/AbstractExternalExtensionLoaderTest.php | Adjust PHPUnit @covers annotation for the covered method name. |
src/Drupal/DrupalAutoloaderBase.php | Replace Nette Finder usage with Symfony Finder for legacy include discovery. |
src/Drupal/DrupalAutoloader.php | Replace Nette Finder usage with Symfony Finder for Drush include discovery. |
README.md | Update CI badge, PHP version prerequisite, and document DDEV local development workflow. |
phpunit.xml | Migrate PHPUnit configuration to PHPUnit 10 schema and source/include format. |
grumphp.yml | Configure GrumPHP git hook execution via DDEV (EXEC_GRUMPHP_COMMAND). |
composer.json | Bump PHP requirement to 8.4, upgrade PHPStan/PHPUnit/tooling dependencies, remove nette/finder. |
.lando/tooling-phpunit.sh | Remove Lando-specific phpunit tooling script. |
.lando/tooling-grumphp.sh | Remove Lando-specific GrumPHP tooling script. |
.lando.yml | Remove Lando configuration (migrating to DDEV). |
.gitignore | Ignore PHPUnit 10 cache dir and DDEV generated artifacts. |
.github/workflows/ci.yml | Add GitHub Actions CI using DDEV and running grumphp run. |
.ddev/config.yaml | Add DDEV project configuration targeting PHP 8.4. |
.circleci/config.yml | Remove CircleCI configuration (migrating to GitHub Actions). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+38
to
+41
| "php": "^8.4", | ||
| "symfony/polyfill-iconv": "^1.37", | ||
| "phpro/grumphp": "^2.22", | ||
| "drupal/coder": "^8.3", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mglaman/phpstan-drupal,phpstan/phpstan-deprecation-rules, andtomasvotruba/cognitive-complexityto PHPStan-2-compatible versions, and requires PHP^8.4, resolving Upgrade PHPStan to 2.x (mglaman/phpstan-drupal and phpstan-deprecation-rules still pinned to 1.x) #126 and v3.0.2 not compatible with PHP >=8.4 #125ddev exec vendor/bin/grumphp run, we will soon replace CircleCI with GH Actions in other projects as wellnette/finderwithsymfony/finder(Replace deprecated nette/finder dependency with nette/utils #118)Test plan
ddev startandddev exec vendor/bin/grumphp runsucceed locallyvendor/bin/phpunitpasses under PHP 8.4