Skip to content

remove distutils - #463

Merged
dcherian merged 2 commits into
xarray-contrib:mainfrom
ocefpaf:remove_distutils
Aug 9, 2023
Merged

remove distutils#463
dcherian merged 2 commits into
xarray-contrib:mainfrom
ocefpaf:remove_distutils

Conversation

@ocefpaf

@ocefpafocefpaf commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

It is imported but unused (tests passes without it). Removing this import will make cf_xarray ready to Python 3.12.


Edit: Changing to packaging.version.parse is not the same thing as LooseVersion, see https://discuss.python.org/t/add-looseversion-to-pypa/24359/6, but we should be OK b/c here b/c the packages checked all follow PEP440.

@codecov

codecovBot commented Aug 9, 2023

Copy link
Copy Markdown

Codecov Report

Merging #463 (7d0ba25) into main (af8475a) will not change coverage.
The diff coverage is 50.00%.

@@ Coverage Diff @@## main #463 +/- ##
=======================================
Coverage 86.34% 86.34% =======================================
Files 22 22 Lines 4188 4188 Branches 214 214 =======================================
Hits 3616 3616 Misses 514 514 Partials 58 58 
FlagCoverage Δ
mypy37.44% <50.00%> (ø)
unittests95.97% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files ChangedCoverage Δ
cf_xarray/tests/__init__.py64.00% <50.00%> (ø)

@dcherian

Copy link
Copy Markdown
Contributor

Cool thanks! I copied that from xarray, so if you could change it there, that would be great too!

@dcherian
dcherian merged commit cbf57df into xarray-contrib:mainAug 9, 2023
@ocefpaf
ocefpaf deleted the remove_distutils branch August 9, 2023 18:45
@ocefpaf

Copy link
Copy Markdown
ContributorAuthor

Cool thanks! I copied that from xarray, so if you could change it there, that would be great too!

Will do. The sooner we get rid of distutils the better, or we will see tons of dumb breakages when moving to Python 3.12.

@ocefpaf

Copy link
Copy Markdown
ContributorAuthor

Looks like someone already implemented the necessary changes in xarray.

See pydata/xarray#6096

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ocefpaf@dcherian