Skip to content
This repository was archived by the owner on Oct 24, 2024. It is now read-only.

is_hollow method - #272

Merged
TomNicholas merged 6 commits into
xarray-contrib:mainfrom
TomNicholas:is_hollow
Oct 25, 2023
Merged

is_hollow method#272
TomNicholas merged 6 commits into
xarray-contrib:mainfrom
TomNicholas:is_hollow

Conversation

@TomNicholas

@TomNicholasTomNicholas commented Oct 25, 2023

Copy link
Copy Markdown
Member

Introduces the concept of a "hollow tree" - a tree which contains data only at the leaves. This is a codified name for a specific tree structure that a lot of users already intuitively create. Codifying it is useful because there are some operations (e.g. reorder - see #271) that don't make sense for non-hollow trees.

  • Codifies a concept from Tree "broadcasting" #199 (comment)
  • Tests added
  • Passes pre-commit run --all-files
  • New functions/methods are listed in api.rst
  • Changes are summarized in docs/source/whats-new.rst

@TomNicholasTomNicholas added the enhancement New feature or request label Oct 25, 2023
@TomNicholas
TomNicholas enabled auto-merge (squash) October 25, 2023 18:01
@TomNicholas
TomNicholas merged commit e6d9420 into xarray-contrib:mainOct 25, 2023
@TomNicholas
TomNicholas deleted the is_hollow branch October 25, 2023 18:09
flamingbear pushed a commit to flamingbear/rewritten-datatree that referenced this pull request Jan 19, 2024
* tests
* implementation
* API docs
* narrative docs
* whatsnew
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@TomNicholas