Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Oct 24, 2024. It is now read-only.
Add zarr read/write - #30
Merged
Merged
Conversation
TomNicholas
suggested changes
Aug 27, 2021
TomNicholas
left a comment
Member
There was a problem hiding this comment.
Thanks again @jhamman , this looks nice! There are just a couple of ways that the code could be simplified.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Tom Nicholas <35968931+TomNicholas@users.noreply.github.com>
* use assert_tree_equal * iterate over subtree * use pathlib
jhamman
commented
Aug 30, 2021
Author
@TomNicholas - I think I've resolved all your comments. |
TomNicholas
approved these changes
Aug 30, 2021
TomNicholas
left a comment
Member
There was a problem hiding this comment.
Thanks @jhamman ! That's great.
flamingbear pushed a commit
to flamingbear/rewritten-datatree
that referenced
this pull request
Jan 19, 2024
* add test for roundtrip and support empty nodes * update roundtrip test, improves empty node handling in IO * add zarr read/write support * support netcdf4 or h5netcdf * netcdf is optional, zarr too! * Apply suggestions from code review Co-authored-by: Tom Nicholas <35968931+TomNicholas@users.noreply.github.com> Co-authored-by: Tom Nicholas <35968931+TomNicholas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#28
This PR adds read and write support for Zarr.
It also refactors the
open_datatreefunction to avoid calling a recursive loader. Instead, we use an iterator over group keys.