Remove obsolete strict xfail on the streaming 3-D reproject test (#3100) - #3181
Merged
Conversation
#3111 fixed the 2-D output buffer crash in _reproject_streaming (#3100) two minutes before #3118 merged a strict xfail pinning that same crash. On merged main the test body passes, so the strict marker fails CI with XPASS. Drop the xfail and let the test assert streaming vs in-memory parity directly.
This was referenced Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on main fails with
[XPASS(strict)]ontest_reproject_streaming_3101.py::TestStreaming3D::test_3d_source_streams.This was a merge race: #3111 (merged 13:11 UTC) fixed the 2-D output buffer crash in
_reproject_streamingas part of the dtype work, and #3118 (merged 13:13 UTC) added a strict xfail test pinning that same crash, written against pre-#3111 main. With both merged, the test body passes and the strict xfail marker fails the run.The test already says what to do when this happens: "Once #3100 is fixed the xfail comes off and the streaming result must match the in-memory 3-D path." This PR removes the xfail marker and updates the stale docstring, so the parity assertions now run.
Closes #3100 (the fix itself landed in #3111; this PR turns on the regression test).
Test plan
pytest xrspatial/tests/test_reproject_streaming_3101.py: 15 passed (was 1 failed via XPASS(strict))pytest xrspatial/tests/test_reproject.py: 439 passed