fix: pin packaging to newest semver; do not fail on bump push - #19
Merged
Conversation
GitHub Latest is the newest-created release, so backfilling v0.5.1 looked like latest and tried to downgrade pins. Compare git tags. A 403 from PACKAGING_BUMP_TOKEN must not fail the release job.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Backfilling
v0.5.1published the GitHub Release (good), then packaging-bump treated it as Latest (GitHub Latest = newest-created, not highest semver) and tried to pin Homebrew/Scoop/winget down to 0.5.1. The push 403'd (PACKAGING_BUMP_TOKENcannot push), which failed the whole release job.git tag --sort=-v:refname; skip the pin when this tag is not the newest stable tag.v0.5.2is marked Latest again.v0.5.1remains a real release with assets.How to test
go test ./internal/versionChecklist