Skip to content

feat(internal/config): implement trie for longest common prefix - #429

Open
MeteorsLiu wants to merge 14 commits into
xgo-dev:mainfrom
MeteorsLiu:trie
Open

feat(internal/config): implement trie for longest common prefix#429
MeteorsLiu wants to merge 14 commits into
xgo-dev:mainfrom
MeteorsLiu:trie

Conversation

@MeteorsLiu

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecovBot commented Jun 6, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (8bb3596) to head (c0263ed).
Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #429 +/- ##
=======================================
Coverage 84.38% 84.38% =======================================
Files 27 27 Lines 2728 2728 =======================================
Hits 2302 2302 Misses 385 385 Partials 41 41 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qiniu-x

qiniu-xBot commented Jun 6, 2025

Copy link
Copy Markdown

[Git-flow] Hi @MeteorsLiu, There are some suggestions for your information:


Rebase suggestions

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

Details

If you have any questions about this comment, feel free to raise an issue here:

Comment thread_xtool/internal/header/trie_test.go Outdated
Comment thread_xtool/internal/header/trie.go Outdated
Comment thread_xtool/internal/header/trie.go Outdated
@xushiwei

Copy link
Copy Markdown
Contributor

为了实现设计驱动,我倾向于我们应该先产出设计文档。我的建议目录结构如下:

第一层是语言,视为文档的根:

  • doc/zh/...
  • doc/en/...

根目录默认只放用户使用相关,如 quickstart 之类。

llccpg 开发者相关的放到 doc/zh/dev 子目录下。我们之前已经提供的文档 https://github.com/goplus/llcppg/blob/main/doc/llcppg.md 应该主要是面向开发者的,当然开头部分有面向用户的部分,可以分拆一下。

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MeteorsLiu@xushiwei@luoliwoshang