Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 100 additions & 0 deletions apps/server/src/provider/Layers/ClaudeAdapter.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -95,8 +95,17 @@ class FakeClaudeQuery implements AsyncIterable<SDKMessage> {
}
}

/**
* Models the real SDK's interrupt, which is a control request that can block
* until the in-flight tool call returns. Set to make it never answer.
*/
public interruptNeverResolves = false;

readonly interrupt = async (): Promise<void> => {
this.interruptCalls.push(undefined);
if (this.interruptNeverResolves) {
await new Promise<never>(() => {});
}
};

readonly stopTask = async (taskId: string): Promise<void> => {
Expand DownExpand Up@@ -1665,6 +1674,97 @@ describe("ClaudeAdapterLive", () => {
);
});

it.effect("interruptTurn stops the session when the interrupt never lands", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnStartedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.started"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);
const exitedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "session.exited"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work forever",
attachments: [],
});
yield* Fiber.join(turnStartedFiber);

// The SDK's interrupt() blocks behind an in-flight tool call and never
// answers. Stop must not block on it, and must still stop the turn.
harness.query.interruptNeverResolves = true;
const interruptFiber = yield* adapter.interruptTurn(session.threadId).pipe(Effect.forkChild);

yield* TestClock.adjust("5 seconds");
yield* Fiber.join(interruptFiber);
assert.equal(harness.query.interruptCalls.length, 1);

const exitEvents = Array.from(yield* Fiber.join(exitedFiber));
assert.equal(exitEvents.length, 1);
assert.equal(harness.query.closeCalls, 1);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("interruptTurn leaves the session open when the turn actually ends", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnCompletedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.completed"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work",
attachments: [],
});
yield* adapter.interruptTurn(session.threadId);

harness.query.emit({
type: "result",
subtype: "success",
is_error: false,
errors: [],
session_id: "sdk-session",
uuid: "result-interrupted",
} as unknown as SDKMessage);
yield* Fiber.join(turnCompletedFiber);

// The turn ended, so the watchdog must leave the session alone.
yield* TestClock.adjust("30 seconds");
assert.equal(harness.query.closeCalls, 0);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("workflow member coalescing: identical snapshots suppress, changes emit", () => {
const harness = makeHarness();
return Effect.gen(function* () {
Expand Down
44 changes: 43 additions & 1 deletion apps/server/src/provider/Layers/ClaudeAdapter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,21 @@ const encodeUnknownJsonStringExit = Schema.encodeUnknownExit(Schema.fromJsonStri
const decodeUnknownJsonStringExit = Schema.decodeUnknownExit(Schema.fromJsonString(Schema.Unknown));

const PROVIDER = ProviderDriverKind.make("claudeAgent");

/**
* How long the SDK gets to acknowledge an interrupt control request. Its
* `interrupt()` can block until the in-flight tool call returns, which stalls
* every other thread command behind it on the provider reactor's queue.
*/
const INTERRUPT_ACK_TIMEOUT = "5 seconds";

/**
* How long the interrupted turn gets to wind down before the session is torn
* down. An acknowledged interrupt is not proof the turn stopped, so Stop
* escalates rather than trusting the provider.
*/
const INTERRUPT_HARD_STOP_DELAY = "5 seconds";

type ClaudeTextStreamKind = Extract<RuntimeContentStreamKind, "assistant_text" | "reasoning_text">;
type ClaudeToolResultStreamKind = Extract<
RuntimeContentStreamKind,
Expand DownExpand Up@@ -1689,6 +1704,10 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
}) as ClaudeQueryRuntime);

const sessions = new Map<ThreadId, ClaudeSessionContext>();
// Detached forks that must outlive the request that started them (the Stop
// watchdog): the caller returns as soon as the interrupt is requested.
const adapterContext = yield* Effect.context<never>();
const runAdapterFork = Effect.runForkWith(adapterContext);
const runtimeEventQueue = yield* Queue.unbounded<ProviderRuntimeEvent>();

const nowIso = Effect.map(DateTime.now, DateTime.formatIso);
Expand DownExpand Up@@ -4518,10 +4537,33 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
{ concurrency: 8, discard: true },
).pipe(Effect.timeoutOption("10 seconds"), Effect.ignore);
}
// Stop has to actually stop. interrupt() is only a control request: the
// SDK can take minutes to answer it while a tool call is in flight, and
// an answer still does not prove the turn ended. Arm the teardown first
// so a slow ack cannot delay it, then ask nicely.
const interruptedTurnId = context.turnState?.turnId;
if (interruptedTurnId !== undefined) {
runAdapterFork(
Effect.sleep(INTERRUPT_HARD_STOP_DELAY).pipe(
Effect.flatMap(() =>
context.stopped || context.turnState?.turnId !== interruptedTurnId
? Effect.void
: Effect.logWarning("Claude turn ignored its interrupt; stopping the session.", {
threadId,
turnId: interruptedTurnId,
}).pipe(Effect.andThen(stopSessionInternal(context, { emitExitEvent: true }))),
),
Effect.catchCause((cause) =>
Effect.logError("Failed to force-stop the Claude session.", { threadId, cause }),
),
),
);
}

yield* Effect.tryPromise({
try: () => context.query.interrupt(),
catch: (cause) => toRequestError(threadId, "turn/interrupt", cause),
});
}).pipe(Effect.timeoutOption(INTERRUPT_ACK_TIMEOUT));
},
);

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 100 additions & 0 deletions apps/server/src/provider/Layers/ClaudeAdapter.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -95,8 +95,17 @@ class FakeClaudeQuery implements AsyncIterable<SDKMessage> {
}
}

/**
* Models the real SDK's interrupt, which is a control request that can block
* until the in-flight tool call returns. Set to make it never answer.
*/
public interruptNeverResolves = false;

readonly interrupt = async (): Promise<void> => {
this.interruptCalls.push(undefined);
if (this.interruptNeverResolves) {
await new Promise<never>(() => {});
}
};

readonly stopTask = async (taskId: string): Promise<void> => {
Expand DownExpand Up@@ -1665,6 +1674,97 @@ describe("ClaudeAdapterLive", () => {
);
});

it.effect("interruptTurn stops the session when the interrupt never lands", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnStartedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.started"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);
const exitedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "session.exited"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work forever",
attachments: [],
});
yield* Fiber.join(turnStartedFiber);

// The SDK's interrupt() blocks behind an in-flight tool call and never
// answers. Stop must not block on it, and must still stop the turn.
harness.query.interruptNeverResolves = true;
const interruptFiber = yield* adapter.interruptTurn(session.threadId).pipe(Effect.forkChild);

yield* TestClock.adjust("5 seconds");
yield* Fiber.join(interruptFiber);
assert.equal(harness.query.interruptCalls.length, 1);

const exitEvents = Array.from(yield* Fiber.join(exitedFiber));
assert.equal(exitEvents.length, 1);
assert.equal(harness.query.closeCalls, 1);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("interruptTurn leaves the session open when the turn actually ends", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnCompletedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.completed"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work",
attachments: [],
});
yield* adapter.interruptTurn(session.threadId);

harness.query.emit({
type: "result",
subtype: "success",
is_error: false,
errors: [],
session_id: "sdk-session",
uuid: "result-interrupted",
} as unknown as SDKMessage);
yield* Fiber.join(turnCompletedFiber);

// The turn ended, so the watchdog must leave the session alone.
yield* TestClock.adjust("30 seconds");
assert.equal(harness.query.closeCalls, 0);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("workflow member coalescing: identical snapshots suppress, changes emit", () => {
const harness = makeHarness();
return Effect.gen(function* () {
Expand Down
44 changes: 43 additions & 1 deletion apps/server/src/provider/Layers/ClaudeAdapter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,21 @@ const encodeUnknownJsonStringExit = Schema.encodeUnknownExit(Schema.fromJsonStri
const decodeUnknownJsonStringExit = Schema.decodeUnknownExit(Schema.fromJsonString(Schema.Unknown));

const PROVIDER = ProviderDriverKind.make("claudeAgent");

/**
* How long the SDK gets to acknowledge an interrupt control request. Its
* `interrupt()` can block until the in-flight tool call returns, which stalls
* every other thread command behind it on the provider reactor's queue.
*/
const INTERRUPT_ACK_TIMEOUT = "5 seconds";

/**
* How long the interrupted turn gets to wind down before the session is torn
* down. An acknowledged interrupt is not proof the turn stopped, so Stop
* escalates rather than trusting the provider.
*/
const INTERRUPT_HARD_STOP_DELAY = "5 seconds";

type ClaudeTextStreamKind = Extract<RuntimeContentStreamKind, "assistant_text" | "reasoning_text">;
type ClaudeToolResultStreamKind = Extract<
RuntimeContentStreamKind,
Expand DownExpand Up@@ -1689,6 +1704,10 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
}) as ClaudeQueryRuntime);

const sessions = new Map<ThreadId, ClaudeSessionContext>();
// Detached forks that must outlive the request that started them (the Stop
// watchdog): the caller returns as soon as the interrupt is requested.
const adapterContext = yield* Effect.context<never>();
const runAdapterFork = Effect.runForkWith(adapterContext);
const runtimeEventQueue = yield* Queue.unbounded<ProviderRuntimeEvent>();

const nowIso = Effect.map(DateTime.now, DateTime.formatIso);
Expand DownExpand Up@@ -4518,10 +4537,33 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
{ concurrency: 8, discard: true },
).pipe(Effect.timeoutOption("10 seconds"), Effect.ignore);
}
// Stop has to actually stop. interrupt() is only a control request: the
// SDK can take minutes to answer it while a tool call is in flight, and
// an answer still does not prove the turn ended. Arm the teardown first
// so a slow ack cannot delay it, then ask nicely.
const interruptedTurnId = context.turnState?.turnId;
if (interruptedTurnId !== undefined) {
runAdapterFork(
Effect.sleep(INTERRUPT_HARD_STOP_DELAY).pipe(
Effect.flatMap(() =>
context.stopped || context.turnState?.turnId !== interruptedTurnId
? Effect.void
: Effect.logWarning("Claude turn ignored its interrupt; stopping the session.", {
threadId,
turnId: interruptedTurnId,
}).pipe(Effect.andThen(stopSessionInternal(context, { emitExitEvent: true }))),
),
Effect.catchCause((cause) =>
Effect.logError("Failed to force-stop the Claude session.", { threadId, cause }),
),
),
);
}

yield* Effect.tryPromise({
try: () => context.query.interrupt(),
catch: (cause) => toRequestError(threadId, "turn/interrupt", cause),
});
}).pipe(Effect.timeoutOption(INTERRUPT_ACK_TIMEOUT));
},
);

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 100 additions & 0 deletions apps/server/src/provider/Layers/ClaudeAdapter.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -95,8 +95,17 @@ class FakeClaudeQuery implements AsyncIterable<SDKMessage> {
}
}

/**
* Models the real SDK's interrupt, which is a control request that can block
* until the in-flight tool call returns. Set to make it never answer.
*/
public interruptNeverResolves = false;

readonly interrupt = async (): Promise<void> => {
this.interruptCalls.push(undefined);
if (this.interruptNeverResolves) {
await new Promise<never>(() => {});
}
};

readonly stopTask = async (taskId: string): Promise<void> => {
Expand DownExpand Up@@ -1665,6 +1674,97 @@ describe("ClaudeAdapterLive", () => {
);
});

it.effect("interruptTurn stops the session when the interrupt never lands", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnStartedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.started"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);
const exitedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "session.exited"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work forever",
attachments: [],
});
yield* Fiber.join(turnStartedFiber);

// The SDK's interrupt() blocks behind an in-flight tool call and never
// answers. Stop must not block on it, and must still stop the turn.
harness.query.interruptNeverResolves = true;
const interruptFiber = yield* adapter.interruptTurn(session.threadId).pipe(Effect.forkChild);

yield* TestClock.adjust("5 seconds");
yield* Fiber.join(interruptFiber);
assert.equal(harness.query.interruptCalls.length, 1);

const exitEvents = Array.from(yield* Fiber.join(exitedFiber));
assert.equal(exitEvents.length, 1);
assert.equal(harness.query.closeCalls, 1);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("interruptTurn leaves the session open when the turn actually ends", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnCompletedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.completed"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work",
attachments: [],
});
yield* adapter.interruptTurn(session.threadId);

harness.query.emit({
type: "result",
subtype: "success",
is_error: false,
errors: [],
session_id: "sdk-session",
uuid: "result-interrupted",
} as unknown as SDKMessage);
yield* Fiber.join(turnCompletedFiber);

// The turn ended, so the watchdog must leave the session alone.
yield* TestClock.adjust("30 seconds");
assert.equal(harness.query.closeCalls, 0);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("workflow member coalescing: identical snapshots suppress, changes emit", () => {
const harness = makeHarness();
return Effect.gen(function* () {
Expand Down
44 changes: 43 additions & 1 deletion apps/server/src/provider/Layers/ClaudeAdapter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,21 @@ const encodeUnknownJsonStringExit = Schema.encodeUnknownExit(Schema.fromJsonStri
const decodeUnknownJsonStringExit = Schema.decodeUnknownExit(Schema.fromJsonString(Schema.Unknown));

const PROVIDER = ProviderDriverKind.make("claudeAgent");

/**
* How long the SDK gets to acknowledge an interrupt control request. Its
* `interrupt()` can block until the in-flight tool call returns, which stalls
* every other thread command behind it on the provider reactor's queue.
*/
const INTERRUPT_ACK_TIMEOUT = "5 seconds";

/**
* How long the interrupted turn gets to wind down before the session is torn
* down. An acknowledged interrupt is not proof the turn stopped, so Stop
* escalates rather than trusting the provider.
*/
const INTERRUPT_HARD_STOP_DELAY = "5 seconds";

type ClaudeTextStreamKind = Extract<RuntimeContentStreamKind, "assistant_text" | "reasoning_text">;
type ClaudeToolResultStreamKind = Extract<
RuntimeContentStreamKind,
Expand DownExpand Up@@ -1689,6 +1704,10 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
}) as ClaudeQueryRuntime);

const sessions = new Map<ThreadId, ClaudeSessionContext>();
// Detached forks that must outlive the request that started them (the Stop
// watchdog): the caller returns as soon as the interrupt is requested.
const adapterContext = yield* Effect.context<never>();
const runAdapterFork = Effect.runForkWith(adapterContext);
const runtimeEventQueue = yield* Queue.unbounded<ProviderRuntimeEvent>();

const nowIso = Effect.map(DateTime.now, DateTime.formatIso);
Expand DownExpand Up@@ -4518,10 +4537,33 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
{ concurrency: 8, discard: true },
).pipe(Effect.timeoutOption("10 seconds"), Effect.ignore);
}
// Stop has to actually stop. interrupt() is only a control request: the
// SDK can take minutes to answer it while a tool call is in flight, and
// an answer still does not prove the turn ended. Arm the teardown first
// so a slow ack cannot delay it, then ask nicely.
const interruptedTurnId = context.turnState?.turnId;
if (interruptedTurnId !== undefined) {
runAdapterFork(
Effect.sleep(INTERRUPT_HARD_STOP_DELAY).pipe(
Effect.flatMap(() =>
context.stopped || context.turnState?.turnId !== interruptedTurnId
? Effect.void
: Effect.logWarning("Claude turn ignored its interrupt; stopping the session.", {
threadId,
turnId: interruptedTurnId,
}).pipe(Effect.andThen(stopSessionInternal(context, { emitExitEvent: true }))),
),
Effect.catchCause((cause) =>
Effect.logError("Failed to force-stop the Claude session.", { threadId, cause }),
),
),
);
}

yield* Effect.tryPromise({
try: () => context.query.interrupt(),
catch: (cause) => toRequestError(threadId, "turn/interrupt", cause),
});
}).pipe(Effect.timeoutOption(INTERRUPT_ACK_TIMEOUT));
},
);

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 100 additions & 0 deletions apps/server/src/provider/Layers/ClaudeAdapter.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -95,8 +95,17 @@ class FakeClaudeQuery implements AsyncIterable<SDKMessage> {
}
}

/**
* Models the real SDK's interrupt, which is a control request that can block
* until the in-flight tool call returns. Set to make it never answer.
*/
public interruptNeverResolves = false;

readonly interrupt = async (): Promise<void> => {
this.interruptCalls.push(undefined);
if (this.interruptNeverResolves) {
await new Promise<never>(() => {});
}
};

readonly stopTask = async (taskId: string): Promise<void> => {
Expand DownExpand Up@@ -1665,6 +1674,97 @@ describe("ClaudeAdapterLive", () => {
);
});

it.effect("interruptTurn stops the session when the interrupt never lands", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnStartedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.started"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);
const exitedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "session.exited"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work forever",
attachments: [],
});
yield* Fiber.join(turnStartedFiber);

// The SDK's interrupt() blocks behind an in-flight tool call and never
// answers. Stop must not block on it, and must still stop the turn.
harness.query.interruptNeverResolves = true;
const interruptFiber = yield* adapter.interruptTurn(session.threadId).pipe(Effect.forkChild);

yield* TestClock.adjust("5 seconds");
yield* Fiber.join(interruptFiber);
assert.equal(harness.query.interruptCalls.length, 1);

const exitEvents = Array.from(yield* Fiber.join(exitedFiber));
assert.equal(exitEvents.length, 1);
assert.equal(harness.query.closeCalls, 1);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("interruptTurn leaves the session open when the turn actually ends", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnCompletedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.completed"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work",
attachments: [],
});
yield* adapter.interruptTurn(session.threadId);

harness.query.emit({
type: "result",
subtype: "success",
is_error: false,
errors: [],
session_id: "sdk-session",
uuid: "result-interrupted",
} as unknown as SDKMessage);
yield* Fiber.join(turnCompletedFiber);

// The turn ended, so the watchdog must leave the session alone.
yield* TestClock.adjust("30 seconds");
assert.equal(harness.query.closeCalls, 0);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("workflow member coalescing: identical snapshots suppress, changes emit", () => {
const harness = makeHarness();
return Effect.gen(function* () {
Expand Down
44 changes: 43 additions & 1 deletion apps/server/src/provider/Layers/ClaudeAdapter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,21 @@ const encodeUnknownJsonStringExit = Schema.encodeUnknownExit(Schema.fromJsonStri
const decodeUnknownJsonStringExit = Schema.decodeUnknownExit(Schema.fromJsonString(Schema.Unknown));

const PROVIDER = ProviderDriverKind.make("claudeAgent");

/**
* How long the SDK gets to acknowledge an interrupt control request. Its
* `interrupt()` can block until the in-flight tool call returns, which stalls
* every other thread command behind it on the provider reactor's queue.
*/
const INTERRUPT_ACK_TIMEOUT = "5 seconds";

/**
* How long the interrupted turn gets to wind down before the session is torn
* down. An acknowledged interrupt is not proof the turn stopped, so Stop
* escalates rather than trusting the provider.
*/
const INTERRUPT_HARD_STOP_DELAY = "5 seconds";

type ClaudeTextStreamKind = Extract<RuntimeContentStreamKind, "assistant_text" | "reasoning_text">;
type ClaudeToolResultStreamKind = Extract<
RuntimeContentStreamKind,
Expand DownExpand Up@@ -1689,6 +1704,10 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
}) as ClaudeQueryRuntime);

const sessions = new Map<ThreadId, ClaudeSessionContext>();
// Detached forks that must outlive the request that started them (the Stop
// watchdog): the caller returns as soon as the interrupt is requested.
const adapterContext = yield* Effect.context<never>();
const runAdapterFork = Effect.runForkWith(adapterContext);
const runtimeEventQueue = yield* Queue.unbounded<ProviderRuntimeEvent>();

const nowIso = Effect.map(DateTime.now, DateTime.formatIso);
Expand DownExpand Up@@ -4518,10 +4537,33 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
{ concurrency: 8, discard: true },
).pipe(Effect.timeoutOption("10 seconds"), Effect.ignore);
}
// Stop has to actually stop. interrupt() is only a control request: the
// SDK can take minutes to answer it while a tool call is in flight, and
// an answer still does not prove the turn ended. Arm the teardown first
// so a slow ack cannot delay it, then ask nicely.
const interruptedTurnId = context.turnState?.turnId;
if (interruptedTurnId !== undefined) {
runAdapterFork(
Effect.sleep(INTERRUPT_HARD_STOP_DELAY).pipe(
Effect.flatMap(() =>
context.stopped || context.turnState?.turnId !== interruptedTurnId
? Effect.void
: Effect.logWarning("Claude turn ignored its interrupt; stopping the session.", {
threadId,
turnId: interruptedTurnId,
}).pipe(Effect.andThen(stopSessionInternal(context, { emitExitEvent: true }))),
),
Effect.catchCause((cause) =>
Effect.logError("Failed to force-stop the Claude session.", { threadId, cause }),
),
),
);
}

yield* Effect.tryPromise({
try: () => context.query.interrupt(),
catch: (cause) => toRequestError(threadId, "turn/interrupt", cause),
});
}).pipe(Effect.timeoutOption(INTERRUPT_ACK_TIMEOUT));
},
);

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 100 additions & 0 deletions apps/server/src/provider/Layers/ClaudeAdapter.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -95,8 +95,17 @@ class FakeClaudeQuery implements AsyncIterable<SDKMessage> {
}
}

/**
* Models the real SDK's interrupt, which is a control request that can block
* until the in-flight tool call returns. Set to make it never answer.
*/
public interruptNeverResolves = false;

readonly interrupt = async (): Promise<void> => {
this.interruptCalls.push(undefined);
if (this.interruptNeverResolves) {
await new Promise<never>(() => {});
}
};

readonly stopTask = async (taskId: string): Promise<void> => {
Expand DownExpand Up@@ -1665,6 +1674,97 @@ describe("ClaudeAdapterLive", () => {
);
});

it.effect("interruptTurn stops the session when the interrupt never lands", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnStartedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.started"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);
const exitedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "session.exited"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work forever",
attachments: [],
});
yield* Fiber.join(turnStartedFiber);

// The SDK's interrupt() blocks behind an in-flight tool call and never
// answers. Stop must not block on it, and must still stop the turn.
harness.query.interruptNeverResolves = true;
const interruptFiber = yield* adapter.interruptTurn(session.threadId).pipe(Effect.forkChild);

yield* TestClock.adjust("5 seconds");
yield* Fiber.join(interruptFiber);
assert.equal(harness.query.interruptCalls.length, 1);

const exitEvents = Array.from(yield* Fiber.join(exitedFiber));
assert.equal(exitEvents.length, 1);
assert.equal(harness.query.closeCalls, 1);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("interruptTurn leaves the session open when the turn actually ends", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnCompletedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.completed"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work",
attachments: [],
});
yield* adapter.interruptTurn(session.threadId);

harness.query.emit({
type: "result",
subtype: "success",
is_error: false,
errors: [],
session_id: "sdk-session",
uuid: "result-interrupted",
} as unknown as SDKMessage);
yield* Fiber.join(turnCompletedFiber);

// The turn ended, so the watchdog must leave the session alone.
yield* TestClock.adjust("30 seconds");
assert.equal(harness.query.closeCalls, 0);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("workflow member coalescing: identical snapshots suppress, changes emit", () => {
const harness = makeHarness();
return Effect.gen(function* () {
Expand Down
44 changes: 43 additions & 1 deletion apps/server/src/provider/Layers/ClaudeAdapter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,21 @@ const encodeUnknownJsonStringExit = Schema.encodeUnknownExit(Schema.fromJsonStri
const decodeUnknownJsonStringExit = Schema.decodeUnknownExit(Schema.fromJsonString(Schema.Unknown));

const PROVIDER = ProviderDriverKind.make("claudeAgent");

/**
* How long the SDK gets to acknowledge an interrupt control request. Its
* `interrupt()` can block until the in-flight tool call returns, which stalls
* every other thread command behind it on the provider reactor's queue.
*/
const INTERRUPT_ACK_TIMEOUT = "5 seconds";

/**
* How long the interrupted turn gets to wind down before the session is torn
* down. An acknowledged interrupt is not proof the turn stopped, so Stop
* escalates rather than trusting the provider.
*/
const INTERRUPT_HARD_STOP_DELAY = "5 seconds";

type ClaudeTextStreamKind = Extract<RuntimeContentStreamKind, "assistant_text" | "reasoning_text">;
type ClaudeToolResultStreamKind = Extract<
RuntimeContentStreamKind,
Expand DownExpand Up@@ -1689,6 +1704,10 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
}) as ClaudeQueryRuntime);

const sessions = new Map<ThreadId, ClaudeSessionContext>();
// Detached forks that must outlive the request that started them (the Stop
// watchdog): the caller returns as soon as the interrupt is requested.
const adapterContext = yield* Effect.context<never>();
const runAdapterFork = Effect.runForkWith(adapterContext);
const runtimeEventQueue = yield* Queue.unbounded<ProviderRuntimeEvent>();

const nowIso = Effect.map(DateTime.now, DateTime.formatIso);
Expand DownExpand Up@@ -4518,10 +4537,33 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
{ concurrency: 8, discard: true },
).pipe(Effect.timeoutOption("10 seconds"), Effect.ignore);
}
// Stop has to actually stop. interrupt() is only a control request: the
// SDK can take minutes to answer it while a tool call is in flight, and
// an answer still does not prove the turn ended. Arm the teardown first
// so a slow ack cannot delay it, then ask nicely.
const interruptedTurnId = context.turnState?.turnId;
if (interruptedTurnId !== undefined) {
runAdapterFork(
Effect.sleep(INTERRUPT_HARD_STOP_DELAY).pipe(
Effect.flatMap(() =>
context.stopped || context.turnState?.turnId !== interruptedTurnId
? Effect.void
: Effect.logWarning("Claude turn ignored its interrupt; stopping the session.", {
threadId,
turnId: interruptedTurnId,
}).pipe(Effect.andThen(stopSessionInternal(context, { emitExitEvent: true }))),
),
Effect.catchCause((cause) =>
Effect.logError("Failed to force-stop the Claude session.", { threadId, cause }),
),
),
);
}

yield* Effect.tryPromise({
try: () => context.query.interrupt(),
catch: (cause) => toRequestError(threadId, "turn/interrupt", cause),
});
}).pipe(Effect.timeoutOption(INTERRUPT_ACK_TIMEOUT));
},
);

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 100 additions & 0 deletions apps/server/src/provider/Layers/ClaudeAdapter.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -95,8 +95,17 @@ class FakeClaudeQuery implements AsyncIterable<SDKMessage> {
}
}

/**
* Models the real SDK's interrupt, which is a control request that can block
* until the in-flight tool call returns. Set to make it never answer.
*/
public interruptNeverResolves = false;

readonly interrupt = async (): Promise<void> => {
this.interruptCalls.push(undefined);
if (this.interruptNeverResolves) {
await new Promise<never>(() => {});
}
};

readonly stopTask = async (taskId: string): Promise<void> => {
Expand DownExpand Up@@ -1665,6 +1674,97 @@ describe("ClaudeAdapterLive", () => {
);
});

it.effect("interruptTurn stops the session when the interrupt never lands", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnStartedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.started"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);
const exitedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "session.exited"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work forever",
attachments: [],
});
yield* Fiber.join(turnStartedFiber);

// The SDK's interrupt() blocks behind an in-flight tool call and never
// answers. Stop must not block on it, and must still stop the turn.
harness.query.interruptNeverResolves = true;
const interruptFiber = yield* adapter.interruptTurn(session.threadId).pipe(Effect.forkChild);

yield* TestClock.adjust("5 seconds");
yield* Fiber.join(interruptFiber);
assert.equal(harness.query.interruptCalls.length, 1);

const exitEvents = Array.from(yield* Fiber.join(exitedFiber));
assert.equal(exitEvents.length, 1);
assert.equal(harness.query.closeCalls, 1);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("interruptTurn leaves the session open when the turn actually ends", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnCompletedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.completed"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work",
attachments: [],
});
yield* adapter.interruptTurn(session.threadId);

harness.query.emit({
type: "result",
subtype: "success",
is_error: false,
errors: [],
session_id: "sdk-session",
uuid: "result-interrupted",
} as unknown as SDKMessage);
yield* Fiber.join(turnCompletedFiber);

// The turn ended, so the watchdog must leave the session alone.
yield* TestClock.adjust("30 seconds");
assert.equal(harness.query.closeCalls, 0);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("workflow member coalescing: identical snapshots suppress, changes emit", () => {
const harness = makeHarness();
return Effect.gen(function* () {
Expand Down
44 changes: 43 additions & 1 deletion apps/server/src/provider/Layers/ClaudeAdapter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,21 @@ const encodeUnknownJsonStringExit = Schema.encodeUnknownExit(Schema.fromJsonStri
const decodeUnknownJsonStringExit = Schema.decodeUnknownExit(Schema.fromJsonString(Schema.Unknown));

const PROVIDER = ProviderDriverKind.make("claudeAgent");

/**
* How long the SDK gets to acknowledge an interrupt control request. Its
* `interrupt()` can block until the in-flight tool call returns, which stalls
* every other thread command behind it on the provider reactor's queue.
*/
const INTERRUPT_ACK_TIMEOUT = "5 seconds";

/**
* How long the interrupted turn gets to wind down before the session is torn
* down. An acknowledged interrupt is not proof the turn stopped, so Stop
* escalates rather than trusting the provider.
*/
const INTERRUPT_HARD_STOP_DELAY = "5 seconds";

type ClaudeTextStreamKind = Extract<RuntimeContentStreamKind, "assistant_text" | "reasoning_text">;
type ClaudeToolResultStreamKind = Extract<
RuntimeContentStreamKind,
Expand DownExpand Up@@ -1689,6 +1704,10 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
}) as ClaudeQueryRuntime);

const sessions = new Map<ThreadId, ClaudeSessionContext>();
// Detached forks that must outlive the request that started them (the Stop
// watchdog): the caller returns as soon as the interrupt is requested.
const adapterContext = yield* Effect.context<never>();
const runAdapterFork = Effect.runForkWith(adapterContext);
const runtimeEventQueue = yield* Queue.unbounded<ProviderRuntimeEvent>();

const nowIso = Effect.map(DateTime.now, DateTime.formatIso);
Expand DownExpand Up@@ -4518,10 +4537,33 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
{ concurrency: 8, discard: true },
).pipe(Effect.timeoutOption("10 seconds"), Effect.ignore);
}
// Stop has to actually stop. interrupt() is only a control request: the
// SDK can take minutes to answer it while a tool call is in flight, and
// an answer still does not prove the turn ended. Arm the teardown first
// so a slow ack cannot delay it, then ask nicely.
const interruptedTurnId = context.turnState?.turnId;
if (interruptedTurnId !== undefined) {
runAdapterFork(
Effect.sleep(INTERRUPT_HARD_STOP_DELAY).pipe(
Effect.flatMap(() =>
context.stopped || context.turnState?.turnId !== interruptedTurnId
? Effect.void
: Effect.logWarning("Claude turn ignored its interrupt; stopping the session.", {
threadId,
turnId: interruptedTurnId,
}).pipe(Effect.andThen(stopSessionInternal(context, { emitExitEvent: true }))),
),
Effect.catchCause((cause) =>
Effect.logError("Failed to force-stop the Claude session.", { threadId, cause }),
),
),
);
}

yield* Effect.tryPromise({
try: () => context.query.interrupt(),
catch: (cause) => toRequestError(threadId, "turn/interrupt", cause),
});
}).pipe(Effect.timeoutOption(INTERRUPT_ACK_TIMEOUT));
},
);

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 100 additions & 0 deletions apps/server/src/provider/Layers/ClaudeAdapter.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -95,8 +95,17 @@ class FakeClaudeQuery implements AsyncIterable<SDKMessage> {
}
}

/**
* Models the real SDK's interrupt, which is a control request that can block
* until the in-flight tool call returns. Set to make it never answer.
*/
public interruptNeverResolves = false;

readonly interrupt = async (): Promise<void> => {
this.interruptCalls.push(undefined);
if (this.interruptNeverResolves) {
await new Promise<never>(() => {});
}
};

readonly stopTask = async (taskId: string): Promise<void> => {
Expand DownExpand Up@@ -1665,6 +1674,97 @@ describe("ClaudeAdapterLive", () => {
);
});

it.effect("interruptTurn stops the session when the interrupt never lands", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnStartedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.started"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);
const exitedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "session.exited"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work forever",
attachments: [],
});
yield* Fiber.join(turnStartedFiber);

// The SDK's interrupt() blocks behind an in-flight tool call and never
// answers. Stop must not block on it, and must still stop the turn.
harness.query.interruptNeverResolves = true;
const interruptFiber = yield* adapter.interruptTurn(session.threadId).pipe(Effect.forkChild);

yield* TestClock.adjust("5 seconds");
yield* Fiber.join(interruptFiber);
assert.equal(harness.query.interruptCalls.length, 1);

const exitEvents = Array.from(yield* Fiber.join(exitedFiber));
assert.equal(exitEvents.length, 1);
assert.equal(harness.query.closeCalls, 1);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("interruptTurn leaves the session open when the turn actually ends", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnCompletedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.completed"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work",
attachments: [],
});
yield* adapter.interruptTurn(session.threadId);

harness.query.emit({
type: "result",
subtype: "success",
is_error: false,
errors: [],
session_id: "sdk-session",
uuid: "result-interrupted",
} as unknown as SDKMessage);
yield* Fiber.join(turnCompletedFiber);

// The turn ended, so the watchdog must leave the session alone.
yield* TestClock.adjust("30 seconds");
assert.equal(harness.query.closeCalls, 0);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("workflow member coalescing: identical snapshots suppress, changes emit", () => {
const harness = makeHarness();
return Effect.gen(function* () {
Expand Down
44 changes: 43 additions & 1 deletion apps/server/src/provider/Layers/ClaudeAdapter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,21 @@ const encodeUnknownJsonStringExit = Schema.encodeUnknownExit(Schema.fromJsonStri
const decodeUnknownJsonStringExit = Schema.decodeUnknownExit(Schema.fromJsonString(Schema.Unknown));

const PROVIDER = ProviderDriverKind.make("claudeAgent");

/**
* How long the SDK gets to acknowledge an interrupt control request. Its
* `interrupt()` can block until the in-flight tool call returns, which stalls
* every other thread command behind it on the provider reactor's queue.
*/
const INTERRUPT_ACK_TIMEOUT = "5 seconds";

/**
* How long the interrupted turn gets to wind down before the session is torn
* down. An acknowledged interrupt is not proof the turn stopped, so Stop
* escalates rather than trusting the provider.
*/
const INTERRUPT_HARD_STOP_DELAY = "5 seconds";

type ClaudeTextStreamKind = Extract<RuntimeContentStreamKind, "assistant_text" | "reasoning_text">;
type ClaudeToolResultStreamKind = Extract<
RuntimeContentStreamKind,
Expand DownExpand Up@@ -1689,6 +1704,10 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
}) as ClaudeQueryRuntime);

const sessions = new Map<ThreadId, ClaudeSessionContext>();
// Detached forks that must outlive the request that started them (the Stop
// watchdog): the caller returns as soon as the interrupt is requested.
const adapterContext = yield* Effect.context<never>();
const runAdapterFork = Effect.runForkWith(adapterContext);
const runtimeEventQueue = yield* Queue.unbounded<ProviderRuntimeEvent>();

const nowIso = Effect.map(DateTime.now, DateTime.formatIso);
Expand DownExpand Up@@ -4518,10 +4537,33 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
{ concurrency: 8, discard: true },
).pipe(Effect.timeoutOption("10 seconds"), Effect.ignore);
}
// Stop has to actually stop. interrupt() is only a control request: the
// SDK can take minutes to answer it while a tool call is in flight, and
// an answer still does not prove the turn ended. Arm the teardown first
// so a slow ack cannot delay it, then ask nicely.
const interruptedTurnId = context.turnState?.turnId;
if (interruptedTurnId !== undefined) {
runAdapterFork(
Effect.sleep(INTERRUPT_HARD_STOP_DELAY).pipe(
Effect.flatMap(() =>
context.stopped || context.turnState?.turnId !== interruptedTurnId
? Effect.void
: Effect.logWarning("Claude turn ignored its interrupt; stopping the session.", {
threadId,
turnId: interruptedTurnId,
}).pipe(Effect.andThen(stopSessionInternal(context, { emitExitEvent: true }))),
),
Effect.catchCause((cause) =>
Effect.logError("Failed to force-stop the Claude session.", { threadId, cause }),
),
),
);
}

yield* Effect.tryPromise({
try: () => context.query.interrupt(),
catch: (cause) => toRequestError(threadId, "turn/interrupt", cause),
});
}).pipe(Effect.timeoutOption(INTERRUPT_ACK_TIMEOUT));
},
);

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 100 additions & 0 deletions apps/server/src/provider/Layers/ClaudeAdapter.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -95,8 +95,17 @@ class FakeClaudeQuery implements AsyncIterable<SDKMessage> {
}
}

/**
* Models the real SDK's interrupt, which is a control request that can block
* until the in-flight tool call returns. Set to make it never answer.
*/
public interruptNeverResolves = false;

readonly interrupt = async (): Promise<void> => {
this.interruptCalls.push(undefined);
if (this.interruptNeverResolves) {
await new Promise<never>(() => {});
}
};

readonly stopTask = async (taskId: string): Promise<void> => {
Expand DownExpand Up@@ -1665,6 +1674,97 @@ describe("ClaudeAdapterLive", () => {
);
});

it.effect("interruptTurn stops the session when the interrupt never lands", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnStartedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.started"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);
const exitedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "session.exited"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work forever",
attachments: [],
});
yield* Fiber.join(turnStartedFiber);

// The SDK's interrupt() blocks behind an in-flight tool call and never
// answers. Stop must not block on it, and must still stop the turn.
harness.query.interruptNeverResolves = true;
const interruptFiber = yield* adapter.interruptTurn(session.threadId).pipe(Effect.forkChild);

yield* TestClock.adjust("5 seconds");
yield* Fiber.join(interruptFiber);
assert.equal(harness.query.interruptCalls.length, 1);

const exitEvents = Array.from(yield* Fiber.join(exitedFiber));
assert.equal(exitEvents.length, 1);
assert.equal(harness.query.closeCalls, 1);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("interruptTurn leaves the session open when the turn actually ends", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const turnCompletedFiber = yield* adapter.streamEvents.pipe(
Stream.filter((event) => event.type === "turn.completed"),
Stream.take(1),
Stream.runCollect,
Effect.forkChild,
);

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "work",
attachments: [],
});
yield* adapter.interruptTurn(session.threadId);

harness.query.emit({
type: "result",
subtype: "success",
is_error: false,
errors: [],
session_id: "sdk-session",
uuid: "result-interrupted",
} as unknown as SDKMessage);
yield* Fiber.join(turnCompletedFiber);

// The turn ended, so the watchdog must leave the session alone.
yield* TestClock.adjust("30 seconds");
assert.equal(harness.query.closeCalls, 0);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("workflow member coalescing: identical snapshots suppress, changes emit", () => {
const harness = makeHarness();
return Effect.gen(function* () {
Expand Down
44 changes: 43 additions & 1 deletion apps/server/src/provider/Layers/ClaudeAdapter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,21 @@ const encodeUnknownJsonStringExit = Schema.encodeUnknownExit(Schema.fromJsonStri
const decodeUnknownJsonStringExit = Schema.decodeUnknownExit(Schema.fromJsonString(Schema.Unknown));

const PROVIDER = ProviderDriverKind.make("claudeAgent");

/**
* How long the SDK gets to acknowledge an interrupt control request. Its
* `interrupt()` can block until the in-flight tool call returns, which stalls
* every other thread command behind it on the provider reactor's queue.
*/
const INTERRUPT_ACK_TIMEOUT = "5 seconds";

/**
* How long the interrupted turn gets to wind down before the session is torn
* down. An acknowledged interrupt is not proof the turn stopped, so Stop
* escalates rather than trusting the provider.
*/
const INTERRUPT_HARD_STOP_DELAY = "5 seconds";

type ClaudeTextStreamKind = Extract<RuntimeContentStreamKind, "assistant_text" | "reasoning_text">;
type ClaudeToolResultStreamKind = Extract<
RuntimeContentStreamKind,
Expand DownExpand Up@@ -1689,6 +1704,10 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
}) as ClaudeQueryRuntime);

const sessions = new Map<ThreadId, ClaudeSessionContext>();
// Detached forks that must outlive the request that started them (the Stop
// watchdog): the caller returns as soon as the interrupt is requested.
const adapterContext = yield* Effect.context<never>();
const runAdapterFork = Effect.runForkWith(adapterContext);
const runtimeEventQueue = yield* Queue.unbounded<ProviderRuntimeEvent>();

const nowIso = Effect.map(DateTime.now, DateTime.formatIso);
Expand DownExpand Up@@ -4518,10 +4537,33 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
{ concurrency: 8, discard: true },
).pipe(Effect.timeoutOption("10 seconds"), Effect.ignore);
}
// Stop has to actually stop. interrupt() is only a control request: the
// SDK can take minutes to answer it while a tool call is in flight, and
// an answer still does not prove the turn ended. Arm the teardown first
// so a slow ack cannot delay it, then ask nicely.
const interruptedTurnId = context.turnState?.turnId;
if (interruptedTurnId !== undefined) {
runAdapterFork(
Effect.sleep(INTERRUPT_HARD_STOP_DELAY).pipe(
Effect.flatMap(() =>
context.stopped || context.turnState?.turnId !== interruptedTurnId
? Effect.void
: Effect.logWarning("Claude turn ignored its interrupt; stopping the session.", {
threadId,
turnId: interruptedTurnId,
}).pipe(Effect.andThen(stopSessionInternal(context, { emitExitEvent: true }))),
),
Effect.catchCause((cause) =>
Effect.logError("Failed to force-stop the Claude session.", { threadId, cause }),
),
),
);
}

yield* Effect.tryPromise({
try: () => context.query.interrupt(),
catch: (cause) => toRequestError(threadId, "turn/interrupt", cause),
});
}).pipe(Effect.timeoutOption(INTERRUPT_ACK_TIMEOUT));
},
);

Expand Down
Loading