Skip to content

Update WRP Spec for deviceID - #53

Draft
joe94 wants to merge 3 commits into
mainfrom
feature/deviceID
Draft

Update WRP Spec for deviceID#53
joe94 wants to merge 3 commits into
mainfrom
feature/deviceID

Conversation

@joe94

@joe94joe94 commented Aug 14, 2020

Copy link
Copy Markdown
Member

No description provided.

@joe94
joe94 marked this pull request as draft August 14, 2020 02:20
@joe94joe94 self-assigned this Aug 14, 2020
@joe94joe94 linked an issue Aug 14, 2020 that may be closed by this pull request
Update WRP simple messages spec #51
Open
@joe94joe94 changed the title Feature/deviceUpdate WRP Spec for deviceIDAug 14, 2020
@sonarqubecloud

sonarqubecloudBot commented Aug 14, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

BugA0 Bugs
VulnerabilityA0 Vulnerabilities (and Security Hotspot0 Security Hotspots to review)
Code SmellA0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

joe94
joe94 commented Aug 14, 2020
View reviewed changes
Comment threadcontent/docs/wrp/simple-messages.md Outdated
source | The device_id name of the device originating the request or response.
dest | The device_id name of the target device of the request or response.
content_type | (optional) The media type of the payload.
source | The device_id name of the device originating the request or response (i.e. dns:tr1d1um.example.net for inbound messages).

@joe94joe94Aug 14, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if parodus is or plans to use the source field (dns:tr1d1um.example.net) on inbound messages.

@kristinapathakkristinapathakAug 14, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought parodus uses the source at the very least to fill in the destination for the response wrp it sends. I could be wrong.

joe94
joe94 commented Aug 14, 2020
View reviewed changes
Comment threadcontent/docs/wrp/simple-messages.md
@joe94joe94 added the enhancement New feature or request label Aug 14, 2020
kristinapathak
kristinapathak suggested changes Aug 14, 2020
View reviewed changes
Comment threadcontent/docs/wrp/simple-messages.md Outdated
Comment threadcontent/docs/wrp/simple-messages.md Outdated
Comment threadcontent/docs/wrp/simple-messages.md Outdated
Comment threadcontent/docs/wrp/simple-messages.md
source | The device_id name of the device originating the request or response (i.e. dns:tr1d1um.example.net for inbound messages).
dest | The device_id name of the target device of the request or response (i.e. mac:112233445566/config for inbound messages).
device_id | The canonical device ID (i.e. mac:112233445566) involved in this envelope. It defers from source or dest in that no further parsing is required to extract the ID from the value.
content_type | (optional) The media type of the payload. If not specified on inbound messages, `application/octet-stream` is used as default.

@kristinapathakkristinapathakAug 14, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were only adding this for events? Is this also being added to request-responses?

@kristinapathakkristinapathakAug 14, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, found the pull request (xmidt-org/webpa-common#508). But isn't it filled in for outbound messages, not inbound?

Comment threadcontent/docs/wrp/simple-messages.md Outdated
Comment threadcontent/docs/wrp/simple-messages.md Outdated
Comment threadcontent/docs/wrp/simple-messages.md Outdated
@schmidtw@kristinapathak
Apply suggestions from code review
7700f5b
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
@sonarqubecloud

sonarqubecloudBot commented Mar 22, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed! Quality Gate passed

BugA0 Bugs
VulnerabilityA0 Vulnerabilities
Security HotspotA0 Security Hotspots
Code SmellA0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@CLAassistant

CLAassistant commented Oct 6, 2025

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ schmidtw
❌ Joel Unzain

Joel Unzain seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schmidtwschmidtwAwaiting requested review from schmidtw
1 more reviewer
@kristinapathakkristinapathakkristinapathak requested changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@joe94joe94

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update WRP simple messages spec

4 participants

@joe94@CLAassistant@kristinapathak@schmidtw