Create Windows Installer and Portable - #2
Conversation
Compile Windows Portable and Installer
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Pull request overview
This PR cleans up developer-environment artifacts (workspace/solution files) and attempts to switch the app’s default brand theme to Obsidian.
Changes:
- Remove machine-specific VS Code workspace file and ignore future
*.code-workspacefiles. - Remove the standalone
2-Nine.Application/Nine.Application.slnsolution file. - Update
NavMenu.razorto prefer Obsidian as the brand-theme fallback/default.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Nine.code-workspace | Removed multi-root workspace containing workstation-specific paths/settings. |
| 4-Nine/Shared/Layout/NavMenu.razor | Updates brand theme ordering and fallback defaults toward obsidian. |
| 2-Nine.Application/Nine.Application.sln | Removes a layer-specific solution file (repo still has root Nine.sln). |
| .gitignore | Ignores *.code-workspace to avoid committing local workspace files. |
You can also share your feedback on Copilot code review. Take the survey.
| var domTheme = await JSRuntime.InvokeAsync<string>("eval", | ||
| "document.documentElement.getAttribute('data-bs-theme') || localStorage.getItem('theme') || 'light'"); | ||
| var domBrandTheme = await JSRuntime.InvokeAsync<string>("eval", | ||
| "document.documentElement.getAttribute('data-brand-theme') || localStorage.getItem('brandTheme') || 'bootstrap'"); | ||
| "document.documentElement.getAttribute('data-brand-theme') || localStorage.getItem('brandTheme') || 'obsidian'"); | ||
There was a problem hiding this comment.
The PR description says the default brand theme should be Obsidian, but this change only updates NavMenu’s fallback. theme.js still initializes data-brand-theme from localStorage with a default of bootstrap, and ThemeService also defaults _currentBrandTheme to bootstrap, so first-time users will still land on Bootstrap. To actually change the default, update the default in 3-Nine.Shared.UI/wwwroot/js/theme.js (and any other initialization paths) and consider aligning ThemeService’s initial _currentBrandTheme with the new default as well.
Merging updates from Windows installer and portable. Cleaned up workspace settings that are incompatible across workstations. Set default theme to Obsidian.