skip pyreadline dependency on Windows with Python 3.9+ - #45
Merged
Conversation
This was referenced Sep 2, 2020
Merged
dirk-thomas
commented
Sep 2, 2020
ContributorAuthor
CI seems to be failing for unrelated reasons already on the target branch. I created #46 to address these linter warnings. Once that got merged I can rebase this patch to hopefully also pass CI. |
dirk-thomas
commented
Sep 3, 2020
ContributorAuthor
@xolox FYI |
dirk-thomas
commented
Sep 10, 2020
ContributorAuthor
@xolox Friendly ping. |
jacobperron added a commit
to ros2/ci
that referenced
this pull request
Oct 2, 2020
This is to fix our Windows builds until xolox/python-humanfriendly#45 is resolved. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
domdfcoding
commented
Feb 24, 2021
The deprecated aliases have now been removed from Python as of 3.10 alpha 5 (see python/cpython#23754), so this is now a hard error. |
KyleKing
commented
Apr 27, 2021
You could also consider adding a dependency on (I'm currently seeing this warning because |
domdfcoding
commented
Jul 4, 2021
@xolox Friendly ping |
xolox
commented
Sep 17, 2021
Owner
I'm going to merge the changes provided by @dirk-thomas in this pull request but will incorporate the suggestion @KyleKing made in #45 (comment) because it sounds like this should result in the best of both worlds. |
xolox added a commit
that referenced
this pull request
Sep 17, 2021
xolox
commented
Sep 17, 2021
Owner
Hi all, Thanks for the feedback and sorry it took me so long to resolve this. I think this issue should now be resolved with the release of humanfriendly 10.0, because I merged the changes suggested by this pull request and then also incorporated the However I don't have access to a Windows environment for testing, so if anyone can confirm that would be great 😅. |
kraj pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Sep 27, 2021
`Release 10.0`_ (2021-09-17) ---------------------------- **Noteworthy changes:** - Merged pull request `openembedded#45`_ to resolve the issue caused by the conditional :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+. - Updated the readme to use Python 3 in the example (reported in issue `openembedded#56`_). Also added a mention of the ``humanfriendly --demo`` command. - Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is using at this point; it had been rendered useless quite a long time ago (requested in issue `openembedded#53`_). **Internal changes:** - Merged pull request `openembedded#54`_ which migrates the :pypi:`humanfriendly` project from Travis CI to GitHub Actions and from Coveralls.io to Codecov. - Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx documentation errors. .. _Release 10.0: xolox/python-humanfriendly@9.2...10.0 .. _#45: xolox/python-humanfriendly#45 .. _#53: xolox/python-humanfriendly#53 .. _#54: xolox/python-humanfriendly#54 .. _#56: xolox/python-humanfriendly#56 Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Sep 27, 2021
`Release 10.0`_ (2021-09-17) ---------------------------- **Noteworthy changes:** - Merged pull request `openembedded#45`_ to resolve the issue caused by the conditional :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+. - Updated the readme to use Python 3 in the example (reported in issue `openembedded#56`_). Also added a mention of the ``humanfriendly --demo`` command. - Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is using at this point; it had been rendered useless quite a long time ago (requested in issue `openembedded#53`_). **Internal changes:** - Merged pull request `openembedded#54`_ which migrates the :pypi:`humanfriendly` project from Travis CI to GitHub Actions and from Coveralls.io to Codecov. - Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx documentation errors. .. _Release 10.0: xolox/python-humanfriendly@9.2...10.0 .. _#45: xolox/python-humanfriendly#45 .. _#53: xolox/python-humanfriendly#53 .. _#54: xolox/python-humanfriendly#54 .. _#56: xolox/python-humanfriendly#56 Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Sep 27, 2021
`Release 10.0`_ (2021-09-17) ---------------------------- **Noteworthy changes:** - Merged pull request `openembedded#45`_ to resolve the issue caused by the conditional :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+. - Updated the readme to use Python 3 in the example (reported in issue `openembedded#56`_). Also added a mention of the ``humanfriendly --demo`` command. - Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is using at this point; it had been rendered useless quite a long time ago (requested in issue `openembedded#53`_). **Internal changes:** - Merged pull request `openembedded#54`_ which migrates the :pypi:`humanfriendly` project from Travis CI to GitHub Actions and from Coveralls.io to Codecov. - Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx documentation errors. .. _Release 10.0: xolox/python-humanfriendly@9.2...10.0 .. _#45: xolox/python-humanfriendly#45 .. _#53: xolox/python-humanfriendly#53 .. _#54: xolox/python-humanfriendly#54 .. _#56: xolox/python-humanfriendly#56 Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Sep 28, 2021
`Release 10.0`_ (2021-09-17) ---------------------------- **Noteworthy changes:** - Merged pull request `openembedded#45`_ to resolve the issue caused by the conditional :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+. - Updated the readme to use Python 3 in the example (reported in issue `openembedded#56`_). Also added a mention of the ``humanfriendly --demo`` command. - Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is using at this point; it had been rendered useless quite a long time ago (requested in issue `openembedded#53`_). **Internal changes:** - Merged pull request `openembedded#54`_ which migrates the :pypi:`humanfriendly` project from Travis CI to GitHub Actions and from Coveralls.io to Codecov. - Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx documentation errors. .. _Release 10.0: xolox/python-humanfriendly@9.2...10.0 .. _#45: xolox/python-humanfriendly#45 .. _#53: xolox/python-humanfriendly#53 .. _#54: xolox/python-humanfriendly#54 .. _#56: xolox/python-humanfriendly#56 Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Sep 28, 2021
`Release 10.0`_ (2021-09-17) ---------------------------- **Noteworthy changes:** - Merged pull request `openembedded#45`_ to resolve the issue caused by the conditional :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+. - Updated the readme to use Python 3 in the example (reported in issue `openembedded#56`_). Also added a mention of the ``humanfriendly --demo`` command. - Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is using at this point; it had been rendered useless quite a long time ago (requested in issue `openembedded#53`_). **Internal changes:** - Merged pull request `openembedded#54`_ which migrates the :pypi:`humanfriendly` project from Travis CI to GitHub Actions and from Coveralls.io to Codecov. - Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx documentation errors. .. _Release 10.0: xolox/python-humanfriendly@9.2...10.0 .. _#45: xolox/python-humanfriendly#45 .. _#53: xolox/python-humanfriendly#53 .. _#54: xolox/python-humanfriendly#54 .. _#56: xolox/python-humanfriendly#56 Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead pushed a commit
to openembedded/meta-openembedded
that referenced
this pull request
Sep 28, 2021
`Release 10.0`_ (2021-09-17) ---------------------------- **Noteworthy changes:** - Merged pull request `#45`_ to resolve the issue caused by the conditional :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+. - Updated the readme to use Python 3 in the example (reported in issue `#56`_). Also added a mention of the ``humanfriendly --demo`` command. - Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is using at this point; it had been rendered useless quite a long time ago (requested in issue `#53`_). **Internal changes:** - Merged pull request `#54`_ which migrates the :pypi:`humanfriendly` project from Travis CI to GitHub Actions and from Coveralls.io to Codecov. - Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx documentation errors. .. _Release 10.0: xolox/python-humanfriendly@9.2...10.0 .. _#45: xolox/python-humanfriendly#45 .. _#53: xolox/python-humanfriendly#53 .. _#54: xolox/python-humanfriendly#54 .. _#56: xolox/python-humanfriendly#56 Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#44
Since
pyreadlinedoesn't support Python 3.9 and isn't being maintained at the moment this patch makes the dependency conditional based on the Python version. Additionally the import of the module is allowed to fail.