Fix CI - #51
Conversation
hugovk
commented
Dec 31, 2020
And fix PyPy2 by installing cryptography < 3, a dependency of coveralls. Version 2.9 was the last version that passed tests, and 3.2.1 the first one that failed tests. |
The StandardErrorHandler class is responsible for dynamically resolving (looking up the value of) sys.stderr for each logged message instead of once when coloredlogs.install() is called. This was unintentionally broken by changes in 4f8c9aa which were released as part of coloredlogs version 14.1. This was brought to my attention by @hugovk here: xolox/python-humanfriendly#51
xolox
commented
Jun 11, 2021
Hi Hugo, thanks for the feedback & analysis. I merged your changes to get cryptography pinned, then I fixed the upstream bug in coloredlogs (including a new regression test) and I've since bumped the test dependency in humanfriendly. A general note about CI: I'm looking into replacing Travis CI (no longer available for open source projects in any useful capacity, as you undoubtedly know) with e.g. GitHub Actions but have zero experience with the latter, so it may be a while until I have CI infrastructure back up and running... |
hugovk
commented
Jun 11, 2021
I have lots of experience with GitHub Actions, I'll make a PR! |
hugovk
commented
Jun 11, 2021
Please see PR #54. |
Some time between 1 December and 10 December
test_prompt_for_confirmationstarted failing on the CI:The same failure happens if I try the older commit which worked before: 44cbc41.
Checking the changed dependencies between those two and through a process of trial and error, it passes with
coloredlogs==14.0and fails withcoloredlogs==14.1.Here's a diff of those releases: xolox/python-coloredlogs@14.0...14.1
In the meantime, let's pin.