Skip to content

Add emitting support for asymmetric visibility - #183

Merged
thekid merged 24 commits into
masterfrom
feature/asymmetric-visibility
Aug 27, 2024
Merged

Add emitting support for asymmetric visibility#183
thekid merged 24 commits into
masterfrom
feature/asymmetric-visibility

Conversation

@thekid

@thekidthekid commented Aug 24, 2024

Copy link
Copy Markdown
Member

This pull request adds emitting support for asymmetric visibility using (set) specifiers on property modifiers

See https://wiki.php.net/rfc/asymmetric-visibility-v2 and #182

@thekidthekid mentioned this pull request Aug 24, 2024
Comment threadsrc/main/php/lang/ast/emit/AsymmetricVisibility.class.php Outdated
@thekid

Copy link
Copy Markdown
MemberAuthor

Reflection

Here's a first idea:

$prop= $type->property('name');
$prop->modifiers(); // lang.reflection.Modifiers<public | private(set)>$prop->modifiers('get'); // lang.reflection.Modifiers<public>$prop->modifiers('set'); // lang.reflection.Modifiers<private>

Comment threadcomposer.json
@thekid
thekid marked this pull request as ready for review August 25, 2024 09:37
@thekid
thekid merged commit f121e86 into masterAug 27, 2024
@thekid
thekid deleted the feature/asymmetric-visibility branch August 27, 2024 18:29
@thekid

Copy link
Copy Markdown
MemberAuthor

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant

@thekid