Skip to content

Zarrquet implementation: Adding Zarrs-based TableProvider with bindings in Python. - #69

Closed
alxmrs wants to merge 65 commits into
mainfrom
zarr-rs
Closed

Zarrquet implementation: Adding Zarrs-based TableProvider with bindings in Python.#69
alxmrs wants to merge 65 commits into
mainfrom
zarr-rs

Conversation

@alxmrs

@alxmrsalxmrs commented Jul 17, 2025

Copy link
Copy Markdown
Member

Initial implementation of #4. Rust sources were mostly generated by Claude Code.

alxmrs added 22 commits July 14, 2025 22:06
Comment threadsrc/table_provider.rs Outdated
@alxmrsalxmrs changed the title Zarrquet implementation: Adding Zarrs based TableProvider with bindings in Python.Zarrquet implementation: Adding Zarrs-based TableProvider with bindings in Python.Jul 17, 2025

@alxmrsalxmrs left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First part of a self-code review (for the benefit of Claude). Will resume tomorrow.

Comment threadsrc/table_provider.rs Outdated
Comment threadsrc/table_provider.rs Outdated
Comment threadsrc/table_provider.rs Outdated
Comment threadsrc/table_provider.rs Outdated
Comment threadsrc/table_provider.rs Outdated
Comment threadsrc/table_provider.rs Outdated
Comment threadsrc/table_provider.rs Outdated
Comment threadsrc/table_provider.rs Outdated
Comment on lines +763 to +777
DataType::Int64 => {
Arc::new(Int64Array::new_null(0)) as Arc<dyn arrow_array::Array>
}
DataType::Float64 => {
Arc::new(Float64Array::new_null(0)) as Arc<dyn arrow_array::Array>
}
DataType::Int32 => {
Arc::new(Int32Array::new_null(0)) as Arc<dyn arrow_array::Array>
}
DataType::Float32 => {
Arc::new(Float32Array::new_null(0)) as Arc<dyn arrow_array::Array>
}
DataType::Utf8 => Arc::new(arrow_array::StringArray::new_null(0))
as Arc<dyn arrow_array::Array>,
_ => Arc::new(Int64Array::new_null(0)) as Arc<dyn arrow_array::Array>, // Default fallback

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are missing data types here.

Comment threadsrc/table_provider.rs Outdated
Comment threadsrc/table_provider.rs Outdated
@alxmrs

Copy link
Copy Markdown
MemberAuthor

This is better implemented in arrow-zarr or simply #100.

@alxmrsalxmrs closed this Feb 1, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alxmrs@kylebarron@TomNicholas