Uh oh!
There was an error while loading. Please reload this page.
Conversation
…le with `uv build`.
…ll investigate later.
…r, with unit tests.
Uh oh!
There was an error while loading. Please reload this page.
…to corrent column names as well as correct scanning (type handing).
… to make sure they're properly testing the bindings.
alxmrs
left a comment
There was a problem hiding this comment.
First part of a self-code review (for the benefit of Claude). Will resume tomorrow.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| DataType::Int64 => { | ||
| Arc::new(Int64Array::new_null(0)) as Arc<dyn arrow_array::Array> | ||
| } | ||
| DataType::Float64 => { | ||
| Arc::new(Float64Array::new_null(0)) as Arc<dyn arrow_array::Array> | ||
| } | ||
| DataType::Int32 => { | ||
| Arc::new(Int32Array::new_null(0)) as Arc<dyn arrow_array::Array> | ||
| } | ||
| DataType::Float32 => { | ||
| Arc::new(Float32Array::new_null(0)) as Arc<dyn arrow_array::Array> | ||
| } | ||
| DataType::Utf8 => Arc::new(arrow_array::StringArray::new_null(0)) | ||
| as Arc<dyn arrow_array::Array>, | ||
| _ => Arc::new(Int64Array::new_null(0)) as Arc<dyn arrow_array::Array>, // Default fallback |
There was a problem hiding this comment.
I think there are missing data types here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
alxmrs
commented
Feb 1, 2026
This is better implemented in arrow-zarr or simply #100. |
Initial implementation of #4. Rust sources were mostly generated by Claude Code.