Conversation
|
Good catch of the cookie comparison ! |
|
2 years later...is this project ded? |
Merged
|
@xroche: Have you seen this PR? It is linked to: |
Owner
|
The bug is real (unsigned loop in cookie_cmp_wildcard_domain, src/htsbauth.c) and your fix is right. The PR itself can't merge because it carries 8-year-old regenerated build files, so I applied the one-line fix directly in #317, with credit to you. Closing, and sorry for the long delay. |
timothybrush
pushed a commit
to timothybrush/httrack
that referenced
this pull request
Jun 9, 2026
cookie_cmp_wildcard_domain used an unsigned loop counter, so i >= 0 was always true (infinite loop and out-of-bounds reads) and an empty domain underflowed l - 1. Use a signed counter. Found and fixed by greenrd in xroche#172. closes xroche#171
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #171