feature: Support data-src and data-srcset - #220
Merged
Merged
Conversation
Increasingly HTML5 sites use a number of mechanisms for responsive image loading. Many of these mechanisms revolve around the use of `data-src` and `data-srcset` attributes within an img tag to provide a list of valid images to display, along with their relevant sizes (e.g. https://github.com/aFarkas/lazysizes, https://github.com/malchata/yall.js ). This change adds the two previously mentioned tags to the list in `hts_detect[]`, resulting in httrack detecting them correctly. Initially an attempt was made at using `hts_detectbeg[]` with the potential of resolving xroche#203. Unfortunately it became apparent that the implementation of `hts_detectbeg[]` only supports a suffix of integers (see `src/htstools.h#rech_tageqbegdigits` for more information).
|
I realise httrack could very well not receive any further updates, but just wanted to say thank you @brianredbeard for this PR. I just checked out the branch locally, compiled, then ran it on a site where I needed to get images referenced via |
xroche
approved these changes
Dec 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increasingly HTML5 sites use a number of mechanisms for responsive
image loading. Many of these mechanisms revolve around the use of
data-srcanddata-srcsetattributes within an img tag to provide alist of valid images to display, along with their relevant sizes (e.g.
https://github.com/aFarkas/lazysizes, https://github.com/malchata/yall.js).
This change adds the two previously mentioned tags to the list in
hts_detect[], resulting in httrack detecting them correctly.Initially an attempt was made at using
hts_detectbeg[]with thepotential of resolving #203. Unfortunately it became apparent that the
implementation of
hts_detectbeg[]only supports a suffix of integers(see
src/htstools.h#rech_tageqbegdigitsfor more information).