Skip to content

Add fixed_shape::operator== - #2382

Open
tailsu wants to merge 1 commit into
xtensor-stack:masterfrom
tailsu:sd/fixed-shape-op-eq
Open

Add fixed_shape::operator==#2382
tailsu wants to merge 1 commit into
xtensor-stack:masterfrom
tailsu:sd/fixed-shape-op-eq

Conversation

@tailsu

Copy link
Copy Markdown

Checklist

  • The title and commit message(s) are descriptive.
  • Small commits made to fix your PR have been squashed to avoid history pollution.
  • Tests have been added for new features or bug fixes.
  • API of new functions and classes are documented.

Description

Fixes#2376

@tailsu
tailsuforce-pushed the sd/fixed-shape-op-eq branch from 5e68454 to 20f6dacCompareMay 17, 2021 10:34
@tailsu
tailsuforce-pushed the sd/fixed-shape-op-eq branch from 20f6dac to be35a26CompareMay 17, 2021 10:56
@tdegeus

Copy link
Copy Markdown
Member

Thanks!

To deal with the compiler issues I think you would just need to remove

booloperator==(fixed_shape<I...>, fixed_shape<J...>)

Furthermore, I think you still use std::equal internally

@tdegeus

Copy link
Copy Markdown
Member

Actually I think that an implementation is already under way:

#2352

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing operator== for xt::fixed_shape

2 participants

@tailsu@tdegeus