Skip to content

Bump cmake version and resolve build issues - #2744

Merged
tdegeus merged 3 commits into
xtensor-stack:masterfrom
spectre-ns:master
Nov 9, 2023
Merged

tdegeus merged 3 commits into
xtensor-stack:masterfrom
spectre-ns:master

Conversation

@spectre-ns

@spectre-ns spectre-ns commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

Checklist

  • [ x] The title and commit message(s) are descriptive.
  • [x ] Small commits made to fix your PR have been squashed to avoid history pollution.
  • [x ] Tests have been added for new features or bug fixes.
  • [ x] API of new functions and classes are documented.

Description

Fix #2743
Tiny PR to silence warnings. No one should be using CMake 3.1 in this day and age

@spectre-ns spectre-ns changed the title Bump cmake version to minimum backwards compatibility Bump cmake version and resolve build issues Nov 8, 2023
@spectre-ns

spectre-ns commented Nov 8, 2023

Copy link
Copy Markdown
Contributor Author

@tdegeus we were building Windows Clang 16 in debug, and I think there is a bug (or overly pessimistic check) in the iterator checks in MSVC's STL implementation on clang in debug referenced in #2743. Normally this would be a security issue but the same code passes in MSVC on Windows presumably using the same STL, I'm inclined to think this is a library bug.

@tdegeus

tdegeus commented Nov 9, 2023

Copy link
Copy Markdown
Member

Agreed. Thanks a lot!

@tdegeus
tdegeus merged commit 5f49f64 into xtensor-stack:master Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Multiple failures in CI on Clang 16.0.6 MSVC

2 participants