Bump cmake version and resolve build issues - #2744
Merged
Merged
Conversation
Contributor
Author
|
@tdegeus we were building Windows Clang 16 in debug, and I think there is a bug (or overly pessimistic check) in the iterator checks in MSVC's STL implementation on clang in debug referenced in #2743. Normally this would be a security issue but the same code passes in MSVC on Windows presumably using the same STL, I'm inclined to think this is a library bug. |
Member
|
Agreed. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Fix #2743
Tiny PR to silence warnings. No one should be using CMake 3.1 in this day and age