Uh oh!
There was an error while loading. Please reload this page.
(feat): acorn 5.0 - #22
Conversation
Composer package changes
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| ->withMiddleware(function (Middleware $middleware) { | ||
| $middleware->append(AddCspHeaders::class); | ||
| }) | ||
| ->withRouting(wordpress: true) |
There was a problem hiding this comment.
Heb wat getest hiermee, wordpress: true zorgt er iig voor dat de CSP headers niet meer via brave-hooks dmv de send_headers hook moeten worden toegevoegd.
9d90bd4 to
4d2fe35Comparedtakken
commented
Oct 3, 2025
Bij deze even opletten dat deze commit er ook in verwerkt wordt: 5113678 |
There was a problem hiding this comment.
Pull request overview
Updates this package to support Roots Acorn v5 and PHP 8.2, replacing the prior Acorn v4 bootloader customization approach with the new configuration/builder style used by Acorn 5.
Changes:
- Upgrade platform/runtime requirements to PHP 8.2 and bump Acorn + dev tooling dependencies.
- Rework
bootloader()to useApplication::configure()with exception + middleware configuration hooks. - Remove now-redundant custom Kernel/Handler/Vite wrapper classes and adjust view composer attachment logic.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/helpers.php | Switch bootstrapping to Acorn 5 Application::configure() and configure bindings/exceptions/middleware. |
src/View/ViewServiceProvider.php | Simplify composer config check when attaching view composers. |
src/Http/Kernel.php | Remove custom HTTP kernel (CSP now configured via middleware hook). |
src/Exceptions/Handler.php | Remove custom exception handler (Sentry now configured via exceptions hook). |
src/Assets/Vite.php | Remove custom Vite wrapper class. |
composer.json | Bump PHP + Acorn requirements and update dev tooling versions. |
README.md | Update documented PHP requirement and bootloader usage example. |
.github/workflows/phpstan.yml | YAML formatting/quoting update for PR path filters. |
.github/workflows/format-php.yml | YAML formatting/quoting update for PR path filters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| /** @var array<Composer> */ | ||
| $composers = $this->app->get('config')->get('view.composers', []); | ||
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
72a8032 to
3290497CompareCo-authored-by: Dik Takken <dik.takken@yard.nl>
Voorbeeld van implementatie:
https://github.com/yardinternet/UMCNL/pull/68