(feat): acorn 5.0 - #22

Closed
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5
Closed

(feat): acorn 5.0#22
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5

Conversation

@rivanuff

@rivanuffrivanuff commented Aug 20, 2025

Copy link
Copy Markdown

@rivanuff
rivanuff requested review from a team, Rovasch, SimonvanWijhe, YvetteNikolov, dtakken, hnccox-yard, ictbeheer, mvdhoek1 and robertbossaert and removed request for a teamAugust 20, 2025 13:18
@github-actions

github-actionsBot commented Aug 20, 2025

Copy link
Copy Markdown
Composer package changes
Prod PackagesOperationBaseTargetLinkLicense
brick/mathUpgraded0.12.30.14.8CompareMIT
carbonphp/carbon-doctrine-typesUpgraded2.1.03.2.0CompareMIT
dragonmantank/cron-expressionUpgradedv3.5.0v3.6.0CompareMIT
guzzlehttp/guzzleUpgraded7.9.37.10.0CompareMIT
guzzlehttp/promisesUpgraded2.2.02.3.0CompareMIT
laravel/frameworkUpgraded10.50.2v12.56.0CompareMIT
laravel/promptsUpgradedv0.1.25v0.3.16CompareMIT
laravel/serializable-closureUpgradedv1.3.7v2.0.10CompareMIT
league/uriNew-7.8.1CompareMIT
league/uri-interfacesNew-7.8.1CompareMIT
nesbot/carbonUpgraded2.73.03.11.3CompareMIT
nette/utilsUpgradedv4.0.10v4.1.3CompareBSD-3-Clause, GPL-2.0-only, GPL-3.0-only
nunomaduro/termwindUpgradedv1.17.0v2.4.0CompareMIT
roots/acornUpgradedv4.3.1v5.1.1CompareMIT
sentry/sentryUpgraded4.23.14.24.0CompareMIT
spatie/laravel-package-toolsUpgraded1.92.41.93.0CompareMIT
symfony/clockNew-v7.4.8CompareMIT
symfony/consoleUpgradedv6.4.35v7.4.8CompareMIT
symfony/css-selectorUpgradedv6.4.34v7.4.8CompareMIT
symfony/error-handlerUpgradedv6.4.32v7.4.8CompareMIT
symfony/event-dispatcherUpgradedv6.4.32v7.4.8CompareMIT
symfony/finderUpgradedv6.4.34v7.4.8CompareMIT
symfony/http-foundationUpgradedv6.4.35v7.4.8CompareMIT
symfony/http-kernelUpgradedv6.4.35v7.4.8CompareMIT
symfony/mailerUpgradedv6.4.34v7.4.8CompareMIT
symfony/mimeUpgradedv6.4.35v7.4.8CompareMIT
symfony/options-resolverUpgradedv6.4.30v7.4.8CompareMIT
symfony/polyfill-php84New-v1.33.0CompareMIT
symfony/polyfill-php85New-v1.33.0CompareMIT
symfony/processUpgradedv6.4.33v7.4.8CompareMIT
symfony/psr-http-message-bridgeUpgradedv6.4.32v7.4.8CompareMIT
symfony/routingUpgradedv6.4.34v7.4.8CompareMIT
symfony/stringUpgradedv6.4.34v7.4.8CompareMIT
symfony/translationUpgradedv6.4.34v7.4.8CompareMIT
symfony/uidUpgradedv6.4.32v7.4.8CompareMIT
symfony/var-dumperUpgradedv6.4.32v7.4.8CompareMIT
phpChanged>=8.1>=8.2
Dev PackagesOperationBaseTargetLinkLicense
filp/whoopsUpgraded2.18.32.18.4CompareMIT
friendsofphp/php-cs-fixerUpgradedv3.89.0v3.94.2CompareMIT
iamcal/sql-parserUpgradedv0.5v0.7CompareMIT
larastan/larastanUpgradedv2.11.2v3.9.3CompareMIT
laravel/pailNew-v1.2.6CompareMIT
laravel/tinkerUpgradedv2.10.1v2.11.1CompareMIT
nunomaduro/collisionUpgradedv7.12.0v8.9.2CompareMIT
orchestra/canvasUpgradedv8.12.0v10.2.0CompareMIT
orchestra/canvas-coreUpgradedv8.10.2v10.2.0CompareMIT
orchestra/sidekickUpgradedv1.2.12v1.2.20CompareMIT
orchestra/testbenchUpgradedv8.36.0v10.11.0CompareMIT
orchestra/testbench-coreUpgradedv8.38.0v10.12.1CompareMIT
orchestra/workbenchUpgradedv8.17.5v10.1.0CompareMIT
php-stubs/wordpress-stubsUpgradedv6.8.1v6.9.1CompareMIT
phpstan/phpstanUpgraded1.12.272.1.46MIT
phpunit/php-code-coverageUpgraded10.1.1611.0.12CompareBSD-3-Clause
phpunit/php-file-iteratorUpgraded4.1.05.1.1CompareBSD-3-Clause
phpunit/php-invokerUpgraded4.0.05.0.1CompareBSD-3-Clause
phpunit/php-text-templateUpgraded3.0.14.0.1CompareBSD-3-Clause
phpunit/php-timerUpgraded6.0.07.0.1CompareBSD-3-Clause
phpunit/phpunitUpgraded10.5.6311.5.55CompareBSD-3-Clause
psy/psyshUpgradedv0.12.19v0.12.22CompareMIT
react/child-processUpgradedv0.6.6v0.6.7CompareMIT
react/dnsUpgradedv1.13.0v1.14.0CompareMIT
react/event-loopUpgradedv1.5.0v1.6.0CompareMIT
react/socketUpgradedv1.16.0v1.17.0CompareMIT
sebastian/cli-parserUpgraded2.0.13.0.2CompareBSD-3-Clause
sebastian/code-unitUpgraded2.0.03.0.3CompareBSD-3-Clause
sebastian/code-unit-reverse-lookupUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/comparatorUpgraded5.0.56.3.3CompareBSD-3-Clause
sebastian/complexityUpgraded3.2.04.0.1CompareBSD-3-Clause
sebastian/diffUpgraded5.1.16.0.2CompareBSD-3-Clause
sebastian/environmentUpgraded6.1.07.2.1CompareBSD-3-Clause
sebastian/exporterUpgraded5.1.46.3.2CompareBSD-3-Clause
sebastian/global-stateUpgraded6.0.27.0.2CompareBSD-3-Clause
sebastian/lines-of-codeUpgraded2.0.23.0.1CompareBSD-3-Clause
sebastian/object-enumeratorUpgraded5.0.06.0.1CompareBSD-3-Clause
sebastian/object-reflectorUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/recursion-contextUpgraded5.0.16.0.3CompareBSD-3-Clause
sebastian/typeUpgraded4.0.05.1.3CompareBSD-3-Clause
sebastian/versionUpgraded4.0.15.0.2CompareBSD-3-Clause
staabm/side-effects-detectorNew-1.0.5CompareMIT
symfony/filesystemUpgradedv6.4.24v7.4.8CompareMIT
symfony/stopwatchUpgradedv6.4.24v7.4.8CompareMIT
symfony/yamlUpgradedv6.4.21v7.4.8CompareMIT
szepeviktor/phpstan-wordpressUpgradedv1.3.5v2.0.3CompareMIT
symfony/polyfill-php73Removedv1.33.0-CompareMIT
symfony/polyfill-php84Removedv1.33.0-CompareMIT

@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 @rivanuff (feat): acorn 5.0 + php 8.2Aug 20, 2025
Comment thread.github/workflows/format-php.yml Outdated
Comment thread.github/workflows/phpstan.yml Outdated
@SimonvanWijhe

SimonvanWijhe commented Aug 25, 2025

Copy link
Copy Markdown
Member

#260

Comment threadsrc/helpers.php
->withMiddleware(function (Middleware $middleware) {
$middleware->append(AddCspHeaders::class);
})
->withRouting(wordpress: true)

@rivanuffrivanuffAug 30, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heb wat getest hiermee, wordpress: true zorgt er iig voor dat de CSP headers niet meer via brave-hooks dmv de send_headers hook moeten worden toegevoegd.

@dtakken

Copy link
Copy Markdown
Contributor

Bij deze even opletten dat deze commit er ook in verwerkt wordt: 5113678

CopilotAI review requested due to automatic review settings March 13, 2026 15:26
@rivanuff
rivanuff requested a review from a team as a code ownerMarch 13, 2026 15:26
@rivanuff
rivanuff requested review from ShunLuk and SimonvanWijhe and removed request for hnccox-yard and robertbossaertMarch 13, 2026 15:26

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this package to support Roots Acorn v5 and PHP 8.2, replacing the prior Acorn v4 bootloader customization approach with the new configuration/builder style used by Acorn 5.

Changes:

  • Upgrade platform/runtime requirements to PHP 8.2 and bump Acorn + dev tooling dependencies.
  • Rework bootloader() to use Application::configure() with exception + middleware configuration hooks.
  • Remove now-redundant custom Kernel/Handler/Vite wrapper classes and adjust view composer attachment logic.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
src/helpers.phpSwitch bootstrapping to Acorn 5 Application::configure() and configure bindings/exceptions/middleware.
src/View/ViewServiceProvider.phpSimplify composer config check when attaching view composers.
src/Http/Kernel.phpRemove custom HTTP kernel (CSP now configured via middleware hook).
src/Exceptions/Handler.phpRemove custom exception handler (Sentry now configured via exceptions hook).
src/Assets/Vite.phpRemove custom Vite wrapper class.
composer.jsonBump PHP + Acorn requirements and update dev tooling versions.
README.mdUpdate documented PHP requirement and bootloader usage example.
.github/workflows/phpstan.ymlYAML formatting/quoting update for PR path filters.
.github/workflows/format-php.ymlYAML formatting/quoting update for PR path filters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 15 to 17
/** @var array<Composer> */
$composers = $this->app->get('config')->get('view.composers', []);

Comment threadREADME.md
Comment threadsrc/helpers.php Outdated
@rivanuff
rivanuffforce-pushed the feat/acorn-5 branch 2 times, most recently from 72a8032 to 3290497CompareMarch 13, 2026 15:43
@rivanuff
rivanuff changed the base branch from main to feat/php8.2April 3, 2026 12:16
@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 (feat): acorn 5.0Apr 3, 2026
Base automatically changed from feat/php8.2 to mainApril 3, 2026 13:30
@ictbeheerictbeheer linked an issue Jun 15, 2026 that may be closed by this pull request
@ictbeheerictbeheer removed a link to an issue Jun 15, 2026
@rivanuffrivanuff closed this Sep 2, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@rivanuff@SimonvanWijhe@dtakken@ictbeheer@yard-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

(feat): acorn 5.0 - #22

Closed
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5
Closed

(feat): acorn 5.0#22
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5

Conversation

@rivanuff

@rivanuffrivanuff commented Aug 20, 2025

Copy link
Copy Markdown

@rivanuff
rivanuff requested review from a team, Rovasch, SimonvanWijhe, YvetteNikolov, dtakken, hnccox-yard, ictbeheer, mvdhoek1 and robertbossaert and removed request for a teamAugust 20, 2025 13:18
@github-actions

github-actionsBot commented Aug 20, 2025

Copy link
Copy Markdown
Composer package changes
Prod PackagesOperationBaseTargetLinkLicense
brick/mathUpgraded0.12.30.14.8CompareMIT
carbonphp/carbon-doctrine-typesUpgraded2.1.03.2.0CompareMIT
dragonmantank/cron-expressionUpgradedv3.5.0v3.6.0CompareMIT
guzzlehttp/guzzleUpgraded7.9.37.10.0CompareMIT
guzzlehttp/promisesUpgraded2.2.02.3.0CompareMIT
laravel/frameworkUpgraded10.50.2v12.56.0CompareMIT
laravel/promptsUpgradedv0.1.25v0.3.16CompareMIT
laravel/serializable-closureUpgradedv1.3.7v2.0.10CompareMIT
league/uriNew-7.8.1CompareMIT
league/uri-interfacesNew-7.8.1CompareMIT
nesbot/carbonUpgraded2.73.03.11.3CompareMIT
nette/utilsUpgradedv4.0.10v4.1.3CompareBSD-3-Clause, GPL-2.0-only, GPL-3.0-only
nunomaduro/termwindUpgradedv1.17.0v2.4.0CompareMIT
roots/acornUpgradedv4.3.1v5.1.1CompareMIT
sentry/sentryUpgraded4.23.14.24.0CompareMIT
spatie/laravel-package-toolsUpgraded1.92.41.93.0CompareMIT
symfony/clockNew-v7.4.8CompareMIT
symfony/consoleUpgradedv6.4.35v7.4.8CompareMIT
symfony/css-selectorUpgradedv6.4.34v7.4.8CompareMIT
symfony/error-handlerUpgradedv6.4.32v7.4.8CompareMIT
symfony/event-dispatcherUpgradedv6.4.32v7.4.8CompareMIT
symfony/finderUpgradedv6.4.34v7.4.8CompareMIT
symfony/http-foundationUpgradedv6.4.35v7.4.8CompareMIT
symfony/http-kernelUpgradedv6.4.35v7.4.8CompareMIT
symfony/mailerUpgradedv6.4.34v7.4.8CompareMIT
symfony/mimeUpgradedv6.4.35v7.4.8CompareMIT
symfony/options-resolverUpgradedv6.4.30v7.4.8CompareMIT
symfony/polyfill-php84New-v1.33.0CompareMIT
symfony/polyfill-php85New-v1.33.0CompareMIT
symfony/processUpgradedv6.4.33v7.4.8CompareMIT
symfony/psr-http-message-bridgeUpgradedv6.4.32v7.4.8CompareMIT
symfony/routingUpgradedv6.4.34v7.4.8CompareMIT
symfony/stringUpgradedv6.4.34v7.4.8CompareMIT
symfony/translationUpgradedv6.4.34v7.4.8CompareMIT
symfony/uidUpgradedv6.4.32v7.4.8CompareMIT
symfony/var-dumperUpgradedv6.4.32v7.4.8CompareMIT
phpChanged>=8.1>=8.2
Dev PackagesOperationBaseTargetLinkLicense
filp/whoopsUpgraded2.18.32.18.4CompareMIT
friendsofphp/php-cs-fixerUpgradedv3.89.0v3.94.2CompareMIT
iamcal/sql-parserUpgradedv0.5v0.7CompareMIT
larastan/larastanUpgradedv2.11.2v3.9.3CompareMIT
laravel/pailNew-v1.2.6CompareMIT
laravel/tinkerUpgradedv2.10.1v2.11.1CompareMIT
nunomaduro/collisionUpgradedv7.12.0v8.9.2CompareMIT
orchestra/canvasUpgradedv8.12.0v10.2.0CompareMIT
orchestra/canvas-coreUpgradedv8.10.2v10.2.0CompareMIT
orchestra/sidekickUpgradedv1.2.12v1.2.20CompareMIT
orchestra/testbenchUpgradedv8.36.0v10.11.0CompareMIT
orchestra/testbench-coreUpgradedv8.38.0v10.12.1CompareMIT
orchestra/workbenchUpgradedv8.17.5v10.1.0CompareMIT
php-stubs/wordpress-stubsUpgradedv6.8.1v6.9.1CompareMIT
phpstan/phpstanUpgraded1.12.272.1.46MIT
phpunit/php-code-coverageUpgraded10.1.1611.0.12CompareBSD-3-Clause
phpunit/php-file-iteratorUpgraded4.1.05.1.1CompareBSD-3-Clause
phpunit/php-invokerUpgraded4.0.05.0.1CompareBSD-3-Clause
phpunit/php-text-templateUpgraded3.0.14.0.1CompareBSD-3-Clause
phpunit/php-timerUpgraded6.0.07.0.1CompareBSD-3-Clause
phpunit/phpunitUpgraded10.5.6311.5.55CompareBSD-3-Clause
psy/psyshUpgradedv0.12.19v0.12.22CompareMIT
react/child-processUpgradedv0.6.6v0.6.7CompareMIT
react/dnsUpgradedv1.13.0v1.14.0CompareMIT
react/event-loopUpgradedv1.5.0v1.6.0CompareMIT
react/socketUpgradedv1.16.0v1.17.0CompareMIT
sebastian/cli-parserUpgraded2.0.13.0.2CompareBSD-3-Clause
sebastian/code-unitUpgraded2.0.03.0.3CompareBSD-3-Clause
sebastian/code-unit-reverse-lookupUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/comparatorUpgraded5.0.56.3.3CompareBSD-3-Clause
sebastian/complexityUpgraded3.2.04.0.1CompareBSD-3-Clause
sebastian/diffUpgraded5.1.16.0.2CompareBSD-3-Clause
sebastian/environmentUpgraded6.1.07.2.1CompareBSD-3-Clause
sebastian/exporterUpgraded5.1.46.3.2CompareBSD-3-Clause
sebastian/global-stateUpgraded6.0.27.0.2CompareBSD-3-Clause
sebastian/lines-of-codeUpgraded2.0.23.0.1CompareBSD-3-Clause
sebastian/object-enumeratorUpgraded5.0.06.0.1CompareBSD-3-Clause
sebastian/object-reflectorUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/recursion-contextUpgraded5.0.16.0.3CompareBSD-3-Clause
sebastian/typeUpgraded4.0.05.1.3CompareBSD-3-Clause
sebastian/versionUpgraded4.0.15.0.2CompareBSD-3-Clause
staabm/side-effects-detectorNew-1.0.5CompareMIT
symfony/filesystemUpgradedv6.4.24v7.4.8CompareMIT
symfony/stopwatchUpgradedv6.4.24v7.4.8CompareMIT
symfony/yamlUpgradedv6.4.21v7.4.8CompareMIT
szepeviktor/phpstan-wordpressUpgradedv1.3.5v2.0.3CompareMIT
symfony/polyfill-php73Removedv1.33.0-CompareMIT
symfony/polyfill-php84Removedv1.33.0-CompareMIT

@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 @rivanuff (feat): acorn 5.0 + php 8.2Aug 20, 2025
Comment thread.github/workflows/format-php.yml Outdated
Comment thread.github/workflows/phpstan.yml Outdated
@SimonvanWijhe

SimonvanWijhe commented Aug 25, 2025

Copy link
Copy Markdown
Member

#260

Comment threadsrc/helpers.php
->withMiddleware(function (Middleware $middleware) {
$middleware->append(AddCspHeaders::class);
})
->withRouting(wordpress: true)

@rivanuffrivanuffAug 30, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heb wat getest hiermee, wordpress: true zorgt er iig voor dat de CSP headers niet meer via brave-hooks dmv de send_headers hook moeten worden toegevoegd.

@dtakken

Copy link
Copy Markdown
Contributor

Bij deze even opletten dat deze commit er ook in verwerkt wordt: 5113678

CopilotAI review requested due to automatic review settings March 13, 2026 15:26
@rivanuff
rivanuff requested a review from a team as a code ownerMarch 13, 2026 15:26
@rivanuff
rivanuff requested review from ShunLuk and SimonvanWijhe and removed request for hnccox-yard and robertbossaertMarch 13, 2026 15:26

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this package to support Roots Acorn v5 and PHP 8.2, replacing the prior Acorn v4 bootloader customization approach with the new configuration/builder style used by Acorn 5.

Changes:

  • Upgrade platform/runtime requirements to PHP 8.2 and bump Acorn + dev tooling dependencies.
  • Rework bootloader() to use Application::configure() with exception + middleware configuration hooks.
  • Remove now-redundant custom Kernel/Handler/Vite wrapper classes and adjust view composer attachment logic.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
src/helpers.phpSwitch bootstrapping to Acorn 5 Application::configure() and configure bindings/exceptions/middleware.
src/View/ViewServiceProvider.phpSimplify composer config check when attaching view composers.
src/Http/Kernel.phpRemove custom HTTP kernel (CSP now configured via middleware hook).
src/Exceptions/Handler.phpRemove custom exception handler (Sentry now configured via exceptions hook).
src/Assets/Vite.phpRemove custom Vite wrapper class.
composer.jsonBump PHP + Acorn requirements and update dev tooling versions.
README.mdUpdate documented PHP requirement and bootloader usage example.
.github/workflows/phpstan.ymlYAML formatting/quoting update for PR path filters.
.github/workflows/format-php.ymlYAML formatting/quoting update for PR path filters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 15 to 17
/** @var array<Composer> */
$composers = $this->app->get('config')->get('view.composers', []);

Comment threadREADME.md
Comment threadsrc/helpers.php Outdated
@rivanuff
rivanuffforce-pushed the feat/acorn-5 branch 2 times, most recently from 72a8032 to 3290497CompareMarch 13, 2026 15:43
@rivanuff
rivanuff changed the base branch from main to feat/php8.2April 3, 2026 12:16
@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 (feat): acorn 5.0Apr 3, 2026
Base automatically changed from feat/php8.2 to mainApril 3, 2026 13:30
@ictbeheerictbeheer linked an issue Jun 15, 2026 that may be closed by this pull request
@ictbeheerictbeheer removed a link to an issue Jun 15, 2026
@rivanuffrivanuff closed this Sep 2, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@rivanuff@SimonvanWijhe@dtakken@ictbeheer@yard-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

(feat): acorn 5.0 - #22

Closed
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5
Closed

(feat): acorn 5.0#22
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5

Conversation

@rivanuff

@rivanuffrivanuff commented Aug 20, 2025

Copy link
Copy Markdown

@rivanuff
rivanuff requested review from a team, Rovasch, SimonvanWijhe, YvetteNikolov, dtakken, hnccox-yard, ictbeheer, mvdhoek1 and robertbossaert and removed request for a teamAugust 20, 2025 13:18
@github-actions

github-actionsBot commented Aug 20, 2025

Copy link
Copy Markdown
Composer package changes
Prod PackagesOperationBaseTargetLinkLicense
brick/mathUpgraded0.12.30.14.8CompareMIT
carbonphp/carbon-doctrine-typesUpgraded2.1.03.2.0CompareMIT
dragonmantank/cron-expressionUpgradedv3.5.0v3.6.0CompareMIT
guzzlehttp/guzzleUpgraded7.9.37.10.0CompareMIT
guzzlehttp/promisesUpgraded2.2.02.3.0CompareMIT
laravel/frameworkUpgraded10.50.2v12.56.0CompareMIT
laravel/promptsUpgradedv0.1.25v0.3.16CompareMIT
laravel/serializable-closureUpgradedv1.3.7v2.0.10CompareMIT
league/uriNew-7.8.1CompareMIT
league/uri-interfacesNew-7.8.1CompareMIT
nesbot/carbonUpgraded2.73.03.11.3CompareMIT
nette/utilsUpgradedv4.0.10v4.1.3CompareBSD-3-Clause, GPL-2.0-only, GPL-3.0-only
nunomaduro/termwindUpgradedv1.17.0v2.4.0CompareMIT
roots/acornUpgradedv4.3.1v5.1.1CompareMIT
sentry/sentryUpgraded4.23.14.24.0CompareMIT
spatie/laravel-package-toolsUpgraded1.92.41.93.0CompareMIT
symfony/clockNew-v7.4.8CompareMIT
symfony/consoleUpgradedv6.4.35v7.4.8CompareMIT
symfony/css-selectorUpgradedv6.4.34v7.4.8CompareMIT
symfony/error-handlerUpgradedv6.4.32v7.4.8CompareMIT
symfony/event-dispatcherUpgradedv6.4.32v7.4.8CompareMIT
symfony/finderUpgradedv6.4.34v7.4.8CompareMIT
symfony/http-foundationUpgradedv6.4.35v7.4.8CompareMIT
symfony/http-kernelUpgradedv6.4.35v7.4.8CompareMIT
symfony/mailerUpgradedv6.4.34v7.4.8CompareMIT
symfony/mimeUpgradedv6.4.35v7.4.8CompareMIT
symfony/options-resolverUpgradedv6.4.30v7.4.8CompareMIT
symfony/polyfill-php84New-v1.33.0CompareMIT
symfony/polyfill-php85New-v1.33.0CompareMIT
symfony/processUpgradedv6.4.33v7.4.8CompareMIT
symfony/psr-http-message-bridgeUpgradedv6.4.32v7.4.8CompareMIT
symfony/routingUpgradedv6.4.34v7.4.8CompareMIT
symfony/stringUpgradedv6.4.34v7.4.8CompareMIT
symfony/translationUpgradedv6.4.34v7.4.8CompareMIT
symfony/uidUpgradedv6.4.32v7.4.8CompareMIT
symfony/var-dumperUpgradedv6.4.32v7.4.8CompareMIT
phpChanged>=8.1>=8.2
Dev PackagesOperationBaseTargetLinkLicense
filp/whoopsUpgraded2.18.32.18.4CompareMIT
friendsofphp/php-cs-fixerUpgradedv3.89.0v3.94.2CompareMIT
iamcal/sql-parserUpgradedv0.5v0.7CompareMIT
larastan/larastanUpgradedv2.11.2v3.9.3CompareMIT
laravel/pailNew-v1.2.6CompareMIT
laravel/tinkerUpgradedv2.10.1v2.11.1CompareMIT
nunomaduro/collisionUpgradedv7.12.0v8.9.2CompareMIT
orchestra/canvasUpgradedv8.12.0v10.2.0CompareMIT
orchestra/canvas-coreUpgradedv8.10.2v10.2.0CompareMIT
orchestra/sidekickUpgradedv1.2.12v1.2.20CompareMIT
orchestra/testbenchUpgradedv8.36.0v10.11.0CompareMIT
orchestra/testbench-coreUpgradedv8.38.0v10.12.1CompareMIT
orchestra/workbenchUpgradedv8.17.5v10.1.0CompareMIT
php-stubs/wordpress-stubsUpgradedv6.8.1v6.9.1CompareMIT
phpstan/phpstanUpgraded1.12.272.1.46MIT
phpunit/php-code-coverageUpgraded10.1.1611.0.12CompareBSD-3-Clause
phpunit/php-file-iteratorUpgraded4.1.05.1.1CompareBSD-3-Clause
phpunit/php-invokerUpgraded4.0.05.0.1CompareBSD-3-Clause
phpunit/php-text-templateUpgraded3.0.14.0.1CompareBSD-3-Clause
phpunit/php-timerUpgraded6.0.07.0.1CompareBSD-3-Clause
phpunit/phpunitUpgraded10.5.6311.5.55CompareBSD-3-Clause
psy/psyshUpgradedv0.12.19v0.12.22CompareMIT
react/child-processUpgradedv0.6.6v0.6.7CompareMIT
react/dnsUpgradedv1.13.0v1.14.0CompareMIT
react/event-loopUpgradedv1.5.0v1.6.0CompareMIT
react/socketUpgradedv1.16.0v1.17.0CompareMIT
sebastian/cli-parserUpgraded2.0.13.0.2CompareBSD-3-Clause
sebastian/code-unitUpgraded2.0.03.0.3CompareBSD-3-Clause
sebastian/code-unit-reverse-lookupUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/comparatorUpgraded5.0.56.3.3CompareBSD-3-Clause
sebastian/complexityUpgraded3.2.04.0.1CompareBSD-3-Clause
sebastian/diffUpgraded5.1.16.0.2CompareBSD-3-Clause
sebastian/environmentUpgraded6.1.07.2.1CompareBSD-3-Clause
sebastian/exporterUpgraded5.1.46.3.2CompareBSD-3-Clause
sebastian/global-stateUpgraded6.0.27.0.2CompareBSD-3-Clause
sebastian/lines-of-codeUpgraded2.0.23.0.1CompareBSD-3-Clause
sebastian/object-enumeratorUpgraded5.0.06.0.1CompareBSD-3-Clause
sebastian/object-reflectorUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/recursion-contextUpgraded5.0.16.0.3CompareBSD-3-Clause
sebastian/typeUpgraded4.0.05.1.3CompareBSD-3-Clause
sebastian/versionUpgraded4.0.15.0.2CompareBSD-3-Clause
staabm/side-effects-detectorNew-1.0.5CompareMIT
symfony/filesystemUpgradedv6.4.24v7.4.8CompareMIT
symfony/stopwatchUpgradedv6.4.24v7.4.8CompareMIT
symfony/yamlUpgradedv6.4.21v7.4.8CompareMIT
szepeviktor/phpstan-wordpressUpgradedv1.3.5v2.0.3CompareMIT
symfony/polyfill-php73Removedv1.33.0-CompareMIT
symfony/polyfill-php84Removedv1.33.0-CompareMIT

@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 @rivanuff (feat): acorn 5.0 + php 8.2Aug 20, 2025
Comment thread.github/workflows/format-php.yml Outdated
Comment thread.github/workflows/phpstan.yml Outdated
@SimonvanWijhe

SimonvanWijhe commented Aug 25, 2025

Copy link
Copy Markdown
Member

#260

Comment threadsrc/helpers.php
->withMiddleware(function (Middleware $middleware) {
$middleware->append(AddCspHeaders::class);
})
->withRouting(wordpress: true)

@rivanuffrivanuffAug 30, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heb wat getest hiermee, wordpress: true zorgt er iig voor dat de CSP headers niet meer via brave-hooks dmv de send_headers hook moeten worden toegevoegd.

@dtakken

Copy link
Copy Markdown
Contributor

Bij deze even opletten dat deze commit er ook in verwerkt wordt: 5113678

CopilotAI review requested due to automatic review settings March 13, 2026 15:26
@rivanuff
rivanuff requested a review from a team as a code ownerMarch 13, 2026 15:26
@rivanuff
rivanuff requested review from ShunLuk and SimonvanWijhe and removed request for hnccox-yard and robertbossaertMarch 13, 2026 15:26

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this package to support Roots Acorn v5 and PHP 8.2, replacing the prior Acorn v4 bootloader customization approach with the new configuration/builder style used by Acorn 5.

Changes:

  • Upgrade platform/runtime requirements to PHP 8.2 and bump Acorn + dev tooling dependencies.
  • Rework bootloader() to use Application::configure() with exception + middleware configuration hooks.
  • Remove now-redundant custom Kernel/Handler/Vite wrapper classes and adjust view composer attachment logic.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
src/helpers.phpSwitch bootstrapping to Acorn 5 Application::configure() and configure bindings/exceptions/middleware.
src/View/ViewServiceProvider.phpSimplify composer config check when attaching view composers.
src/Http/Kernel.phpRemove custom HTTP kernel (CSP now configured via middleware hook).
src/Exceptions/Handler.phpRemove custom exception handler (Sentry now configured via exceptions hook).
src/Assets/Vite.phpRemove custom Vite wrapper class.
composer.jsonBump PHP + Acorn requirements and update dev tooling versions.
README.mdUpdate documented PHP requirement and bootloader usage example.
.github/workflows/phpstan.ymlYAML formatting/quoting update for PR path filters.
.github/workflows/format-php.ymlYAML formatting/quoting update for PR path filters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 15 to 17
/** @var array<Composer> */
$composers = $this->app->get('config')->get('view.composers', []);

Comment threadREADME.md
Comment threadsrc/helpers.php Outdated
@rivanuff
rivanuffforce-pushed the feat/acorn-5 branch 2 times, most recently from 72a8032 to 3290497CompareMarch 13, 2026 15:43
@rivanuff
rivanuff changed the base branch from main to feat/php8.2April 3, 2026 12:16
@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 (feat): acorn 5.0Apr 3, 2026
Base automatically changed from feat/php8.2 to mainApril 3, 2026 13:30
@ictbeheerictbeheer linked an issue Jun 15, 2026 that may be closed by this pull request
@ictbeheerictbeheer removed a link to an issue Jun 15, 2026
@rivanuffrivanuff closed this Sep 2, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@rivanuff@SimonvanWijhe@dtakken@ictbeheer@yard-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

(feat): acorn 5.0 - #22

Closed
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5
Closed

(feat): acorn 5.0#22
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5

Conversation

@rivanuff

@rivanuffrivanuff commented Aug 20, 2025

Copy link
Copy Markdown

@rivanuff
rivanuff requested review from a team, Rovasch, SimonvanWijhe, YvetteNikolov, dtakken, hnccox-yard, ictbeheer, mvdhoek1 and robertbossaert and removed request for a teamAugust 20, 2025 13:18
@github-actions

github-actionsBot commented Aug 20, 2025

Copy link
Copy Markdown
Composer package changes
Prod PackagesOperationBaseTargetLinkLicense
brick/mathUpgraded0.12.30.14.8CompareMIT
carbonphp/carbon-doctrine-typesUpgraded2.1.03.2.0CompareMIT
dragonmantank/cron-expressionUpgradedv3.5.0v3.6.0CompareMIT
guzzlehttp/guzzleUpgraded7.9.37.10.0CompareMIT
guzzlehttp/promisesUpgraded2.2.02.3.0CompareMIT
laravel/frameworkUpgraded10.50.2v12.56.0CompareMIT
laravel/promptsUpgradedv0.1.25v0.3.16CompareMIT
laravel/serializable-closureUpgradedv1.3.7v2.0.10CompareMIT
league/uriNew-7.8.1CompareMIT
league/uri-interfacesNew-7.8.1CompareMIT
nesbot/carbonUpgraded2.73.03.11.3CompareMIT
nette/utilsUpgradedv4.0.10v4.1.3CompareBSD-3-Clause, GPL-2.0-only, GPL-3.0-only
nunomaduro/termwindUpgradedv1.17.0v2.4.0CompareMIT
roots/acornUpgradedv4.3.1v5.1.1CompareMIT
sentry/sentryUpgraded4.23.14.24.0CompareMIT
spatie/laravel-package-toolsUpgraded1.92.41.93.0CompareMIT
symfony/clockNew-v7.4.8CompareMIT
symfony/consoleUpgradedv6.4.35v7.4.8CompareMIT
symfony/css-selectorUpgradedv6.4.34v7.4.8CompareMIT
symfony/error-handlerUpgradedv6.4.32v7.4.8CompareMIT
symfony/event-dispatcherUpgradedv6.4.32v7.4.8CompareMIT
symfony/finderUpgradedv6.4.34v7.4.8CompareMIT
symfony/http-foundationUpgradedv6.4.35v7.4.8CompareMIT
symfony/http-kernelUpgradedv6.4.35v7.4.8CompareMIT
symfony/mailerUpgradedv6.4.34v7.4.8CompareMIT
symfony/mimeUpgradedv6.4.35v7.4.8CompareMIT
symfony/options-resolverUpgradedv6.4.30v7.4.8CompareMIT
symfony/polyfill-php84New-v1.33.0CompareMIT
symfony/polyfill-php85New-v1.33.0CompareMIT
symfony/processUpgradedv6.4.33v7.4.8CompareMIT
symfony/psr-http-message-bridgeUpgradedv6.4.32v7.4.8CompareMIT
symfony/routingUpgradedv6.4.34v7.4.8CompareMIT
symfony/stringUpgradedv6.4.34v7.4.8CompareMIT
symfony/translationUpgradedv6.4.34v7.4.8CompareMIT
symfony/uidUpgradedv6.4.32v7.4.8CompareMIT
symfony/var-dumperUpgradedv6.4.32v7.4.8CompareMIT
phpChanged>=8.1>=8.2
Dev PackagesOperationBaseTargetLinkLicense
filp/whoopsUpgraded2.18.32.18.4CompareMIT
friendsofphp/php-cs-fixerUpgradedv3.89.0v3.94.2CompareMIT
iamcal/sql-parserUpgradedv0.5v0.7CompareMIT
larastan/larastanUpgradedv2.11.2v3.9.3CompareMIT
laravel/pailNew-v1.2.6CompareMIT
laravel/tinkerUpgradedv2.10.1v2.11.1CompareMIT
nunomaduro/collisionUpgradedv7.12.0v8.9.2CompareMIT
orchestra/canvasUpgradedv8.12.0v10.2.0CompareMIT
orchestra/canvas-coreUpgradedv8.10.2v10.2.0CompareMIT
orchestra/sidekickUpgradedv1.2.12v1.2.20CompareMIT
orchestra/testbenchUpgradedv8.36.0v10.11.0CompareMIT
orchestra/testbench-coreUpgradedv8.38.0v10.12.1CompareMIT
orchestra/workbenchUpgradedv8.17.5v10.1.0CompareMIT
php-stubs/wordpress-stubsUpgradedv6.8.1v6.9.1CompareMIT
phpstan/phpstanUpgraded1.12.272.1.46MIT
phpunit/php-code-coverageUpgraded10.1.1611.0.12CompareBSD-3-Clause
phpunit/php-file-iteratorUpgraded4.1.05.1.1CompareBSD-3-Clause
phpunit/php-invokerUpgraded4.0.05.0.1CompareBSD-3-Clause
phpunit/php-text-templateUpgraded3.0.14.0.1CompareBSD-3-Clause
phpunit/php-timerUpgraded6.0.07.0.1CompareBSD-3-Clause
phpunit/phpunitUpgraded10.5.6311.5.55CompareBSD-3-Clause
psy/psyshUpgradedv0.12.19v0.12.22CompareMIT
react/child-processUpgradedv0.6.6v0.6.7CompareMIT
react/dnsUpgradedv1.13.0v1.14.0CompareMIT
react/event-loopUpgradedv1.5.0v1.6.0CompareMIT
react/socketUpgradedv1.16.0v1.17.0CompareMIT
sebastian/cli-parserUpgraded2.0.13.0.2CompareBSD-3-Clause
sebastian/code-unitUpgraded2.0.03.0.3CompareBSD-3-Clause
sebastian/code-unit-reverse-lookupUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/comparatorUpgraded5.0.56.3.3CompareBSD-3-Clause
sebastian/complexityUpgraded3.2.04.0.1CompareBSD-3-Clause
sebastian/diffUpgraded5.1.16.0.2CompareBSD-3-Clause
sebastian/environmentUpgraded6.1.07.2.1CompareBSD-3-Clause
sebastian/exporterUpgraded5.1.46.3.2CompareBSD-3-Clause
sebastian/global-stateUpgraded6.0.27.0.2CompareBSD-3-Clause
sebastian/lines-of-codeUpgraded2.0.23.0.1CompareBSD-3-Clause
sebastian/object-enumeratorUpgraded5.0.06.0.1CompareBSD-3-Clause
sebastian/object-reflectorUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/recursion-contextUpgraded5.0.16.0.3CompareBSD-3-Clause
sebastian/typeUpgraded4.0.05.1.3CompareBSD-3-Clause
sebastian/versionUpgraded4.0.15.0.2CompareBSD-3-Clause
staabm/side-effects-detectorNew-1.0.5CompareMIT
symfony/filesystemUpgradedv6.4.24v7.4.8CompareMIT
symfony/stopwatchUpgradedv6.4.24v7.4.8CompareMIT
symfony/yamlUpgradedv6.4.21v7.4.8CompareMIT
szepeviktor/phpstan-wordpressUpgradedv1.3.5v2.0.3CompareMIT
symfony/polyfill-php73Removedv1.33.0-CompareMIT
symfony/polyfill-php84Removedv1.33.0-CompareMIT

@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 @rivanuff (feat): acorn 5.0 + php 8.2Aug 20, 2025
Comment thread.github/workflows/format-php.yml Outdated
Comment thread.github/workflows/phpstan.yml Outdated
@SimonvanWijhe

SimonvanWijhe commented Aug 25, 2025

Copy link
Copy Markdown
Member

#260

Comment threadsrc/helpers.php
->withMiddleware(function (Middleware $middleware) {
$middleware->append(AddCspHeaders::class);
})
->withRouting(wordpress: true)

@rivanuffrivanuffAug 30, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heb wat getest hiermee, wordpress: true zorgt er iig voor dat de CSP headers niet meer via brave-hooks dmv de send_headers hook moeten worden toegevoegd.

@dtakken

Copy link
Copy Markdown
Contributor

Bij deze even opletten dat deze commit er ook in verwerkt wordt: 5113678

CopilotAI review requested due to automatic review settings March 13, 2026 15:26
@rivanuff
rivanuff requested a review from a team as a code ownerMarch 13, 2026 15:26
@rivanuff
rivanuff requested review from ShunLuk and SimonvanWijhe and removed request for hnccox-yard and robertbossaertMarch 13, 2026 15:26

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this package to support Roots Acorn v5 and PHP 8.2, replacing the prior Acorn v4 bootloader customization approach with the new configuration/builder style used by Acorn 5.

Changes:

  • Upgrade platform/runtime requirements to PHP 8.2 and bump Acorn + dev tooling dependencies.
  • Rework bootloader() to use Application::configure() with exception + middleware configuration hooks.
  • Remove now-redundant custom Kernel/Handler/Vite wrapper classes and adjust view composer attachment logic.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
src/helpers.phpSwitch bootstrapping to Acorn 5 Application::configure() and configure bindings/exceptions/middleware.
src/View/ViewServiceProvider.phpSimplify composer config check when attaching view composers.
src/Http/Kernel.phpRemove custom HTTP kernel (CSP now configured via middleware hook).
src/Exceptions/Handler.phpRemove custom exception handler (Sentry now configured via exceptions hook).
src/Assets/Vite.phpRemove custom Vite wrapper class.
composer.jsonBump PHP + Acorn requirements and update dev tooling versions.
README.mdUpdate documented PHP requirement and bootloader usage example.
.github/workflows/phpstan.ymlYAML formatting/quoting update for PR path filters.
.github/workflows/format-php.ymlYAML formatting/quoting update for PR path filters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 15 to 17
/** @var array<Composer> */
$composers = $this->app->get('config')->get('view.composers', []);

Comment threadREADME.md
Comment threadsrc/helpers.php Outdated
@rivanuff
rivanuffforce-pushed the feat/acorn-5 branch 2 times, most recently from 72a8032 to 3290497CompareMarch 13, 2026 15:43
@rivanuff
rivanuff changed the base branch from main to feat/php8.2April 3, 2026 12:16
@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 (feat): acorn 5.0Apr 3, 2026
Base automatically changed from feat/php8.2 to mainApril 3, 2026 13:30
@ictbeheerictbeheer linked an issue Jun 15, 2026 that may be closed by this pull request
@ictbeheerictbeheer removed a link to an issue Jun 15, 2026
@rivanuffrivanuff closed this Sep 2, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@rivanuff@SimonvanWijhe@dtakken@ictbeheer@yard-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

(feat): acorn 5.0 - #22

Closed
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5
Closed

(feat): acorn 5.0#22
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5

Conversation

@rivanuff

@rivanuffrivanuff commented Aug 20, 2025

Copy link
Copy Markdown

@rivanuff
rivanuff requested review from a team, Rovasch, SimonvanWijhe, YvetteNikolov, dtakken, hnccox-yard, ictbeheer, mvdhoek1 and robertbossaert and removed request for a teamAugust 20, 2025 13:18
@github-actions

github-actionsBot commented Aug 20, 2025

Copy link
Copy Markdown
Composer package changes
Prod PackagesOperationBaseTargetLinkLicense
brick/mathUpgraded0.12.30.14.8CompareMIT
carbonphp/carbon-doctrine-typesUpgraded2.1.03.2.0CompareMIT
dragonmantank/cron-expressionUpgradedv3.5.0v3.6.0CompareMIT
guzzlehttp/guzzleUpgraded7.9.37.10.0CompareMIT
guzzlehttp/promisesUpgraded2.2.02.3.0CompareMIT
laravel/frameworkUpgraded10.50.2v12.56.0CompareMIT
laravel/promptsUpgradedv0.1.25v0.3.16CompareMIT
laravel/serializable-closureUpgradedv1.3.7v2.0.10CompareMIT
league/uriNew-7.8.1CompareMIT
league/uri-interfacesNew-7.8.1CompareMIT
nesbot/carbonUpgraded2.73.03.11.3CompareMIT
nette/utilsUpgradedv4.0.10v4.1.3CompareBSD-3-Clause, GPL-2.0-only, GPL-3.0-only
nunomaduro/termwindUpgradedv1.17.0v2.4.0CompareMIT
roots/acornUpgradedv4.3.1v5.1.1CompareMIT
sentry/sentryUpgraded4.23.14.24.0CompareMIT
spatie/laravel-package-toolsUpgraded1.92.41.93.0CompareMIT
symfony/clockNew-v7.4.8CompareMIT
symfony/consoleUpgradedv6.4.35v7.4.8CompareMIT
symfony/css-selectorUpgradedv6.4.34v7.4.8CompareMIT
symfony/error-handlerUpgradedv6.4.32v7.4.8CompareMIT
symfony/event-dispatcherUpgradedv6.4.32v7.4.8CompareMIT
symfony/finderUpgradedv6.4.34v7.4.8CompareMIT
symfony/http-foundationUpgradedv6.4.35v7.4.8CompareMIT
symfony/http-kernelUpgradedv6.4.35v7.4.8CompareMIT
symfony/mailerUpgradedv6.4.34v7.4.8CompareMIT
symfony/mimeUpgradedv6.4.35v7.4.8CompareMIT
symfony/options-resolverUpgradedv6.4.30v7.4.8CompareMIT
symfony/polyfill-php84New-v1.33.0CompareMIT
symfony/polyfill-php85New-v1.33.0CompareMIT
symfony/processUpgradedv6.4.33v7.4.8CompareMIT
symfony/psr-http-message-bridgeUpgradedv6.4.32v7.4.8CompareMIT
symfony/routingUpgradedv6.4.34v7.4.8CompareMIT
symfony/stringUpgradedv6.4.34v7.4.8CompareMIT
symfony/translationUpgradedv6.4.34v7.4.8CompareMIT
symfony/uidUpgradedv6.4.32v7.4.8CompareMIT
symfony/var-dumperUpgradedv6.4.32v7.4.8CompareMIT
phpChanged>=8.1>=8.2
Dev PackagesOperationBaseTargetLinkLicense
filp/whoopsUpgraded2.18.32.18.4CompareMIT
friendsofphp/php-cs-fixerUpgradedv3.89.0v3.94.2CompareMIT
iamcal/sql-parserUpgradedv0.5v0.7CompareMIT
larastan/larastanUpgradedv2.11.2v3.9.3CompareMIT
laravel/pailNew-v1.2.6CompareMIT
laravel/tinkerUpgradedv2.10.1v2.11.1CompareMIT
nunomaduro/collisionUpgradedv7.12.0v8.9.2CompareMIT
orchestra/canvasUpgradedv8.12.0v10.2.0CompareMIT
orchestra/canvas-coreUpgradedv8.10.2v10.2.0CompareMIT
orchestra/sidekickUpgradedv1.2.12v1.2.20CompareMIT
orchestra/testbenchUpgradedv8.36.0v10.11.0CompareMIT
orchestra/testbench-coreUpgradedv8.38.0v10.12.1CompareMIT
orchestra/workbenchUpgradedv8.17.5v10.1.0CompareMIT
php-stubs/wordpress-stubsUpgradedv6.8.1v6.9.1CompareMIT
phpstan/phpstanUpgraded1.12.272.1.46MIT
phpunit/php-code-coverageUpgraded10.1.1611.0.12CompareBSD-3-Clause
phpunit/php-file-iteratorUpgraded4.1.05.1.1CompareBSD-3-Clause
phpunit/php-invokerUpgraded4.0.05.0.1CompareBSD-3-Clause
phpunit/php-text-templateUpgraded3.0.14.0.1CompareBSD-3-Clause
phpunit/php-timerUpgraded6.0.07.0.1CompareBSD-3-Clause
phpunit/phpunitUpgraded10.5.6311.5.55CompareBSD-3-Clause
psy/psyshUpgradedv0.12.19v0.12.22CompareMIT
react/child-processUpgradedv0.6.6v0.6.7CompareMIT
react/dnsUpgradedv1.13.0v1.14.0CompareMIT
react/event-loopUpgradedv1.5.0v1.6.0CompareMIT
react/socketUpgradedv1.16.0v1.17.0CompareMIT
sebastian/cli-parserUpgraded2.0.13.0.2CompareBSD-3-Clause
sebastian/code-unitUpgraded2.0.03.0.3CompareBSD-3-Clause
sebastian/code-unit-reverse-lookupUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/comparatorUpgraded5.0.56.3.3CompareBSD-3-Clause
sebastian/complexityUpgraded3.2.04.0.1CompareBSD-3-Clause
sebastian/diffUpgraded5.1.16.0.2CompareBSD-3-Clause
sebastian/environmentUpgraded6.1.07.2.1CompareBSD-3-Clause
sebastian/exporterUpgraded5.1.46.3.2CompareBSD-3-Clause
sebastian/global-stateUpgraded6.0.27.0.2CompareBSD-3-Clause
sebastian/lines-of-codeUpgraded2.0.23.0.1CompareBSD-3-Clause
sebastian/object-enumeratorUpgraded5.0.06.0.1CompareBSD-3-Clause
sebastian/object-reflectorUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/recursion-contextUpgraded5.0.16.0.3CompareBSD-3-Clause
sebastian/typeUpgraded4.0.05.1.3CompareBSD-3-Clause
sebastian/versionUpgraded4.0.15.0.2CompareBSD-3-Clause
staabm/side-effects-detectorNew-1.0.5CompareMIT
symfony/filesystemUpgradedv6.4.24v7.4.8CompareMIT
symfony/stopwatchUpgradedv6.4.24v7.4.8CompareMIT
symfony/yamlUpgradedv6.4.21v7.4.8CompareMIT
szepeviktor/phpstan-wordpressUpgradedv1.3.5v2.0.3CompareMIT
symfony/polyfill-php73Removedv1.33.0-CompareMIT
symfony/polyfill-php84Removedv1.33.0-CompareMIT

@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 @rivanuff (feat): acorn 5.0 + php 8.2Aug 20, 2025
Comment thread.github/workflows/format-php.yml Outdated
Comment thread.github/workflows/phpstan.yml Outdated
@SimonvanWijhe

SimonvanWijhe commented Aug 25, 2025

Copy link
Copy Markdown
Member

#260

Comment threadsrc/helpers.php
->withMiddleware(function (Middleware $middleware) {
$middleware->append(AddCspHeaders::class);
})
->withRouting(wordpress: true)

@rivanuffrivanuffAug 30, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heb wat getest hiermee, wordpress: true zorgt er iig voor dat de CSP headers niet meer via brave-hooks dmv de send_headers hook moeten worden toegevoegd.

@dtakken

Copy link
Copy Markdown
Contributor

Bij deze even opletten dat deze commit er ook in verwerkt wordt: 5113678

CopilotAI review requested due to automatic review settings March 13, 2026 15:26
@rivanuff
rivanuff requested a review from a team as a code ownerMarch 13, 2026 15:26
@rivanuff
rivanuff requested review from ShunLuk and SimonvanWijhe and removed request for hnccox-yard and robertbossaertMarch 13, 2026 15:26

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this package to support Roots Acorn v5 and PHP 8.2, replacing the prior Acorn v4 bootloader customization approach with the new configuration/builder style used by Acorn 5.

Changes:

  • Upgrade platform/runtime requirements to PHP 8.2 and bump Acorn + dev tooling dependencies.
  • Rework bootloader() to use Application::configure() with exception + middleware configuration hooks.
  • Remove now-redundant custom Kernel/Handler/Vite wrapper classes and adjust view composer attachment logic.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
src/helpers.phpSwitch bootstrapping to Acorn 5 Application::configure() and configure bindings/exceptions/middleware.
src/View/ViewServiceProvider.phpSimplify composer config check when attaching view composers.
src/Http/Kernel.phpRemove custom HTTP kernel (CSP now configured via middleware hook).
src/Exceptions/Handler.phpRemove custom exception handler (Sentry now configured via exceptions hook).
src/Assets/Vite.phpRemove custom Vite wrapper class.
composer.jsonBump PHP + Acorn requirements and update dev tooling versions.
README.mdUpdate documented PHP requirement and bootloader usage example.
.github/workflows/phpstan.ymlYAML formatting/quoting update for PR path filters.
.github/workflows/format-php.ymlYAML formatting/quoting update for PR path filters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 15 to 17
/** @var array<Composer> */
$composers = $this->app->get('config')->get('view.composers', []);

Comment threadREADME.md
Comment threadsrc/helpers.php Outdated
@rivanuff
rivanuffforce-pushed the feat/acorn-5 branch 2 times, most recently from 72a8032 to 3290497CompareMarch 13, 2026 15:43
@rivanuff
rivanuff changed the base branch from main to feat/php8.2April 3, 2026 12:16
@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 (feat): acorn 5.0Apr 3, 2026
Base automatically changed from feat/php8.2 to mainApril 3, 2026 13:30
@ictbeheerictbeheer linked an issue Jun 15, 2026 that may be closed by this pull request
@ictbeheerictbeheer removed a link to an issue Jun 15, 2026
@rivanuffrivanuff closed this Sep 2, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@rivanuff@SimonvanWijhe@dtakken@ictbeheer@yard-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

(feat): acorn 5.0 - #22

Closed
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5
Closed

(feat): acorn 5.0#22
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5

Conversation

@rivanuff

@rivanuffrivanuff commented Aug 20, 2025

Copy link
Copy Markdown

@rivanuff
rivanuff requested review from a team, Rovasch, SimonvanWijhe, YvetteNikolov, dtakken, hnccox-yard, ictbeheer, mvdhoek1 and robertbossaert and removed request for a teamAugust 20, 2025 13:18
@github-actions

github-actionsBot commented Aug 20, 2025

Copy link
Copy Markdown
Composer package changes
Prod PackagesOperationBaseTargetLinkLicense
brick/mathUpgraded0.12.30.14.8CompareMIT
carbonphp/carbon-doctrine-typesUpgraded2.1.03.2.0CompareMIT
dragonmantank/cron-expressionUpgradedv3.5.0v3.6.0CompareMIT
guzzlehttp/guzzleUpgraded7.9.37.10.0CompareMIT
guzzlehttp/promisesUpgraded2.2.02.3.0CompareMIT
laravel/frameworkUpgraded10.50.2v12.56.0CompareMIT
laravel/promptsUpgradedv0.1.25v0.3.16CompareMIT
laravel/serializable-closureUpgradedv1.3.7v2.0.10CompareMIT
league/uriNew-7.8.1CompareMIT
league/uri-interfacesNew-7.8.1CompareMIT
nesbot/carbonUpgraded2.73.03.11.3CompareMIT
nette/utilsUpgradedv4.0.10v4.1.3CompareBSD-3-Clause, GPL-2.0-only, GPL-3.0-only
nunomaduro/termwindUpgradedv1.17.0v2.4.0CompareMIT
roots/acornUpgradedv4.3.1v5.1.1CompareMIT
sentry/sentryUpgraded4.23.14.24.0CompareMIT
spatie/laravel-package-toolsUpgraded1.92.41.93.0CompareMIT
symfony/clockNew-v7.4.8CompareMIT
symfony/consoleUpgradedv6.4.35v7.4.8CompareMIT
symfony/css-selectorUpgradedv6.4.34v7.4.8CompareMIT
symfony/error-handlerUpgradedv6.4.32v7.4.8CompareMIT
symfony/event-dispatcherUpgradedv6.4.32v7.4.8CompareMIT
symfony/finderUpgradedv6.4.34v7.4.8CompareMIT
symfony/http-foundationUpgradedv6.4.35v7.4.8CompareMIT
symfony/http-kernelUpgradedv6.4.35v7.4.8CompareMIT
symfony/mailerUpgradedv6.4.34v7.4.8CompareMIT
symfony/mimeUpgradedv6.4.35v7.4.8CompareMIT
symfony/options-resolverUpgradedv6.4.30v7.4.8CompareMIT
symfony/polyfill-php84New-v1.33.0CompareMIT
symfony/polyfill-php85New-v1.33.0CompareMIT
symfony/processUpgradedv6.4.33v7.4.8CompareMIT
symfony/psr-http-message-bridgeUpgradedv6.4.32v7.4.8CompareMIT
symfony/routingUpgradedv6.4.34v7.4.8CompareMIT
symfony/stringUpgradedv6.4.34v7.4.8CompareMIT
symfony/translationUpgradedv6.4.34v7.4.8CompareMIT
symfony/uidUpgradedv6.4.32v7.4.8CompareMIT
symfony/var-dumperUpgradedv6.4.32v7.4.8CompareMIT
phpChanged>=8.1>=8.2
Dev PackagesOperationBaseTargetLinkLicense
filp/whoopsUpgraded2.18.32.18.4CompareMIT
friendsofphp/php-cs-fixerUpgradedv3.89.0v3.94.2CompareMIT
iamcal/sql-parserUpgradedv0.5v0.7CompareMIT
larastan/larastanUpgradedv2.11.2v3.9.3CompareMIT
laravel/pailNew-v1.2.6CompareMIT
laravel/tinkerUpgradedv2.10.1v2.11.1CompareMIT
nunomaduro/collisionUpgradedv7.12.0v8.9.2CompareMIT
orchestra/canvasUpgradedv8.12.0v10.2.0CompareMIT
orchestra/canvas-coreUpgradedv8.10.2v10.2.0CompareMIT
orchestra/sidekickUpgradedv1.2.12v1.2.20CompareMIT
orchestra/testbenchUpgradedv8.36.0v10.11.0CompareMIT
orchestra/testbench-coreUpgradedv8.38.0v10.12.1CompareMIT
orchestra/workbenchUpgradedv8.17.5v10.1.0CompareMIT
php-stubs/wordpress-stubsUpgradedv6.8.1v6.9.1CompareMIT
phpstan/phpstanUpgraded1.12.272.1.46MIT
phpunit/php-code-coverageUpgraded10.1.1611.0.12CompareBSD-3-Clause
phpunit/php-file-iteratorUpgraded4.1.05.1.1CompareBSD-3-Clause
phpunit/php-invokerUpgraded4.0.05.0.1CompareBSD-3-Clause
phpunit/php-text-templateUpgraded3.0.14.0.1CompareBSD-3-Clause
phpunit/php-timerUpgraded6.0.07.0.1CompareBSD-3-Clause
phpunit/phpunitUpgraded10.5.6311.5.55CompareBSD-3-Clause
psy/psyshUpgradedv0.12.19v0.12.22CompareMIT
react/child-processUpgradedv0.6.6v0.6.7CompareMIT
react/dnsUpgradedv1.13.0v1.14.0CompareMIT
react/event-loopUpgradedv1.5.0v1.6.0CompareMIT
react/socketUpgradedv1.16.0v1.17.0CompareMIT
sebastian/cli-parserUpgraded2.0.13.0.2CompareBSD-3-Clause
sebastian/code-unitUpgraded2.0.03.0.3CompareBSD-3-Clause
sebastian/code-unit-reverse-lookupUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/comparatorUpgraded5.0.56.3.3CompareBSD-3-Clause
sebastian/complexityUpgraded3.2.04.0.1CompareBSD-3-Clause
sebastian/diffUpgraded5.1.16.0.2CompareBSD-3-Clause
sebastian/environmentUpgraded6.1.07.2.1CompareBSD-3-Clause
sebastian/exporterUpgraded5.1.46.3.2CompareBSD-3-Clause
sebastian/global-stateUpgraded6.0.27.0.2CompareBSD-3-Clause
sebastian/lines-of-codeUpgraded2.0.23.0.1CompareBSD-3-Clause
sebastian/object-enumeratorUpgraded5.0.06.0.1CompareBSD-3-Clause
sebastian/object-reflectorUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/recursion-contextUpgraded5.0.16.0.3CompareBSD-3-Clause
sebastian/typeUpgraded4.0.05.1.3CompareBSD-3-Clause
sebastian/versionUpgraded4.0.15.0.2CompareBSD-3-Clause
staabm/side-effects-detectorNew-1.0.5CompareMIT
symfony/filesystemUpgradedv6.4.24v7.4.8CompareMIT
symfony/stopwatchUpgradedv6.4.24v7.4.8CompareMIT
symfony/yamlUpgradedv6.4.21v7.4.8CompareMIT
szepeviktor/phpstan-wordpressUpgradedv1.3.5v2.0.3CompareMIT
symfony/polyfill-php73Removedv1.33.0-CompareMIT
symfony/polyfill-php84Removedv1.33.0-CompareMIT

@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 @rivanuff (feat): acorn 5.0 + php 8.2Aug 20, 2025
Comment thread.github/workflows/format-php.yml Outdated
Comment thread.github/workflows/phpstan.yml Outdated
@SimonvanWijhe

SimonvanWijhe commented Aug 25, 2025

Copy link
Copy Markdown
Member

#260

Comment threadsrc/helpers.php
->withMiddleware(function (Middleware $middleware) {
$middleware->append(AddCspHeaders::class);
})
->withRouting(wordpress: true)

@rivanuffrivanuffAug 30, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heb wat getest hiermee, wordpress: true zorgt er iig voor dat de CSP headers niet meer via brave-hooks dmv de send_headers hook moeten worden toegevoegd.

@dtakken

Copy link
Copy Markdown
Contributor

Bij deze even opletten dat deze commit er ook in verwerkt wordt: 5113678

CopilotAI review requested due to automatic review settings March 13, 2026 15:26
@rivanuff
rivanuff requested a review from a team as a code ownerMarch 13, 2026 15:26
@rivanuff
rivanuff requested review from ShunLuk and SimonvanWijhe and removed request for hnccox-yard and robertbossaertMarch 13, 2026 15:26

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this package to support Roots Acorn v5 and PHP 8.2, replacing the prior Acorn v4 bootloader customization approach with the new configuration/builder style used by Acorn 5.

Changes:

  • Upgrade platform/runtime requirements to PHP 8.2 and bump Acorn + dev tooling dependencies.
  • Rework bootloader() to use Application::configure() with exception + middleware configuration hooks.
  • Remove now-redundant custom Kernel/Handler/Vite wrapper classes and adjust view composer attachment logic.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
src/helpers.phpSwitch bootstrapping to Acorn 5 Application::configure() and configure bindings/exceptions/middleware.
src/View/ViewServiceProvider.phpSimplify composer config check when attaching view composers.
src/Http/Kernel.phpRemove custom HTTP kernel (CSP now configured via middleware hook).
src/Exceptions/Handler.phpRemove custom exception handler (Sentry now configured via exceptions hook).
src/Assets/Vite.phpRemove custom Vite wrapper class.
composer.jsonBump PHP + Acorn requirements and update dev tooling versions.
README.mdUpdate documented PHP requirement and bootloader usage example.
.github/workflows/phpstan.ymlYAML formatting/quoting update for PR path filters.
.github/workflows/format-php.ymlYAML formatting/quoting update for PR path filters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 15 to 17
/** @var array<Composer> */
$composers = $this->app->get('config')->get('view.composers', []);

Comment threadREADME.md
Comment threadsrc/helpers.php Outdated
@rivanuff
rivanuffforce-pushed the feat/acorn-5 branch 2 times, most recently from 72a8032 to 3290497CompareMarch 13, 2026 15:43
@rivanuff
rivanuff changed the base branch from main to feat/php8.2April 3, 2026 12:16
@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 (feat): acorn 5.0Apr 3, 2026
Base automatically changed from feat/php8.2 to mainApril 3, 2026 13:30
@ictbeheerictbeheer linked an issue Jun 15, 2026 that may be closed by this pull request
@ictbeheerictbeheer removed a link to an issue Jun 15, 2026
@rivanuffrivanuff closed this Sep 2, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@rivanuff@SimonvanWijhe@dtakken@ictbeheer@yard-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

(feat): acorn 5.0 - #22

Closed
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5
Closed

(feat): acorn 5.0#22
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5

Conversation

@rivanuff

@rivanuffrivanuff commented Aug 20, 2025

Copy link
Copy Markdown

@rivanuff
rivanuff requested review from a team, Rovasch, SimonvanWijhe, YvetteNikolov, dtakken, hnccox-yard, ictbeheer, mvdhoek1 and robertbossaert and removed request for a teamAugust 20, 2025 13:18
@github-actions

github-actionsBot commented Aug 20, 2025

Copy link
Copy Markdown
Composer package changes
Prod PackagesOperationBaseTargetLinkLicense
brick/mathUpgraded0.12.30.14.8CompareMIT
carbonphp/carbon-doctrine-typesUpgraded2.1.03.2.0CompareMIT
dragonmantank/cron-expressionUpgradedv3.5.0v3.6.0CompareMIT
guzzlehttp/guzzleUpgraded7.9.37.10.0CompareMIT
guzzlehttp/promisesUpgraded2.2.02.3.0CompareMIT
laravel/frameworkUpgraded10.50.2v12.56.0CompareMIT
laravel/promptsUpgradedv0.1.25v0.3.16CompareMIT
laravel/serializable-closureUpgradedv1.3.7v2.0.10CompareMIT
league/uriNew-7.8.1CompareMIT
league/uri-interfacesNew-7.8.1CompareMIT
nesbot/carbonUpgraded2.73.03.11.3CompareMIT
nette/utilsUpgradedv4.0.10v4.1.3CompareBSD-3-Clause, GPL-2.0-only, GPL-3.0-only
nunomaduro/termwindUpgradedv1.17.0v2.4.0CompareMIT
roots/acornUpgradedv4.3.1v5.1.1CompareMIT
sentry/sentryUpgraded4.23.14.24.0CompareMIT
spatie/laravel-package-toolsUpgraded1.92.41.93.0CompareMIT
symfony/clockNew-v7.4.8CompareMIT
symfony/consoleUpgradedv6.4.35v7.4.8CompareMIT
symfony/css-selectorUpgradedv6.4.34v7.4.8CompareMIT
symfony/error-handlerUpgradedv6.4.32v7.4.8CompareMIT
symfony/event-dispatcherUpgradedv6.4.32v7.4.8CompareMIT
symfony/finderUpgradedv6.4.34v7.4.8CompareMIT
symfony/http-foundationUpgradedv6.4.35v7.4.8CompareMIT
symfony/http-kernelUpgradedv6.4.35v7.4.8CompareMIT
symfony/mailerUpgradedv6.4.34v7.4.8CompareMIT
symfony/mimeUpgradedv6.4.35v7.4.8CompareMIT
symfony/options-resolverUpgradedv6.4.30v7.4.8CompareMIT
symfony/polyfill-php84New-v1.33.0CompareMIT
symfony/polyfill-php85New-v1.33.0CompareMIT
symfony/processUpgradedv6.4.33v7.4.8CompareMIT
symfony/psr-http-message-bridgeUpgradedv6.4.32v7.4.8CompareMIT
symfony/routingUpgradedv6.4.34v7.4.8CompareMIT
symfony/stringUpgradedv6.4.34v7.4.8CompareMIT
symfony/translationUpgradedv6.4.34v7.4.8CompareMIT
symfony/uidUpgradedv6.4.32v7.4.8CompareMIT
symfony/var-dumperUpgradedv6.4.32v7.4.8CompareMIT
phpChanged>=8.1>=8.2
Dev PackagesOperationBaseTargetLinkLicense
filp/whoopsUpgraded2.18.32.18.4CompareMIT
friendsofphp/php-cs-fixerUpgradedv3.89.0v3.94.2CompareMIT
iamcal/sql-parserUpgradedv0.5v0.7CompareMIT
larastan/larastanUpgradedv2.11.2v3.9.3CompareMIT
laravel/pailNew-v1.2.6CompareMIT
laravel/tinkerUpgradedv2.10.1v2.11.1CompareMIT
nunomaduro/collisionUpgradedv7.12.0v8.9.2CompareMIT
orchestra/canvasUpgradedv8.12.0v10.2.0CompareMIT
orchestra/canvas-coreUpgradedv8.10.2v10.2.0CompareMIT
orchestra/sidekickUpgradedv1.2.12v1.2.20CompareMIT
orchestra/testbenchUpgradedv8.36.0v10.11.0CompareMIT
orchestra/testbench-coreUpgradedv8.38.0v10.12.1CompareMIT
orchestra/workbenchUpgradedv8.17.5v10.1.0CompareMIT
php-stubs/wordpress-stubsUpgradedv6.8.1v6.9.1CompareMIT
phpstan/phpstanUpgraded1.12.272.1.46MIT
phpunit/php-code-coverageUpgraded10.1.1611.0.12CompareBSD-3-Clause
phpunit/php-file-iteratorUpgraded4.1.05.1.1CompareBSD-3-Clause
phpunit/php-invokerUpgraded4.0.05.0.1CompareBSD-3-Clause
phpunit/php-text-templateUpgraded3.0.14.0.1CompareBSD-3-Clause
phpunit/php-timerUpgraded6.0.07.0.1CompareBSD-3-Clause
phpunit/phpunitUpgraded10.5.6311.5.55CompareBSD-3-Clause
psy/psyshUpgradedv0.12.19v0.12.22CompareMIT
react/child-processUpgradedv0.6.6v0.6.7CompareMIT
react/dnsUpgradedv1.13.0v1.14.0CompareMIT
react/event-loopUpgradedv1.5.0v1.6.0CompareMIT
react/socketUpgradedv1.16.0v1.17.0CompareMIT
sebastian/cli-parserUpgraded2.0.13.0.2CompareBSD-3-Clause
sebastian/code-unitUpgraded2.0.03.0.3CompareBSD-3-Clause
sebastian/code-unit-reverse-lookupUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/comparatorUpgraded5.0.56.3.3CompareBSD-3-Clause
sebastian/complexityUpgraded3.2.04.0.1CompareBSD-3-Clause
sebastian/diffUpgraded5.1.16.0.2CompareBSD-3-Clause
sebastian/environmentUpgraded6.1.07.2.1CompareBSD-3-Clause
sebastian/exporterUpgraded5.1.46.3.2CompareBSD-3-Clause
sebastian/global-stateUpgraded6.0.27.0.2CompareBSD-3-Clause
sebastian/lines-of-codeUpgraded2.0.23.0.1CompareBSD-3-Clause
sebastian/object-enumeratorUpgraded5.0.06.0.1CompareBSD-3-Clause
sebastian/object-reflectorUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/recursion-contextUpgraded5.0.16.0.3CompareBSD-3-Clause
sebastian/typeUpgraded4.0.05.1.3CompareBSD-3-Clause
sebastian/versionUpgraded4.0.15.0.2CompareBSD-3-Clause
staabm/side-effects-detectorNew-1.0.5CompareMIT
symfony/filesystemUpgradedv6.4.24v7.4.8CompareMIT
symfony/stopwatchUpgradedv6.4.24v7.4.8CompareMIT
symfony/yamlUpgradedv6.4.21v7.4.8CompareMIT
szepeviktor/phpstan-wordpressUpgradedv1.3.5v2.0.3CompareMIT
symfony/polyfill-php73Removedv1.33.0-CompareMIT
symfony/polyfill-php84Removedv1.33.0-CompareMIT

@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 @rivanuff (feat): acorn 5.0 + php 8.2Aug 20, 2025
Comment thread.github/workflows/format-php.yml Outdated
Comment thread.github/workflows/phpstan.yml Outdated
@SimonvanWijhe

SimonvanWijhe commented Aug 25, 2025

Copy link
Copy Markdown
Member

#260

Comment threadsrc/helpers.php
->withMiddleware(function (Middleware $middleware) {
$middleware->append(AddCspHeaders::class);
})
->withRouting(wordpress: true)

@rivanuffrivanuffAug 30, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heb wat getest hiermee, wordpress: true zorgt er iig voor dat de CSP headers niet meer via brave-hooks dmv de send_headers hook moeten worden toegevoegd.

@dtakken

Copy link
Copy Markdown
Contributor

Bij deze even opletten dat deze commit er ook in verwerkt wordt: 5113678

CopilotAI review requested due to automatic review settings March 13, 2026 15:26
@rivanuff
rivanuff requested a review from a team as a code ownerMarch 13, 2026 15:26
@rivanuff
rivanuff requested review from ShunLuk and SimonvanWijhe and removed request for hnccox-yard and robertbossaertMarch 13, 2026 15:26

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this package to support Roots Acorn v5 and PHP 8.2, replacing the prior Acorn v4 bootloader customization approach with the new configuration/builder style used by Acorn 5.

Changes:

  • Upgrade platform/runtime requirements to PHP 8.2 and bump Acorn + dev tooling dependencies.
  • Rework bootloader() to use Application::configure() with exception + middleware configuration hooks.
  • Remove now-redundant custom Kernel/Handler/Vite wrapper classes and adjust view composer attachment logic.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
src/helpers.phpSwitch bootstrapping to Acorn 5 Application::configure() and configure bindings/exceptions/middleware.
src/View/ViewServiceProvider.phpSimplify composer config check when attaching view composers.
src/Http/Kernel.phpRemove custom HTTP kernel (CSP now configured via middleware hook).
src/Exceptions/Handler.phpRemove custom exception handler (Sentry now configured via exceptions hook).
src/Assets/Vite.phpRemove custom Vite wrapper class.
composer.jsonBump PHP + Acorn requirements and update dev tooling versions.
README.mdUpdate documented PHP requirement and bootloader usage example.
.github/workflows/phpstan.ymlYAML formatting/quoting update for PR path filters.
.github/workflows/format-php.ymlYAML formatting/quoting update for PR path filters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 15 to 17
/** @var array<Composer> */
$composers = $this->app->get('config')->get('view.composers', []);

Comment threadREADME.md
Comment threadsrc/helpers.php Outdated
@rivanuff
rivanuffforce-pushed the feat/acorn-5 branch 2 times, most recently from 72a8032 to 3290497CompareMarch 13, 2026 15:43
@rivanuff
rivanuff changed the base branch from main to feat/php8.2April 3, 2026 12:16
@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 (feat): acorn 5.0Apr 3, 2026
Base automatically changed from feat/php8.2 to mainApril 3, 2026 13:30
@ictbeheerictbeheer linked an issue Jun 15, 2026 that may be closed by this pull request
@ictbeheerictbeheer removed a link to an issue Jun 15, 2026
@rivanuffrivanuff closed this Sep 2, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@rivanuff@SimonvanWijhe@dtakken@ictbeheer@yard-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

(feat): acorn 5.0 - #22

Closed
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5
Closed

(feat): acorn 5.0#22
rivanuff wants to merge 15 commits into
mainfrom
feat/acorn-5

Conversation

@rivanuff

@rivanuffrivanuff commented Aug 20, 2025

Copy link
Copy Markdown

@rivanuff
rivanuff requested review from a team, Rovasch, SimonvanWijhe, YvetteNikolov, dtakken, hnccox-yard, ictbeheer, mvdhoek1 and robertbossaert and removed request for a teamAugust 20, 2025 13:18
@github-actions

github-actionsBot commented Aug 20, 2025

Copy link
Copy Markdown
Composer package changes
Prod PackagesOperationBaseTargetLinkLicense
brick/mathUpgraded0.12.30.14.8CompareMIT
carbonphp/carbon-doctrine-typesUpgraded2.1.03.2.0CompareMIT
dragonmantank/cron-expressionUpgradedv3.5.0v3.6.0CompareMIT
guzzlehttp/guzzleUpgraded7.9.37.10.0CompareMIT
guzzlehttp/promisesUpgraded2.2.02.3.0CompareMIT
laravel/frameworkUpgraded10.50.2v12.56.0CompareMIT
laravel/promptsUpgradedv0.1.25v0.3.16CompareMIT
laravel/serializable-closureUpgradedv1.3.7v2.0.10CompareMIT
league/uriNew-7.8.1CompareMIT
league/uri-interfacesNew-7.8.1CompareMIT
nesbot/carbonUpgraded2.73.03.11.3CompareMIT
nette/utilsUpgradedv4.0.10v4.1.3CompareBSD-3-Clause, GPL-2.0-only, GPL-3.0-only
nunomaduro/termwindUpgradedv1.17.0v2.4.0CompareMIT
roots/acornUpgradedv4.3.1v5.1.1CompareMIT
sentry/sentryUpgraded4.23.14.24.0CompareMIT
spatie/laravel-package-toolsUpgraded1.92.41.93.0CompareMIT
symfony/clockNew-v7.4.8CompareMIT
symfony/consoleUpgradedv6.4.35v7.4.8CompareMIT
symfony/css-selectorUpgradedv6.4.34v7.4.8CompareMIT
symfony/error-handlerUpgradedv6.4.32v7.4.8CompareMIT
symfony/event-dispatcherUpgradedv6.4.32v7.4.8CompareMIT
symfony/finderUpgradedv6.4.34v7.4.8CompareMIT
symfony/http-foundationUpgradedv6.4.35v7.4.8CompareMIT
symfony/http-kernelUpgradedv6.4.35v7.4.8CompareMIT
symfony/mailerUpgradedv6.4.34v7.4.8CompareMIT
symfony/mimeUpgradedv6.4.35v7.4.8CompareMIT
symfony/options-resolverUpgradedv6.4.30v7.4.8CompareMIT
symfony/polyfill-php84New-v1.33.0CompareMIT
symfony/polyfill-php85New-v1.33.0CompareMIT
symfony/processUpgradedv6.4.33v7.4.8CompareMIT
symfony/psr-http-message-bridgeUpgradedv6.4.32v7.4.8CompareMIT
symfony/routingUpgradedv6.4.34v7.4.8CompareMIT
symfony/stringUpgradedv6.4.34v7.4.8CompareMIT
symfony/translationUpgradedv6.4.34v7.4.8CompareMIT
symfony/uidUpgradedv6.4.32v7.4.8CompareMIT
symfony/var-dumperUpgradedv6.4.32v7.4.8CompareMIT
phpChanged>=8.1>=8.2
Dev PackagesOperationBaseTargetLinkLicense
filp/whoopsUpgraded2.18.32.18.4CompareMIT
friendsofphp/php-cs-fixerUpgradedv3.89.0v3.94.2CompareMIT
iamcal/sql-parserUpgradedv0.5v0.7CompareMIT
larastan/larastanUpgradedv2.11.2v3.9.3CompareMIT
laravel/pailNew-v1.2.6CompareMIT
laravel/tinkerUpgradedv2.10.1v2.11.1CompareMIT
nunomaduro/collisionUpgradedv7.12.0v8.9.2CompareMIT
orchestra/canvasUpgradedv8.12.0v10.2.0CompareMIT
orchestra/canvas-coreUpgradedv8.10.2v10.2.0CompareMIT
orchestra/sidekickUpgradedv1.2.12v1.2.20CompareMIT
orchestra/testbenchUpgradedv8.36.0v10.11.0CompareMIT
orchestra/testbench-coreUpgradedv8.38.0v10.12.1CompareMIT
orchestra/workbenchUpgradedv8.17.5v10.1.0CompareMIT
php-stubs/wordpress-stubsUpgradedv6.8.1v6.9.1CompareMIT
phpstan/phpstanUpgraded1.12.272.1.46MIT
phpunit/php-code-coverageUpgraded10.1.1611.0.12CompareBSD-3-Clause
phpunit/php-file-iteratorUpgraded4.1.05.1.1CompareBSD-3-Clause
phpunit/php-invokerUpgraded4.0.05.0.1CompareBSD-3-Clause
phpunit/php-text-templateUpgraded3.0.14.0.1CompareBSD-3-Clause
phpunit/php-timerUpgraded6.0.07.0.1CompareBSD-3-Clause
phpunit/phpunitUpgraded10.5.6311.5.55CompareBSD-3-Clause
psy/psyshUpgradedv0.12.19v0.12.22CompareMIT
react/child-processUpgradedv0.6.6v0.6.7CompareMIT
react/dnsUpgradedv1.13.0v1.14.0CompareMIT
react/event-loopUpgradedv1.5.0v1.6.0CompareMIT
react/socketUpgradedv1.16.0v1.17.0CompareMIT
sebastian/cli-parserUpgraded2.0.13.0.2CompareBSD-3-Clause
sebastian/code-unitUpgraded2.0.03.0.3CompareBSD-3-Clause
sebastian/code-unit-reverse-lookupUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/comparatorUpgraded5.0.56.3.3CompareBSD-3-Clause
sebastian/complexityUpgraded3.2.04.0.1CompareBSD-3-Clause
sebastian/diffUpgraded5.1.16.0.2CompareBSD-3-Clause
sebastian/environmentUpgraded6.1.07.2.1CompareBSD-3-Clause
sebastian/exporterUpgraded5.1.46.3.2CompareBSD-3-Clause
sebastian/global-stateUpgraded6.0.27.0.2CompareBSD-3-Clause
sebastian/lines-of-codeUpgraded2.0.23.0.1CompareBSD-3-Clause
sebastian/object-enumeratorUpgraded5.0.06.0.1CompareBSD-3-Clause
sebastian/object-reflectorUpgraded3.0.04.0.1CompareBSD-3-Clause
sebastian/recursion-contextUpgraded5.0.16.0.3CompareBSD-3-Clause
sebastian/typeUpgraded4.0.05.1.3CompareBSD-3-Clause
sebastian/versionUpgraded4.0.15.0.2CompareBSD-3-Clause
staabm/side-effects-detectorNew-1.0.5CompareMIT
symfony/filesystemUpgradedv6.4.24v7.4.8CompareMIT
symfony/stopwatchUpgradedv6.4.24v7.4.8CompareMIT
symfony/yamlUpgradedv6.4.21v7.4.8CompareMIT
szepeviktor/phpstan-wordpressUpgradedv1.3.5v2.0.3CompareMIT
symfony/polyfill-php73Removedv1.33.0-CompareMIT
symfony/polyfill-php84Removedv1.33.0-CompareMIT

@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 @rivanuff (feat): acorn 5.0 + php 8.2Aug 20, 2025
Comment thread.github/workflows/format-php.yml Outdated
Comment thread.github/workflows/phpstan.yml Outdated
@SimonvanWijhe

SimonvanWijhe commented Aug 25, 2025

Copy link
Copy Markdown
Member

#260

Comment threadsrc/helpers.php
->withMiddleware(function (Middleware $middleware) {
$middleware->append(AddCspHeaders::class);
})
->withRouting(wordpress: true)

@rivanuffrivanuffAug 30, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heb wat getest hiermee, wordpress: true zorgt er iig voor dat de CSP headers niet meer via brave-hooks dmv de send_headers hook moeten worden toegevoegd.

@dtakken

Copy link
Copy Markdown
Contributor

Bij deze even opletten dat deze commit er ook in verwerkt wordt: 5113678

CopilotAI review requested due to automatic review settings March 13, 2026 15:26
@rivanuff
rivanuff requested a review from a team as a code ownerMarch 13, 2026 15:26
@rivanuff
rivanuff requested review from ShunLuk and SimonvanWijhe and removed request for hnccox-yard and robertbossaertMarch 13, 2026 15:26

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this package to support Roots Acorn v5 and PHP 8.2, replacing the prior Acorn v4 bootloader customization approach with the new configuration/builder style used by Acorn 5.

Changes:

  • Upgrade platform/runtime requirements to PHP 8.2 and bump Acorn + dev tooling dependencies.
  • Rework bootloader() to use Application::configure() with exception + middleware configuration hooks.
  • Remove now-redundant custom Kernel/Handler/Vite wrapper classes and adjust view composer attachment logic.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
src/helpers.phpSwitch bootstrapping to Acorn 5 Application::configure() and configure bindings/exceptions/middleware.
src/View/ViewServiceProvider.phpSimplify composer config check when attaching view composers.
src/Http/Kernel.phpRemove custom HTTP kernel (CSP now configured via middleware hook).
src/Exceptions/Handler.phpRemove custom exception handler (Sentry now configured via exceptions hook).
src/Assets/Vite.phpRemove custom Vite wrapper class.
composer.jsonBump PHP + Acorn requirements and update dev tooling versions.
README.mdUpdate documented PHP requirement and bootloader usage example.
.github/workflows/phpstan.ymlYAML formatting/quoting update for PR path filters.
.github/workflows/format-php.ymlYAML formatting/quoting update for PR path filters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 15 to 17
/** @var array<Composer> */
$composers = $this->app->get('config')->get('view.composers', []);

Comment threadREADME.md
Comment threadsrc/helpers.php Outdated
@rivanuff
rivanuffforce-pushed the feat/acorn-5 branch 2 times, most recently from 72a8032 to 3290497CompareMarch 13, 2026 15:43
@rivanuff
rivanuff changed the base branch from main to feat/php8.2April 3, 2026 12:16
@rivanuffrivanuff changed the title (feat): acorn 5.0 + php 8.2 (feat): acorn 5.0Apr 3, 2026
Base automatically changed from feat/php8.2 to mainApril 3, 2026 13:30
@ictbeheerictbeheer linked an issue Jun 15, 2026 that may be closed by this pull request
@ictbeheerictbeheer removed a link to an issue Jun 15, 2026
@rivanuffrivanuff closed this Sep 2, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@rivanuff@SimonvanWijhe@dtakken@ictbeheer@yard-bot