Uh oh!
There was an error while loading. Please reload this page.
remove object base class, replace typing aliases - #885
Open
Khabib73 wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #885 +/- ##
==========================================
+ Coverage 82.33% 82.36% +0.02%
==========================================
Files 99 99 Lines 12750 12753 +3 Branches 1242 1250 +8 ==========================================
+ Hits 10498 10504 +6 + Misses 1798 1795 -3
Partials 454 454
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Khabib73
marked this pull request as draft
August 27, 2026 10:50
There was a problem hiding this comment.
Pull request overview
Modernizes legacy Python syntax for issue #884 without intended runtime changes.
Changes:
- Replaces
typingcollection aliases with built-in generics. - Removes redundant Python 2-era
objectinheritance.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
ydb/tracing.py | Modernizes tracing annotations. |
ydb/topic.py | Modernizes topic API annotations. |
ydb/table.py | Modernizes table classes and annotations. |
ydb/settings.py | Modernizes header annotation. |
ydb/scripting.py | Removes redundant object bases. |
ydb/scheme.py | Removes redundant object bases. |
ydb/resolver.py | Modernizes resolver classes. |
ydb/query/session.py | Modernizes explain return type. |
ydb/query/pool.py | Modernizes query pool return types. |
ydb/query/base.py | Modernizes callback storage annotation. |
ydb/pool.py | Modernizes pool annotations. |
ydb/observability/metrics.py | Modernizes metrics annotations. |
ydb/import_client.py | Removes redundant object base. |
ydb/export.py | Removes redundant object base. |
ydb/driver.py | Modernizes driver class and annotations. |
ydb/credentials.py | Removes redundant object base. |
ydb/connection.py | Modernizes connection classes and annotations. |
ydb/_utilities.py | Modernizes utility classes and annotations. |
ydb/_typing.py | Modernizes the RPC argument tuple alias. |
ydb/_tx_ctx_impl.py | Removes redundant object base. |
ydb/_sp_impl.py | Removes redundant object base. |
ydb/_session_impl.py | Removes redundant object bases. |
ydb/_apis.py | Modernizes service descriptor classes. |
Suppressed comments (2)
ydb/table.py:1501
- The matching public async method still declares
rename_itemsasList[Tuple[str, str]]atydb/aio/table.py:387-390. Please mirror this annotation cleanup in the async API so sync and async signatures remain aligned.
rename_items: list[tuple[str, str]],
ydb/query/pool.py:302
- The async
explain_with_retriescounterpart still returnsUnion[str, Dict[str, Any]]atydb/aio/query/pool.py:246-253. Please mirror this conversion in the async method so runtime annotations and the sync/async public APIs remain consistent.
) -> Union[str, dict[str, Any]]:
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1361
to
+1365
| add_columns: Optional[list["ydb.Column"]] = None, | ||
| drop_columns: Optional[list[str]] = None, | ||
| settings: Optional["settings_impl.BaseRequestSettings"] = None, | ||
| alter_attributes: Optional[Optional[Dict[str, str]]] = None, | ||
| add_indexes: Optional[List["ydb.TableIndex"]] = None, | ||
| drop_indexes: Optional[List[str]] = None, | ||
| alter_attributes: Optional[Optional[dict[str, str]]] = None, | ||
| add_indexes: Optional[list["ydb.TableIndex"]] = None, |
| def copy_tables( | ||
| self, | ||
| source_destination_pairs: List[Tuple[str, str]], | ||
| source_destination_pairs: list[tuple[str, str]], |
| *, | ||
| result_format: QueryExplainResultFormat = QueryExplainResultFormat.STR, | ||
| ) -> Union[str, Dict[str, Any]]: | ||
| ) -> Union[str, dict[str, Any]]: |
| pool_id: Optional[str] = None, | ||
| **kwargs, | ||
| ) -> List[convert.ResultSet]: | ||
| ) -> list[convert.ResultSet]: |
ContributorAuthor
Can you run copilot review again? |
vgvoleg
commented
Aug 27, 2026
Member
I'm ok with huge diff, let's do all refactoring in one PR |
ContributorAuthor
@vgvoleg How about replacing |
ContributorAuthor
Also, I think we should replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are not all the changes. I've kept it to the typing cleanup for now and will follow up with the rest separately. (to avoid making the diff too large)
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #884