Skip to content
This repository was archived by the owner on May 1, 2023. It is now read-only.

feat: trail of bits audit - #487

Merged
lehnberg merged 4 commits into
yearn:masterfrom
philburrrt:audit-update
Jul 27, 2021
Merged

feat: trail of bits audit#487
lehnberg merged 4 commits into
yearn:masterfrom
philburrrt:audit-update

Conversation

@philburrrt

Copy link
Copy Markdown
Contributor

No description provided.

@lehnberg

Copy link
Copy Markdown
Contributor

@philburrrt the audit is in the wrong section.

currently: under strategies audits

should be: under v2 vault audits

Separately, you might also want to consider using a table to host the audits. This way you could have a date column as well.

@lehnberglehnberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in PR

@philburrrt

Copy link
Copy Markdown
ContributorAuthor

@lehnberg moved to v2 vault audits. will add turning this into a table to my to-do list. thanks.

@lehnberglehnberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like Trail of Bits audit is still incorrectly under strategies.

Also noticed that liquity audit is under vaults, but probably should be under strategies.

@philburrrt

Copy link
Copy Markdown
ContributorAuthor

@lehnberg fixed, my apologies

@lehnberg
lehnberg merged commit 5f48055 into yearn:masterJul 27, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@philburrrt@lehnberg