Uh oh!
There was an error while loading. Please reload this page.
fix(code quality): Improve error for S3 upload in Batcher - #1014
Merged
entropidelic merged 2 commits intoSep 24, 2024
Conversation
MauroToscano
requested changes
Sep 19, 2024
MauroToscano
left a comment
Contributor
There was a problem hiding this comment.
How does this error get printed ? Also, maybe change S3BatchUploadError to BatchUploadError, since we are not using S3
MauroToscano
approved these changes
Sep 20, 2024
uri-99
approved these changes
Sep 24, 2024
entropidelic
deleted the
1011-improve-error-when-uploading-to-bucket
branch
September 24, 2024 20:35
This was referenced Sep 30, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the error for uploading batches to S3 in the batcher.
closes#1011