Skip to content

Fix EIP 712 - Data of the struct should be concatenated after type hash - #1054

Merged
entropidelic merged 6 commits into
stagingfrom
fix_eip_712_3
Sep 23, 2024
Merged

Fix EIP 712 - Data of the struct should be concatenated after type hash#1054
entropidelic merged 6 commits into
stagingfrom
fix_eip_712_3

Conversation

@MauroToscano

@MauroToscanoMauroToscano commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

Description

Change structHash using the EIP description

hashStruct(s : 𝕊) = keccak256(typeHash ‖ encodeData(s))

Also, do not perfom the keccak on the nonce and the maxFee

How to test

Send proofs as usual

Note

Remember to rebuild aligned using make install_aligned_compiling

How to deploy

This PR requires upgrading the BatcherPaymentService.sol

To upgrade you need to run

make upgrade_batcher_payment_service

Once you upgraded the contrat, you need to rebuild the batcher and the client

make install_batcher
make install_aligned_compiling

@github-actions

github-actionsBot commented Sep 23, 2024

Copy link
Copy Markdown

Changes to gas cost

Generated at commit: 8e7d46ce5cd305481d39745bb59db456f73425a8, compared to commit: 0d29b1aa3df0046e48f6889d7d5c10e25ec88e69

🧾 Summary (10% most significant diffs)

ContractMethodAvg (+/-)%
AlignedLayerServiceManagercreateNewTask+3 ❌+0.00%

Full diff report 👇
ContractDeployment Cost (+/-)MethodMin (+/-)%Avg (+/-)%Median (+/-)%Max (+/-)%# Calls (+/-)
AlignedLayerServiceManager4,629,415 (0)createNewTask53,895 (+72)+0.13%73,807 (+3)+0.00%73,969 (-12)-0.02%74,845 (+36)+0.05%256 (0)

@MauroToscanoMauroToscano changed the title Update EIP 7127Fix EIP 712 - Data of the struct should be concatenated after type hashSep 23, 2024
@entropidelic
entropidelic merged commit ace685c into stagingSep 23, 2024
@entropidelic
entropidelic deleted the fix_eip_712_3 branch September 23, 2024 17:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MauroToscano@JuArce@entropidelic