Uh oh!
There was an error while loading. Please reload this page.
feat: disable verifiers - #1090
Conversation
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
uri-99
left a comment
There was a problem hiding this comment.
still missing to review a couple of files
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: IAvecilla <ignacio.avecilla@lambdaclass.com> Co-authored-by: Mariano Nicolini <mariano.nicolini.91@gmail.com> Co-authored-by: Uriel Mihura <43704209+uri-99@users.noreply.github.com>
Changes
This pr introduces proving systems or verifiers blacklisting through a new bitmap field in the
ServiceManagercontract. The batcher and operator, before doing a verification, they make sure that the proving system is indeed whitelisted by callingisVerifierValidfunction in theServiceManagercontract.It also includes the verification for disabled verifiers in the operators and the batcher logic. For the batcher it will now check for every new block if the disabled verifiers have changed, in the afirmative case it checks all the proofs inside the batcher queue and remove all of them indistinctly if it was a proof using the disabled verifier or not.
Test
You can test this following these steps:
make batcher_send_burst_groth16just to keep generating new proofs and avoid problems trying to submit repeated batches.disableVerifier(uint8). TheVERIFIER_ID=3variable will disable the SP1 verifier:make batcher_send_sp1_task.make batcher_send_sp1_task.If you want to try and disable all the other verifiers run the same command mentioned above changing the
VERIFIER_IDthat is the ID corresponding to the
ProvingSystemIdenum in theproving_systems.gofile, beingGnarkPlonkBls12_381the id 0.Disabled verifiers in the batch queue testing
Start the Aligned components (anvil, aggregator, and operator).
Open the batcher's configuration file at
config-files/config-batcher.yamland adjust the following parameters:Run the batcher:
make batcher_start_localSend 3 proofs using any of the verifiers:
make batcher_send_sp1_taskmake batcher_send_risc0_taskmake batcher_send_groth16_bn254_taskDisable the SP1 verifier:
make verifier_disable_devnet VERIFIER_ID=3Verify that all the clients stop and encounter an
BatchReseterror. The batcher's queue should now be empty.This closes#1082