Uh oh!
There was an error while loading. Please reload this page.
Conversation
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
PatStiles
approved these changes
Sep 27, 2024
JuArce
requested changes
Sep 27, 2024
Uh oh!
There was an error while loading. Please reload this page.
uri-99
suggested changes
Sep 27, 2024
Contributor
There was a problem hiding this comment.
Every time any contract changes, we should push the new anvil-state to make sure we can simply run make anvil_start on a branch and know we are dealing with the current branch's contracts.
For this, you must push the .json file generated when running make anvil_deploy_aligned_contracts
The rest seems OK
IAvecilla
approved these changes
Sep 27, 2024
uri-99
approved these changes
Sep 27, 2024
PatStiles
approved these changes
Sep 27, 2024
MarcosNicolauforce-pushed
the
1020-fixcontracts-batcherpaymentservice-contract-does-not-check-that-an-address-is-not-equal-to-address0-during-constructor-or-initialization
branch
from
September 30, 2024 12:39
3bac7b4 to
e2730eeCompareMarcosNicolauforce-pushed
the
1020-fixcontracts-batcherpaymentservice-contract-does-not-check-that-an-address-is-not-equal-to-address0-during-constructor-or-initialization
branch
from
September 30, 2024 12:54
c8abcff to
d081866Compare…ontract-does-not-check-that-an-address-is-not-equal-to-address0-during-constructor-or-initialization
JuArce
approved these changes
Sep 30, 2024
JuArce
deleted the
1020-fixcontracts-batcherpaymentservice-contract-does-not-check-that-an-address-is-not-equal-to-address0-during-constructor-or-initialization
branch
September 30, 2024 19:52
Closed
PatStiles pushed a commit
that referenced
this pull request
Oct 1, 2024
Co-authored-by: Urix <43704209+uri-99@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This pr adds checks to make sure addresses are not zero while initializing the contracts.
Solves audit from fuzzing-labs.
Closes#1020
Closes#1002
Closes#1109