Skip to content

feat(telemetry): modify the aggregator to use the elixir Tracker - #1105

Merged
JuArce merged 9 commits into
1075-feattelemetry-implement-telemetry-for-aggregatorfrom
modify-aggregator-to-use-tracker
Oct 1, 2024
Merged

feat(telemetry): modify the aggregator to use the elixir Tracker#1105
JuArce merged 9 commits into
1075-feattelemetry-implement-telemetry-for-aggregatorfrom
modify-aggregator-to-use-tracker

Conversation

@avilagaston9

@avilagaston9avilagaston9 commented Sep 26, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

This PR introduces the basic structure for telemetry implementation in the aggregator.

Description

  • Creates the Telemetry struct with the following methods:
    • InitTaskTrace()
    • LogOperatorResponse()
    • LogQuorumReached()
    • LogTaskError()
    • FinishTaskTrace()
  • Each method sends an HTTP POST request to the new Elixir Tracker.
  • Integrates the Telemetry struct into the Aggregator and invokes its methods as needed.
  • This PR also implements the missing endpoints in the Elixir Tracker.
image

@avilagaston9
avilagaston9 marked this pull request as ready for review September 26, 2024 21:37
@avilagaston9avilagaston9 self-assigned this Sep 27, 2024
@avilagaston9
avilagaston9 marked this pull request as draft September 27, 2024 12:29
JuArce
JuArce requested changes Sep 30, 2024
View reviewed changes
Comment threadaggregator/internal/pkg/aggregator.go Outdated
Comment threadaggregator/internal/pkg/server.go Outdated
Comment threadtelemetry_api/lib/telemetry_api/traces.ex Outdated
@avilagaston9
avilagaston9 marked this pull request as ready for review September 30, 2024 14:55
JuArce
JuArce requested changes Oct 1, 2024
View reviewed changes
Comment threadaggregator/internal/pkg/aggregator.go
JulianVentura
JulianVentura reviewed Oct 1, 2024
View reviewed changes
Comment threadaggregator/internal/pkg/aggregator.go
Comment threadaggregator/internal/pkg/telemetry.go
@JuArce
JuArce merged commit c796740 into 1075-feattelemetry-implement-telemetry-for-aggregatorOct 1, 2024
@JuArce
JuArce deleted the modify-aggregator-to-use-tracker branch October 1, 2024 16:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuArceJuArceJuArce approved these changes
+1 more reviewer
@JulianVenturaJulianVenturaJulianVentura left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@avilagaston9avilagaston9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@avilagaston9@JulianVentura@JuArce