Uh oh!
There was an error while loading. Please reload this page.
refactor(contracts): remove merkle root and signature checks on payment service contract - #1114
Conversation
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
uri-99
left a comment
There was a problem hiding this comment.
We can still remove the usage of nonce and maxFee from the contracts to make it cheaper, ProofSubmitterData can be only the address
I addressed your comments. I also updated the gas usage results. |
…ecks-on-payment-service-contract
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
entropidelic
commented
Oct 8, 2024
@uri-99 I updated the docs in docs/2_architecture/components/2_payment_service_contract.md |
Changes
Remove the merkle root and signature checks to save on gas in the payment service contract.
Gas changes
Here is the gas diff between validating the merkle root and signature and not doing it:
For a more complete report see the google sheet here.
The report can be reproduced in the following way:
014bd4d7d64be442c24a8235fda4700bd225a69fto run with the checks:BURST_SIZE=10 make batcher_send_sp1_burstmake batcher_send_burst_groth16: Here you'll have to wait as it sends proofs non-stop.BURST_SIZE=100 make batcher_send_risc0_burstBURST_SIZE=1000 make batcher_send_risc0_burst: Here the max proofs per batch will be around300-380, but it is difficult to get the same number in both executions.Results may vary between executions but should be around the same on average.
Closes#1119
Edit: the table was update to the commit where all the checks are removed, not only the merkle and signature.