Skip to content

chore: Add explorer_create_env makefile target and update error messages. - #1121

Merged
uri-99 merged 2 commits into
stagingfrom
chore/explorer-create-env
Oct 7, 2024
Merged

chore: Add explorer_create_env makefile target and update error messages.#1121
uri-99 merged 2 commits into
stagingfrom
chore/explorer-create-env

Conversation

@JulianVentura

@JulianVenturaJulianVentura commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

Description

  • Added new makefile target explorer_create_env which creates a new .env based on .env.dev
  • Updated error messages to reflect changes

Closes#966

@JulianVentura
JulianVentura changed the base branch from testnet to stagingSeptember 30, 2024 20:43
@github-actions

github-actionsBot commented Sep 30, 2024

Copy link
Copy Markdown

Changes to gas cost

Generated at commit: 0f01a89f765c9da467232fe75bac8bc8a33649a0, compared to commit: 0f535bef99c157e450dba7006d25330afb6f35e7

🧾 Summary (10% most significant diffs)

ContractMethodAvg (+/-)%
AlignedLayerServiceManagercreateNewTask-322 ✅-0.44%
Full diff report 👇
ContractDeployment Cost (+/-)MethodMin (+/-)%Avg (+/-)%Median (+/-)%Max (+/-)%# Calls (+/-)
AlignedLayerServiceManager4,681,797 (+52,382)createNewTask
receive		53,823 (0)
21,169 (0)		0.00%
0.00%		73,567 (-322)
44,503 (-374)		-0.44%
-0.83%		73,969 (-18)
45,064 (0)		-0.02%
0.00%		74,845 (+111)
45,064 (0)		+0.15%
0.00%		256 (0)
256 (0)
RegistryCoordinatorHarness5,846,016 (+17,263)

@JulianVentura
JulianVentura marked this pull request as ready for review September 30, 2024 20:54
uri-99
uri-99 suggested changes Oct 2, 2024
View reviewed changes
Comment threadexplorer/lib/explorer/contract_managers/aligned_layer_service_manager.ex Outdated
Comment threadexplorer/lib/explorer/contract_managers/batcher_payment_service_manager.ex Outdated
Comment threadexplorer/lib/explorer/contract_managers/avs_directory_manager.ex
@uri-99
uri-99 merged commit 0d57e3c into stagingOct 7, 2024
@uri-99
uri-99 deleted the chore/explorer-create-env branch October 7, 2024 14:09
PatStiles pushed a commit that referenced this pull request Oct 7, 2024
@JulianVenturaJulian Ventura@PatStiles
chore: Add explorer_create_env makefile target and update error mes…
3be673b
…sages. (#1121)
Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
@OppenOppen mentioned this pull request Oct 10, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@OppenOppenOppen approved these changes
@uri-99uri-99uri-99 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Explorer: If you don't have the local env, it suggests running make create-env which doesn-t exist

3 participants

@JulianVentura@Oppen@uri-99