Skip to content

chore: rm halo2 from verifiers - #1128

Merged
uri-99 merged 3 commits into
stagingfrom
1117-remove-halo2-bindings
Oct 3, 2024
Merged

chore: rm halo2 from verifiers#1128
uri-99 merged 3 commits into
stagingfrom
1117-remove-halo2-bindings

Conversation

@PatStiles

Copy link
Copy Markdown
Contributor

Removes halo2 verifiers from aligned.

closes#1117 .

To Test:

  • Run a local testnet and verify that everything works.

@PatStilesPatStiles changed the title chore(rm halo2 from memory... foreverchore: rm halo2 from verifiersSep 30, 2024
@PatStilesPatStiles self-assigned this Sep 30, 2024

@MarcosNicolauMarcosNicolau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on my machine!

@uri-99

Copy link
Copy Markdown
Contributor

why are there still instances of halo2 in the cargo.locks? I can't seem to be able to remove them properly

@uri-99
uri-99 merged commit 8a6340f into stagingOct 3, 2024
@uri-99
uri-99 deleted the 1117-remove-halo2-bindings branch October 3, 2024 20:55
PatStiles added a commit that referenced this pull request Oct 7, 2024
Co-authored-by: Urix <43704209+uri-99@users.noreply.github.com>
@OppenOppen mentioned this pull request Oct 10, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@PatStiles@uri-99@MauroToscano@MarcosNicolau