Uh oh!
There was an error while loading. Please reload this page.
feat(sdk): Add Max Fee Estimate. Update zkQuiz to better represent how the SDK should be used - #1131
Merged
Merged
Conversation
PatStiles
requested review from
IAvecilla, MauroToscano and uri-99
and removed request for
IAvecilla, MauroToscano and uri-99October 1, 2024 16:38
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
uri-99
reviewed
Oct 1, 2024
Uh oh!
There was an error while loading. Please reload this page.
uri-99
reviewed
Oct 1, 2024
Uh oh!
There was an error while loading. Please reload this page.
uri-99
approved these changes
Oct 1, 2024
MarcosNicolau
approved these changes
Oct 2, 2024
MarcosNicolau
left a comment
Collaborator
There was a problem hiding this comment.
Tested on my machine, everything went fine!
PatStiles added a commit
that referenced
this pull request
Oct 3, 2024
…w the SDK should be used (#1131) Co-authored-by: MauroFab <maurotoscano2@gmail.com> Co-authored-by: Mariano Nicolini <mariano.nicolini.91@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopens #1045 due to merge issues.
To Test
cd batcher && cargo tTo test zkQuiz example in Devnet
cd examples/zkquiz.envfile located inexamples/zkquiz/contracts:zkquizfolder. Note that this will output the deployed contract address. Make sure to save itMakefileenvironment variables to the following:examples/zkquiz/quiz/script/src/main.rs:Line 21:
Line 24:
Line 34:
default_value = "http://localhost:8545"Line 53:
HELP: Answers are C C A