Skip to content

refactor: zkquiz setup and testing locally/devnet - #1153

Merged
entropidelic merged 21 commits into
stagingfrom
refactor-zk-quiz-testing
Oct 8, 2024
Merged

refactor: zkquiz setup and testing locally/devnet#1153
entropidelic merged 21 commits into
stagingfrom
refactor-zk-quiz-testing

Conversation

@MarcosNicolau

Copy link
Copy Markdown
Collaborator

Changes
This pr refactors zkquiz example so that testing it locally becomes easier.

Testing
To test this, you can follow this guide.

@MarcosNicolauMarcosNicolau self-assigned this Oct 2, 2024

@uri-99uri-99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, currently batches must be at least size 2. If you only send this proof, the batch will not be finalized by the batcher. If it is a local devnet example, you could send this proof twice to make the batch finalize, or clarify that the user must in parallel send another proof (such as make batcher_send_risc0_burst)

Comment threadexamples/zkquiz/quiz/script/src/main.rs Outdated
Comment threadexamples/zkquiz/quiz/script/src/main.rs Outdated
Comment threadexamples/zkquiz/quiz/script/src/main.rs Outdated
@MarcosNicolau
MarcosNicolauforce-pushed the refactor-zk-quiz-testing branch from ebd81ae to 5242061CompareOctober 4, 2024 16:00
Comment threadexamples/zkquiz/README.md Outdated
@entropidelic

Copy link
Copy Markdown
Contributor

left a small comment on the readme, but aside from that it looks good!

@uri-99uri-99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sending only 1 proof doesn't work

@uri-99uri-99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@entropidelic
entropidelic merged commit 54cabea into stagingOct 8, 2024
@entropidelic
entropidelic deleted the refactor-zk-quiz-testing branch October 8, 2024 15:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcosNicolau@entropidelic@uri-99