Uh oh!
There was an error while loading. Please reload this page.
fix: operator commands - #1184
Merged
uri-99 merged 2 commits intoOct 8, 2024
Merged
Conversation
MarcosNicolau
marked this pull request as ready for review
October 4, 2024 22:37
MarcosNicolauforce-pushed
the
1182-fix-make-operator_register_and_start-on-linux
branch
from
October 4, 2024 23:07
c407365 to
29741f0CompareMarcosNicolauforce-pushed
the
1182-fix-make-operator_register_and_start-on-linux
branch
from
October 5, 2024 18:15
856c657 to
5153d58Compareuri-99
approved these changes
Oct 7, 2024
Oppen
reviewed
Oct 7, 2024
Uh oh!
There was an error while loading. Please reload this page.
Oppen
approved these changes
Oct 8, 2024
Oppen
left a comment
Contributor
There was a problem hiding this comment.
As discussed offline, the issue with using #!/bin/bash would be the same for MacOS as with using SHELL := /bin/bash, so we'll keep the latter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes operator commands on linux.
Test
To test these commands now work, run the following commands on a linux machine:
make anvil_start_with_block_timemake aggregator_startmake build_operatormake operator_register_and_startmake batcher_start_localmake batcher_send_burst_groth16You should be able to run this without any issues.
Closes#1182