Uh oh!
There was an error while loading. Please reload this page.
Operator: Bump SP1 and Risc0 version + Retro-Compatible Operator - #1208
Operator: Bump SP1 and Risc0 version + Retro-Compatible Operator#1208PatStiles wants to merge 37 commits into
Conversation
MarcosNicolau
left a comment
There was a problem hiding this comment.
Tested on my machine.
Oppen
left a comment
There was a problem hiding this comment.
Looks OK, will test later today.
uri-99
left a comment
There was a problem hiding this comment.
Operators should have retrocompatibility. So we should have 2 ffis and each operator check with both
uri-99
left a comment
There was a problem hiding this comment.
We don't need to push old proof generators. To test we can checkout previous branch. I would avoid pushing this because this pr is 87 files, and a very big portion of these are the old proof generators
Uh oh!
There was an error while loading. Please reload this page.
| @mv scripts/test_files/sp1/fibonacci_proof_generator/program/elf/riscv32im-succinct-zkvm-elf scripts/test_files/sp1/sp1_fibonacci.elf | ||
| @mv scripts/test_files/sp1/fibonacci_proof_generator/script/sp1_fibonacci.proof scripts/test_files/sp1/ |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| use risc0_zkvm::{InnerReceipt, Receipt}; | ||
| #[no_mangle] | ||
| pub extern "C" fn verify_risc_zero_receipt_old_ffi( |
There was a problem hiding this comment.
You should add the try-catch.
There was a problem hiding this comment.
If it is too much work now, maybe don't.
| } | ||
| #[no_mangle] | ||
| pub extern "C" fn verify_sp1_proof_old_ffi( |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
I think you uploaded this by err.
PatStiles
commented
Oct 22, 2024
@MarcosNicolau@uri-99 I am closing this in favor or #1307 due to merge issues |

closes#1205
This PR:
risc0andsp1verifier versions of operators.dialoguer->inquireto accomodate a dependency conflict.To Test:
Verify network bindings works on a local network:
make test_risc_zero_go_bindings_macosmake test_sp1_go_bindings_macosmake batcher_send_risc0_taskmake batcher_send_sp1_taskcd examples/zkquiz/quiz/script && cargo run -rcd examples/validating-public-input/risc_zero/fibonacci_proof_generator && cargo run -rVerify Retro Compatiblility of Operator Verifiers:
To verify operator retro-compatibility we deploy the rest of infrastructure of Aligned and boot the retro-compatible operator. This tests that network retro-compatible operator can verify SP1/Risc0 proofs from both verifier versions.
Note:
Commands suffixed with
_oldindicate the deprecated version of the SP1/Risc0 verifier that is currently running ontestnetTo test this have two repos of aligned_layer one set to
testnetand one to1205-bump-sp1-and-risc0-version.In
testnetrepo:In
1205-bump-sp1-and-risc0-versionrepo:testnetrepo.Observe the
Risc0 proof verification failed.andSP1 proof verification failed.logs are emitted and the operator successfully verifying the proofs from the old SP1/Risc0 verifiers. If you send a proof from the latest version of SP1/Risc0 you should notice its verification fails in the batcher.1205-bump-sp1-and-risc0-versionrepo.testnetrepo, kill the batcher.1205-bump-sp1-and-risc0-versionand start the batcher within the repo.1205-bump-sp1-and-risc0-versionrepo.Observe the operator successfully verifying the proofs from the new SP1/Risc0 verifiers. If you send a proof from the older version of SP1/Risc0 you should notice its verification fails in the batcher.