Skip to content

feat(explorer): add is_valid field to batches - #1212

Merged
uri-99 merged 9 commits into
1016-fixexplorer-fetch_batch_data_pointer-in-explorer-reads-the-entire-response-body-without-any-limitationfrom
mark-invalid-batches
Oct 14, 2024
Merged

feat(explorer): add is_valid field to batches#1212
uri-99 merged 9 commits into
1016-fixexplorer-fetch_batch_data_pointer-in-explorer-reads-the-entire-response-body-without-any-limitationfrom
mark-invalid-batches

Conversation

@avilagaston9

@avilagaston9avilagaston9 commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

Motivation

This PR adds a new status, Invalid, to the batcher in the explorer.

Description

  • Adds is_valid field to the %Batcher{} and %BatchDB{} structs.
  • Updates their respective schemas to include this field.
  • Creates a migration to add the field to the db.
  • Adds the new status to the frontend.

@avilagaston9avilagaston9 self-assigned this Oct 12, 2024
@avilagaston9
avilagaston9 marked this pull request as ready for review October 14, 2024 13:27

@uri-99uri-99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comment and approved

@uri-99
uri-99 merged commit 7e4c8c8 into 1016-fixexplorer-fetch_batch_data_pointer-in-explorer-reads-the-entire-response-body-without-any-limitationOct 14, 2024
@uri-99
uri-99 deleted the mark-invalid-batches branch October 14, 2024 18:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@avilagaston9@uri-99@entropidelic