Uh oh!
There was an error while loading. Please reload this page.
refactor: avoid lazy init for batcher metrics - #1236
Merged
Conversation
Oppen
approved these changes
Oct 14, 2024
Oppen
reviewed
Oct 14, 2024
Oppen
left a comment
Contributor
There was a problem hiding this comment.
Will test later today. Looks good.
uri-99
suggested changes
Oct 15, 2024
Uh oh!
There was an error while loading. Please reload this page.
PatStiles
approved these changes
Oct 15, 2024
Uh oh!
There was an error while loading. Please reload this page.
MarcosNicolau
approved these changes
Oct 15, 2024
MarcosNicolau
left a comment
Collaborator
There was a problem hiding this comment.
Works on my machine!
uri-99
approved these changes
Oct 15, 2024
entropidelic
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially, we implemented a minimal solution to get the job done, but we ended up using
LazyStaticwithout a clear purpose. We initialize all the metric variables anyway, as we need them from the start. These changes ensure that the metrics are available right from the beginning, and they are now incorporated as a new component of the batcher. Additionally, the port used to expose metrics is now part of the batcher's configuration.