Skip to content

feat: broken sockets metric in batcher - #1255

Merged
uri-99 merged 22 commits into
stagingfrom
1241-measure-broken-websocketserrors-with-prometheus-when-sending-responses-in-batcher
Oct 18, 2024
Merged

feat: broken sockets metric in batcher#1255
uri-99 merged 22 commits into
stagingfrom
1241-measure-broken-websocketserrors-with-prometheus-when-sending-responses-in-batcher

Conversation

@MarcosNicolau

@MarcosNicolauMarcosNicolau commented Oct 14, 2024•
edited
Loading

Copy link
Copy Markdown
Collaborator

Changes
Adds metrics for the broken sockets when sending responses in the batcher.

Testing
Set up a local testnet as usual, and:

  • Run metrics: make run_metrics
  • Start sending proofs and stop the execution.
  • Go to localhost:3000 and you should see a new module: Broken sockets

Closes#1241

@MarcosNicolauMarcosNicolau self-assigned this Oct 15, 2024
@MarcosNicolau
MarcosNicolau marked this pull request as ready for review October 15, 2024 15:09
@MarcosNicolau
Merge branch 'staging' into 1241-measure-broken-websocketserrors-with…
309039a
…-prometheus-when-sending-responses-in-batcher
MarcosNicolau
MarcosNicolau commented Oct 15, 2024
View reviewed changes
Comment threadbatcher/aligned-batcher/src/connection.rs Outdated
@MarcosNicolauMarcosNicolau linked an issue Oct 15, 2024 that may be closed by this pull request
Measure broken websockets/errors with Prometheus when sending responses in Batcher #1241
Closed
@MarcosNicolauMarcosNicolau mentioned this pull request Oct 15, 2024
Closed
avilagaston9
avilagaston9 reviewed Oct 15, 2024
View reviewed changes
Comment threadbatcher/aligned-batcher/src/connection.rs Outdated
entropidelic
entropidelic reviewed Oct 16, 2024
View reviewed changes
Comment threadbatcher/aligned-batcher/src/connection.rs Outdated
IAvecilla
IAvecilla reviewed Oct 16, 2024
View reviewed changes
Comment threadgrafana/provisioning/dashboards/aligned/aggregator_batcher.json Outdated
Comment threadbatcher/aligned-batcher/src/lib.rs Outdated
uri-99
uri-99 suggested changes Oct 17, 2024
View reviewed changes
Comment threadbatcher/aligned-batcher/src/metrics.rs Outdated
@uri-99
uri-99 merged commit 468fed9 into stagingOct 18, 2024
@uri-99
uri-99 deleted the 1241-measure-broken-websocketserrors-with-prometheus-when-sending-responses-in-batcher branch October 18, 2024 21:02
PatStiles pushed a commit that referenced this pull request Nov 6, 2024
@MarcosNicolau@JuArce
@entropidelic@PatStiles
feat: broken sockets metric in batcher (#1255)
0cd1db8
Co-authored-by: Julian Arce <52429267+JuArce@users.noreply.github.com>
Co-authored-by: Mariano Nicolini <mariano.nicolini.91@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avilagaston9avilagaston9Awaiting requested review from avilagaston9
3 more reviewers
@IAvecillaIAvecillaIAvecilla left review comments
@uri-99uri-99uri-99 approved these changes
@entropidelicentropidelicentropidelic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@MarcosNicolauMarcosNicolau

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Measure broken websockets/errors with Prometheus when sending responses in Batcher

6 participants

@MarcosNicolau@uri-99@IAvecilla@entropidelic@avilagaston9@JuArce