Skip to content

fix(audit): timeouts for metrics server to avoid DoS attacks#1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IAvecilla merged 1 commit into from
Oct 18, 2024
+17 −5
Merged

fix(audit): timeouts for metrics server to avoid DoS attacks #1277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions metrics/metrics.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import (
"context"
"errors"
"net/http"
"time"

"github.com/Layr-Labs/eigensdk-go/logging"
"github.com/prometheus/client_golang/prometheus"
Expand DownExpand Up@@ -48,12 +49,23 @@ func NewMetrics(ipPortAddress string, reg prometheus.Registerer, logger logging.
func (m *Metrics) Start(ctx context.Context, reg prometheus.Gatherer) <-chan error {
m.logger.Infof("Starting metrics server at port %v", m.ipPortAddress)
errC := make(chan error, 1)

server := http.Server{
Addr: m.ipPortAddress,
Handler: http.NewServeMux(),
ReadTimeout: 10 * time.Second,
WriteTimeout: 10 * time.Second,
IdleTimeout: 120 * time.Second,
MaxHeaderBytes: 1 << 20, // This is 1MB
}

server.Handler.(*http.ServeMux).Handle("/metrics", promhttp.HandlerFor(
reg,
promhttp.HandlerOpts{},
))

go func() {
http.Handle("/metrics", promhttp.HandlerFor(
reg,
promhttp.HandlerOpts{},
))
err := http.ListenAndServe(m.ipPortAddress, nil)
err := server.ListenAndServe()
if err != nil {
errC <- errors.New("prometheus server failed")
} else {
Expand Down