Uh oh!
There was an error while loading. Please reload this page.
infra: add watchdog for batcher - #1311
Merged
Merged
Conversation
Oppen
reviewed
Oct 23, 2024
| @@ -0,0 +1,36 @@ | |||
| # Batcher Watchdog | |||
| The Batcher Watchdog checks a prometheus metric and restart the batcher as needed | |||
Contributor
There was a problem hiding this comment.
A bit more detail would be appreciated. Which metric is checked? How often is it checked? What does "as needed" mean? I know the answers because we sit close to each other, but someone in the future will not know this.
Oppen
reviewed
Oct 23, 2024
Uh oh!
There was an error while loading. Please reload this page.
Oppen
reviewed
Oct 23, 2024
Uh oh!
There was an error while loading. Please reload this page.
Oppen
commented
Oct 23, 2024
Contributor
Seems OK overall. |
Oppen
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batcher Watchdog
Description
This PR adds a watchdog that restart the batcher if it gets stuck trying to send a transaction to ethereum