Uh oh!
There was an error while loading. Please reload this page.
feat(batcher): Update SP1 and Risc0 version in batcher, examples, and docs - #1329
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Marcos Nicolau <marcosnicolau@lambdaclass.com>
PatStilesforce-pushed
the
1205-update-batcher-examples-docs
branch
from
October 25, 2024 22:33
19fe6b6 to
cc51dc0CompareMauroToscano
requested changes
Oct 28, 2024
MauroToscano
left a comment
Contributor
There was a problem hiding this comment.
It's approved, but don't merge until operators upgrade
JuArce
approved these changes
Oct 28, 2024
Collaborator
There was a problem hiding this comment.
Cases tested in stage:
Operator version: v0.10.2
- Send old proofs with the old batcher: It is the previous version, and it works. The operator logs that it is using old version of the prover ✅
- Send new proofs with the old batcher: The batcher rejects the proofs ✅
- Send new proofs with the new batcher. The operator uses the new version of the provers ✅
MarcosNicolau
approved these changes
Nov 4, 2024
MarcosNicolau
left a comment
Collaborator
There was a problem hiding this comment.
Worked as expected on Linux and macos!
Oppen
commented
Nov 4, 2024
Contributor
Updates on this? |
uri-99
commented
Nov 6, 2024
Contributor
Still waiting , aprox 24hs and we eject unupgraded operators. |
MauroToscano
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Batcher SP1 and Risc0 version
Description
Complements #1324
Updates the SP1 and Risc0 version in the:
Renames the test files for SP1 and Risc0 by changing the respective suffix to point towards the correct version ("" indicates removal of the suffix):
"_new" -> ""
"" -> "-> old
NOTE: Removal of the old verifier ffi bindings will occur in a third pr.
Type of change