Skip to content

fix: update anvil state and version - #1341

Merged
JuArce merged 6 commits into
testnetfrom
fix-anvil-state
Oct 30, 2024
Merged

fix: update anvil state and version#1341
JuArce merged 6 commits into
testnetfrom
fix-anvil-state

Conversation

@samoht9277

@samoht9277samoht9277 commented Oct 29, 2024

Copy link
Copy Markdown
Collaborator

Fixes broken anvil state

Description

This minor PR fixes the deployed anvil states which broke the CI

contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json
contracts/scripts/anvil/state/eigenlayer-deployed-anvil-state.json

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@github-actions

github-actionsBot commented Oct 29, 2024

Copy link
Copy Markdown

Changes to gas cost

Generated at commit: 4f4d76a9ecdfc72b47ed774414d3ddf818779f33, compared to commit: 0f535bef99c157e450dba7006d25330afb6f35e7

🧾 Summary (10% most significant diffs)

ContractMethodAvg (+/-)%
AlignedLayerServiceManagerbatchesState
createNewTask
-22 ✅
+104 ❌
-3.13%
+0.14%

Full diff report 👇
ContractDeployment Cost (+/-)MethodMin (+/-)%Avg (+/-)%Median (+/-)%Max (+/-)%# Calls (+/-)
AlignedLayerServiceManager4,771,213 (+141,798)batchesState
createNewTask
681 (-22)
53,983 (+160)
-3.13%
+0.30%
681 (-22)
73,993 (+104)
-3.13%
+0.14%
681 (-22)
74,087 (+100)
-3.13%
+0.14%
681 (-22)
74,957 (+223)
-3.13%
+0.30%
256 (0)
256 (0)
TransparentUpgradeableProxy573,006 (+12)
BLSApkRegistryHarness1,837,613 (+12)
RegistryCoordinatorHarness5,846,028 (+17,275)

@samoht9277samoht9277 changed the title Fix anvil statefix: anvil stateOct 29, 2024

@uri-99uri-99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI seems to pass correctly

@Oppen

Copy link
Copy Markdown
Contributor

The CI seems stuck waiting for the runner.

@uri-99uri-99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP discussing if this change is necesarry

@uri-99uri-99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new foundry version breaks old anvil states, this anvil_state regeneration is needed

@samoht9277samoht9277 changed the title fix: anvil statefix: update anvil state and versionOct 29, 2024
@JuArce
JuArce merged commit 7ff5f30 into testnetOct 30, 2024
@JuArce
JuArce deleted the fix-anvil-state branch October 30, 2024 14:24
PatStiles pushed a commit that referenced this pull request Nov 6, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@samoht9277@Oppen@uri-99@IAvecilla@JuArce