Uh oh!
There was an error while loading. Please reload this page.
Conversation
timeToExpiry task to config fileMauroToscano
approved these changes
Nov 11, 2024
JuArce
commented
Nov 11, 2024
Collaborator
Just a note. If we set a time too high for the task expiration (bls_service_task_timeout: 168h), we won't see the trace in the telemetry service until the task is expired because the trace is not closed |
JuArce
approved these changes
Nov 11, 2024
JuArce
deleted the
1207-chore-change-timetoexpiry-parameter-passed-to-blsaggregationserviceinitializenewtask
branch
November 11, 2024 18:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr moves the
timeToExpirytime set when Initializing a new task in the aggregator to the config file and sets it to a week by default.Testing
Type of change
Checklist
timeToExpiryparameter passed toblsAggregationService.InitializeNewTask#1207