Skip to content

docs: improve multisig upgrade tutorial - #1429

Merged
MauroToscano merged 49 commits into
stagingfrom
1421-docs-improve-multisig-upgrade-tutorial
Nov 26, 2024
Merged

docs: improve multisig upgrade tutorial#1429
MauroToscano merged 49 commits into
stagingfrom
1421-docs-improve-multisig-upgrade-tutorial

Conversation

@JuArce

@JuArceJuArce commented Nov 15, 2024•
edited
Loading

Copy link
Copy Markdown
Collaborator

Improve multisig upgrade tutorial

Description

This PR improves the deploy, upgrade and multisig approves tutorials

All the docs are in docs/0_internal

@JuArceJuArce self-assigned this Nov 15, 2024
@github-actions

github-actionsBot commented Nov 19, 2024•
edited
Loading

Copy link
Copy Markdown

Changes to gas cost

Generated at commit: e67f2cffe079ea514a9340972858a708edc2b426, compared to commit: fecac6f71e5a46592806d2746c26dbf9d38c2ea2

🧾 Summary (10% most significant diffs)

ContractMethodAvg (+/-)%
AlignedLayerServiceManagercreateNewTask+61 ❌+0.08%
Full diff report 👇
ContractDeployment Cost (+/-)MethodMin (+/-)%Avg (+/-)%Median (+/-)%Max (+/-)%# Calls (+/-)
AlignedLayerServiceManager5,231,234 (0)createNewTask56,047 (-12)-0.02%76,099 (+61)+0.08%76,259 (+72)+0.09%77,030 (+60)+0.08%256 (0)

@JuArce
JuArce marked this pull request as ready for review November 21, 2024 16:24
uri-99
uri-99 reviewed Nov 22, 2024
View reviewed changes

@uri-99uri-99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP review

Comment threaddocs/0_internal/1_multisig_creation.md Outdated
Comment threaddocs/0_internal/2_deploy_contracts.md Outdated
Comment threaddocs/0_internal/2_deploy_contracts.md Outdated
Comment threaddocs/0_internal/2_deploy_contracts.md Outdated
Comment threaddocs/0_internal/2_deploy_contracts.md Outdated
Comment threaddocs/0_internal/2_deploy_contracts.md Outdated
Comment threaddocs/0_internal/2_deploy_contracts.md Outdated
Comment threaddocs/0_internal/2_deploy_contracts.md Outdated
Comment threaddocs/0_internal/2_deploy_contracts.md Outdated
Comment threaddocs/0_internal/3_a_upgrade_contracts.md Outdated
uri-99
uri-99 reviewed Nov 22, 2024
View reviewed changes
Comment threaddocs/0_internal/3_b_2_propose_upgrade.md Outdated
MarcosNicolau
MarcosNicolau approved these changes Nov 25, 2024
View reviewed changes

@MarcosNicolauMarcosNicolau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation seemed really clear to me. Left a small comment on the upgrade guide, it is not necessary thou.

Comment threadMakefile
Comment threaddocs/0_internal/3_b_1_deploy_new_impl.md Outdated
@MauroToscano
MauroToscano added this pull request to the merge queueNov 26, 2024
Merged via the queue into staging with commit 86692fcNov 26, 2024
@MauroToscano
MauroToscano deleted the 1421-docs-improve-multisig-upgrade-tutorial branch November 26, 2024 14:46
@JuArceJuArce mentioned this pull request Nov 26, 2024
Merged
14 tasks
PatStiles pushed a commit that referenced this pull request Nov 27, 2024
@JuArce@uri-99
@MauroToscano@PatStiles
docs: improve multisig upgrade tutorial (#1429)
13bd340
Co-authored-by: Uriel Mihura <43704209+uri-99@users.noreply.github.com>
Co-authored-by: Mauro Toscano <12560266+MauroToscano@users.noreply.github.com>
Co-authored-by: MauroFab <maurotoscano2@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscanoMauroToscanoMauroToscano approved these changes
@MarcosNicolauMarcosNicolauMarcosNicolau approved these changes
+1 more reviewer
@uri-99uri-99uri-99 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@JuArceJuArce

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JuArce@MauroToscano@uri-99@MarcosNicolau