Uh oh!
There was an error while loading. Please reload this page.
fix: send aggregated response bump - #1440
Conversation
`SendAggregatedResponse` would overwrite `tx`, which in the error case sets it to `nil`, causing the retry to dereference `nil`. This fix consists on using separate variables for the simulated tx and the real one.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Julian Arce <52429267+JuArce@users.noreply.github.com>
Co-authored-by: Julian Arce <52429267+JuArce@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
LGTM.
Two issues to file:
- Sequential requests quadratic to the number of attempts. This can be postponed because it requires several attempts to be an issue, potentially many, so we're likely under a more problematic scenario than some slowness already.
- Metrics for the number of attempts and tracing would be more desirable than just logging (in fact, if we need to choose only one, tracing is better). This include events and spans, but can be a later refinement as well. That will help with diagnosis if this becomes a bottleneck.
Description
Fixes aggregator bump fee by adding the following checks:
10%higher than the previously sent transaction.Finally, tracing has been improved by adding step-by-step logs with the respective merkle root hash.
Type of change
Checklist
testnet, everything else tostaging