Skip to content

fix: set solidity version correctly - #1443

Merged
MauroToscano merged 1 commit into
stagingfrom
1442-fix-set-solidity-version-correctly
Nov 19, 2024
Merged

fix: set solidity version correctly#1443
MauroToscano merged 1 commit into
stagingfrom
1442-fix-set-solidity-version-correctly

Conversation

@JuArce

Copy link
Copy Markdown
Collaborator

Set solidity version correctly

Description

Deployer was setting v0.8.12 instead of v0.8.24

Type of change

  • Bug fix

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArceJuArce self-assigned this Nov 19, 2024
@github-actions

Copy link
Copy Markdown

Changes to gas cost

Generated at commit: b72572191880c118e30972ee23551c62063af642, compared to commit: 131599f57603b08c00844cc24341b4494b8e9b99

🧾 Summary (10% most significant diffs)

ContractMethodAvg (+/-)%
AlignedLayerServiceManagercreateNewTask-82 ✅-0.11%

Full diff report 👇
ContractDeployment Cost (+/-)MethodMin (+/-)%Avg (+/-)%Median (+/-)%Max (+/-)%# Calls (+/-)
AlignedLayerServiceManager5,231,234 (0)createNewTask
receive
56,047 (0)
23,317 (0)
0.00%
0.00%
75,971 (-82)
46,821 (-94)
-0.11%
-0.20%
76,223 (+24)
47,195 (0)
+0.03%
0.00%
77,006 (-63)
47,195 (0)
-0.08%
0.00%
256 (0)
256 (0)

@MauroToscano
MauroToscano merged commit ec260a4 into stagingNov 19, 2024
@MauroToscano
MauroToscano deleted the 1442-fix-set-solidity-version-correctly branch November 19, 2024 23:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@JuArce@MauroToscano@MarcosNicolau